From 6d52e8fc5b8727b5d4ec83d3123a03a9ac8d1c4e Mon Sep 17 00:00:00 2001 From: Christophe Bourcier Date: Mon, 25 Jun 2018 15:17:02 +0200 Subject: [PATCH] Two fixes in Export feature: - Cleaner private attribute initialization. - Don't check the error message, since the feature is deleted --- src/ExchangePlugin/ExchangePlugin_ExportFeature.cpp | 1 + src/ExchangePlugin/ExchangePlugin_ExportFeature.h | 2 +- src/ExchangePlugin/Test/Test2290.py | 2 -- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/ExchangePlugin/ExchangePlugin_ExportFeature.cpp b/src/ExchangePlugin/ExchangePlugin_ExportFeature.cpp index 8803b3d3c..7ab911d6c 100644 --- a/src/ExchangePlugin/ExchangePlugin_ExportFeature.cpp +++ b/src/ExchangePlugin/ExchangePlugin_ExportFeature.cpp @@ -65,6 +65,7 @@ ExchangePlugin_ExportFeature::ExchangePlugin_ExportFeature() { + _comes_from_export_to_geom = false; } ExchangePlugin_ExportFeature::~ExchangePlugin_ExportFeature() diff --git a/src/ExchangePlugin/ExchangePlugin_ExportFeature.h b/src/ExchangePlugin/ExchangePlugin_ExportFeature.h index 317c10858..3571d6eed 100644 --- a/src/ExchangePlugin/ExchangePlugin_ExportFeature.h +++ b/src/ExchangePlugin/ExchangePlugin_ExportFeature.h @@ -126,7 +126,7 @@ protected: EXCHANGEPLUGIN_EXPORT void exportXAO(const std::string& theFileName); private: - bool _comes_from_export_to_geom = false; + bool _comes_from_export_to_geom; }; #endif /* EXPORT_EXPORTFEATURE_H_ */ diff --git a/src/ExchangePlugin/Test/Test2290.py b/src/ExchangePlugin/Test/Test2290.py index 04a0ca50a..5671cead8 100644 --- a/src/ExchangePlugin/Test/Test2290.py +++ b/src/ExchangePlugin/Test/Test2290.py @@ -37,5 +37,3 @@ anExportFeature.string("ExportType").setValue("XAO") anExportFeature.string("xao_author").setValue("me") anExportFeature.string("xao_geometry_name").setValue("mygeom") model.end() - -assert anExportFeature.error() == "" -- 2.39.2