From bd8fa12f6e6f66560c7124300be23a1068135193 Mon Sep 17 00:00:00 2001 From: rkv Date: Thu, 11 Apr 2013 11:17:26 +0000 Subject: [PATCH] Satisfy some PMD rules. --- .../Siman-Common/src/org/splat/service/StudyService.java | 3 +-- .../src/org/splat/service/StudyServiceImpl.java | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Workspace/Siman-Common/src/org/splat/service/StudyService.java b/Workspace/Siman-Common/src/org/splat/service/StudyService.java index 507a5f3..73d498d 100644 --- a/Workspace/Siman-Common/src/org/splat/service/StudyService.java +++ b/Workspace/Siman-Common/src/org/splat/service/StudyService.java @@ -9,7 +9,6 @@ package org.splat.service; -import java.util.Date; import java.util.List; import org.splat.dal.bo.kernel.User; @@ -63,7 +62,7 @@ public interface StudyService { * @param index * the study id */ - public void removeStudy(final Long index); + void removeStudy(final Long index); /** * Create a new study. diff --git a/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java b/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java index d7e6b90..d75d3cc 100644 --- a/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java +++ b/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java @@ -1361,7 +1361,7 @@ public class StudyServiceImpl implements StudyService { public List getReaders(final long studyId) throws InvalidParameterException { Study aStudy = selectStudy(studyId); if(aStudy == null){ - throw new InvalidParameterException("studyId", String.valueOf(studyId)); + throw new InvalidParameterException(PARAM_STUDY_ID, String.valueOf(studyId)); } List relations = aStudy.getRelations(ReaderRelation.class); List result = new ArrayList(); @@ -1379,7 +1379,7 @@ public class StudyServiceImpl implements StudyService { public boolean addReader(final long studyId, final long userId) throws InvalidParameterException { Study aStudy = selectStudy(studyId); if(aStudy == null){ - throw new InvalidParameterException("studyId", String.valueOf(studyId)); + throw new InvalidParameterException(PARAM_STUDY_ID, String.valueOf(studyId)); } User user = _userService.selectUser(userId); if(user == null){ @@ -1404,7 +1404,7 @@ public class StudyServiceImpl implements StudyService { public boolean removeReader(final long studyId, final long userId) throws InvalidParameterException { Study aStudy = selectStudy(studyId); if(aStudy == null){ - throw new InvalidParameterException("studyId", String.valueOf(studyId)); + throw new InvalidParameterException(PARAM_STUDY_ID, String.valueOf(studyId)); } User user = _userService.selectUser(userId); if(user == null){ -- 2.30.2