From 451a8e2be97761bcd96a116d5d7b9a9d3d905467 Mon Sep 17 00:00:00 2001
From: dbv <dbv@opencascade.com>
Date: Wed, 11 Jan 2017 17:45:51 +0300
Subject: [PATCH] Issue #1940: error when Load python script.

Fixed order of named shapes when loading study.
---
 src/Model/Model_BodyBuilder.cpp | 37 +++++++++++++-------------
 src/Model/Model_Document.cpp    | 46 +++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+), 18 deletions(-)

diff --git a/src/Model/Model_BodyBuilder.cpp b/src/Model/Model_BodyBuilder.cpp
index 38b154348..2136750ba 100755
--- a/src/Model/Model_BodyBuilder.cpp
+++ b/src/Model/Model_BodyBuilder.cpp
@@ -72,24 +72,25 @@ static void evolutionToSelectionRec(TDF_Label theLab, const bool theFlag) {
       aShapePairs.push_front(std::pair<TopoDS_Shape, TopoDS_Shape>
         (anIter.OldShape(), anIter.NewShape()));
     }
-  }
-  // create new
-  TNaming_Builder aBuilder(theLab);
-  TNaming_Evolution anEvol = (TNaming_Evolution)(anEvolution);
-  std::list<std::pair<TopoDS_Shape, TopoDS_Shape> >::iterator aPairsIter = aShapePairs.begin();
-  for(; aPairsIter != aShapePairs.end(); aPairsIter++) {
-    if (theFlag) { // disabled => make selection
-      aBuilder.Select(aPairsIter->second, aPairsIter->first);
-    } else if (anEvol == TNaming_GENERATED) {
-      aBuilder.Generated(aPairsIter->first, aPairsIter->second);
-    } else if (anEvol == TNaming_MODIFY) {
-      aBuilder.Modify(aPairsIter->first, aPairsIter->second);
-    } else if (anEvol == TNaming_DELETE) {
-      aBuilder.Delete(aPairsIter->first);
-    } else if (anEvol == TNaming_PRIMITIVE) {
-      aBuilder.Generated(aPairsIter->second);
-    } else if (anEvol == TNaming_SELECTED) {
-      aBuilder.Select(aPairsIter->second, aPairsIter->first);
+
+    // create new
+    TNaming_Builder aBuilder(theLab);
+    TNaming_Evolution anEvol = (TNaming_Evolution)(anEvolution);
+    std::list<std::pair<TopoDS_Shape, TopoDS_Shape> >::iterator aPairsIter = aShapePairs.begin();
+    for(; aPairsIter != aShapePairs.end(); aPairsIter++) {
+      if (theFlag) { // disabled => make selection
+        aBuilder.Select(aPairsIter->second, aPairsIter->first);
+      } else if (anEvol == TNaming_GENERATED) {
+        aBuilder.Generated(aPairsIter->first, aPairsIter->second);
+      } else if (anEvol == TNaming_MODIFY) {
+        aBuilder.Modify(aPairsIter->first, aPairsIter->second);
+      } else if (anEvol == TNaming_DELETE) {
+        aBuilder.Delete(aPairsIter->first);
+      } else if (anEvol == TNaming_PRIMITIVE) {
+        aBuilder.Generated(aPairsIter->second);
+      } else if (anEvol == TNaming_SELECTED) {
+        aBuilder.Select(aPairsIter->second, aPairsIter->first);
+      }
     }
   }
   // recursive call for all sub-labels
diff --git a/src/Model/Model_Document.cpp b/src/Model/Model_Document.cpp
index 4311f40f6..2afecb39c 100755
--- a/src/Model/Model_Document.cpp
+++ b/src/Model/Model_Document.cpp
@@ -38,6 +38,7 @@
 #include <TDF_ListIteratorOfLabelList.hxx>
 #include <TDF_LabelMap.hxx>
 #include <TDF_DeltaOnAddition.hxx>
+#include <TNaming_Builder.hxx>
 #include <TNaming_SameShapeIterator.hxx>
 #include <TNaming_Iterator.hxx>
 #include <TNaming_NamedShape.hxx>
@@ -196,6 +197,51 @@ bool Model_Document::load(const char* theDirName, const char* theFileName, Docum
   if (!isError) {
     myDoc = aLoaded;
     myDoc->SetUndoLimit(UNDO_LIMIT);
+
+    // TODO: remove after fix in OCCT.
+    // All named shapes are stored in reversed order, so to fix this we reverse them back.
+    for(TDF_ChildIDIterator aChildIter(myDoc->Main(), TNaming_NamedShape::GetID(), true);
+        aChildIter.More();
+        aChildIter.Next()) {
+      Handle(TNaming_NamedShape) aNamedShape =
+        Handle(TNaming_NamedShape)::DownCast(aChildIter.Value());
+      if (aNamedShape.IsNull()) {
+        continue;
+      }
+
+      TopoDS_Shape aShape = aNamedShape->Get();
+      if(aShape.IsNull() || aShape.ShapeType() != TopAbs_COMPOUND) {
+        continue;
+      }
+
+      TNaming_Evolution anEvol = aNamedShape->Evolution();
+      std::list<std::pair<TopoDS_Shape, TopoDS_Shape> > aShapePairs; // to store old and new shapes
+      for(TNaming_Iterator anIter(aNamedShape); anIter.More(); anIter.Next()) {
+        aShapePairs.push_back(
+          std::pair<TopoDS_Shape, TopoDS_Shape>(anIter.OldShape(), anIter.NewShape()));
+      }
+
+      // Add in reverse order.
+      TDF_Label aLabel = aNamedShape->Label();
+      TNaming_Builder aBuilder(aLabel);
+      for(std::list<std::pair<TopoDS_Shape, TopoDS_Shape> >::iterator aPairsIter =
+            aShapePairs.begin();
+          aPairsIter != aShapePairs.end();
+          aPairsIter++) {
+        if (anEvol == TNaming_GENERATED) {
+          aBuilder.Generated(aPairsIter->first, aPairsIter->second);
+        } else if (anEvol == TNaming_MODIFY) {
+          aBuilder.Modify(aPairsIter->first, aPairsIter->second);
+        } else if (anEvol == TNaming_DELETE) {
+          aBuilder.Delete(aPairsIter->first);
+        } else if (anEvol == TNaming_PRIMITIVE) {
+          aBuilder.Generated(aPairsIter->second);
+        } else if (anEvol == TNaming_SELECTED) {
+          aBuilder.Select(aPairsIter->second, aPairsIter->first);
+        }
+      }
+    }
+
     // to avoid the problem that feature is created in the current, not this, document
     aSession->setActiveDocument(anApp->document(myID), false);
     aSession->setCheckTransactions(false);
-- 
2.39.2