From a76006d25043c53afcc58863458c550c4d591bf1 Mon Sep 17 00:00:00 2001
From: mpv <mpv@opencascade.com>
Date: Mon, 31 May 2021 11:40:32 +0300
Subject: [PATCH] bos #24260 [CEA] Fatal error gp_Dir() input vector has zero
 norm when loading python dump

Added an understandable error-message if the sketch plane is invalid.
---
 src/ModelAPI/ModelAPI_Tools.cpp         | 10 ++++++++++
 src/SketchPlugin/SketchPlugin_msg_fr.ts |  5 +++++
 2 files changed, 15 insertions(+)

diff --git a/src/ModelAPI/ModelAPI_Tools.cpp b/src/ModelAPI/ModelAPI_Tools.cpp
index 9b9a83531..136336a15 100644
--- a/src/ModelAPI/ModelAPI_Tools.cpp
+++ b/src/ModelAPI/ModelAPI_Tools.cpp
@@ -41,6 +41,7 @@
 #include <Events_Loop.h>
 #include <Locale_Convert.h>
 #include <ModelAPI_Events.h>
+#include <Config_Translator.h>
 
 #include <GeomAPI_ShapeHierarchy.h>
 #include <GeomAPI_ShapeIterator.h>
@@ -153,14 +154,23 @@ std::string getFeatureError(const FeaturePtr& theFeature)
         CompositeFeaturePtr aComposite =
                     std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(theFeature);
         if (aComposite) {
+          bool aHasSubError = false;
           for (int i = 0, aSize = aComposite->numberOfSubs(); i < aSize; i++) {
             FeaturePtr aSubFeature = aComposite->subFeature(i);
             std::string aSubFeatureError = getFeatureError(aSubFeature);
             if (!aSubFeatureError.empty()) {
               anError = anError + " in " + aSubFeature->getKind() + ".\n" + aSubFeatureError;
+              aHasSubError = true;
               break;
             }
           }
+          if (!aHasSubError) { // #24260: error not in the sub-features, but in the argument
+            if (aComposite->getKind() == "Sketch" &&
+                aComposite->selection("External")->isInvalid()) {
+              anError = Config_Translator::translate(aComposite->getKind(), "The sketch base plane \
+is invalid, please push 'Change sketch plane' button to reselect it.");
+            }
+          }
         }
       }
     }
diff --git a/src/SketchPlugin/SketchPlugin_msg_fr.ts b/src/SketchPlugin/SketchPlugin_msg_fr.ts
index 9d6673d54..1bd553e91 100644
--- a/src/SketchPlugin/SketchPlugin_msg_fr.ts
+++ b/src/SketchPlugin/SketchPlugin_msg_fr.ts
@@ -150,6 +150,11 @@
       <source>Attribute "%1" is not initialized.</source>
       <translation>Sélectionnez un plan pour l&apos;esquisse</translation>
     </message>
+    <name>Sketch</name>
+    <message>
+      <source>The sketch base plane is invalid, please push &apos;Change sketch plane&apos; button to reselect it.</source>
+      <translation>Le plan de base de l&apos;esquisse n&apos;est pas valide, veuillez appuyer sur le bouton &apos;Changer le plan de&apos;esquisse&apos; pour le resélectionner.</translation>
+    </message>
   </context>
   <context>
     <name>Sketch:DirX</name>
-- 
2.39.2