From d5009408b937be1a3436028eec3ef4a920e999a9 Mon Sep 17 00:00:00 2001 From: spo Date: Fri, 17 Jun 2016 18:41:43 +0300 Subject: [PATCH] Remove some TODOs --- src/BuildAPI/BuildAPI_Edge.cpp | 1 - src/BuildAPI/BuildAPI_Face.cpp | 1 - src/BuildAPI/BuildAPI_Shell.cpp | 1 - src/BuildAPI/BuildAPI_SubShapes.cpp | 1 - src/BuildAPI/BuildAPI_Vertex.cpp | 1 - src/BuildAPI/BuildAPI_Wire.cpp | 1 - src/ConnectorAPI/ConnectorAPI_Connector.cpp | 2 +- src/ConstructionAPI/ConstructionAPI_Axis.cpp | 2 -- src/ConstructionAPI/ConstructionAPI_Plane.cpp | 2 -- src/ConstructionAPI/ConstructionAPI_Point.cpp | 1 - src/ExchangeAPI/ExchangeAPI_Import.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Boolean.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Extrusion.cpp | 1 - src/FeaturesAPI/FeaturesAPI_ExtrusionBoolean.cpp | 2 -- src/FeaturesAPI/FeaturesAPI_Group.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Intersection.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Partition.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Pipe.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Placement.cpp | 1 - src/FeaturesAPI/FeaturesAPI_RemoveSubShapes.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Revolution.cpp | 1 - src/FeaturesAPI/FeaturesAPI_RevolutionBoolean.cpp | 2 -- src/FeaturesAPI/FeaturesAPI_Rotation.cpp | 1 - src/FeaturesAPI/FeaturesAPI_Translation.cpp | 1 - src/ParametersAPI/ParametersAPI_Parameter.cpp | 6 +++--- src/SketchAPI/SketchAPI_Sketch.h | 2 -- 26 files changed, 4 insertions(+), 33 deletions(-) diff --git a/src/BuildAPI/BuildAPI_Edge.cpp b/src/BuildAPI/BuildAPI_Edge.cpp index 5ccb854e0..a1a1a03df 100644 --- a/src/BuildAPI/BuildAPI_Edge.cpp +++ b/src/BuildAPI/BuildAPI_Edge.cpp @@ -39,7 +39,6 @@ void BuildAPI_Edge::setBase(const std::list& theBaseObje execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== EdgePtr addEdge(const std::shared_ptr& thePart, const std::list& theBaseObjects) diff --git a/src/BuildAPI/BuildAPI_Face.cpp b/src/BuildAPI/BuildAPI_Face.cpp index 930021d39..3f5cf71df 100644 --- a/src/BuildAPI/BuildAPI_Face.cpp +++ b/src/BuildAPI/BuildAPI_Face.cpp @@ -39,7 +39,6 @@ void BuildAPI_Face::setBase(const std::list& theBaseObje execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== FacePtr addFace(const std::shared_ptr& thePart, const std::list& theBaseObjects) diff --git a/src/BuildAPI/BuildAPI_Shell.cpp b/src/BuildAPI/BuildAPI_Shell.cpp index d504c261a..86151b4cf 100644 --- a/src/BuildAPI/BuildAPI_Shell.cpp +++ b/src/BuildAPI/BuildAPI_Shell.cpp @@ -39,7 +39,6 @@ void BuildAPI_Shell::setBase(const std::list& theBaseObj execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== ShellPtr addShell(const std::shared_ptr& thePart, const std::list& theBaseObjects) diff --git a/src/BuildAPI/BuildAPI_SubShapes.cpp b/src/BuildAPI/BuildAPI_SubShapes.cpp index b6e2a729b..c4eaafb4f 100644 --- a/src/BuildAPI/BuildAPI_SubShapes.cpp +++ b/src/BuildAPI/BuildAPI_SubShapes.cpp @@ -49,7 +49,6 @@ void BuildAPI_SubShapes::setSubShapes(const std::list& t execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== SubShapesPtr addSubShapes(const std::shared_ptr& thePart, const ModelHighAPI_Selection& theBaseShape, diff --git a/src/BuildAPI/BuildAPI_Vertex.cpp b/src/BuildAPI/BuildAPI_Vertex.cpp index a3b71ae5f..b1723c84e 100644 --- a/src/BuildAPI/BuildAPI_Vertex.cpp +++ b/src/BuildAPI/BuildAPI_Vertex.cpp @@ -39,7 +39,6 @@ void BuildAPI_Vertex::setBase(const std::list& theBaseOb execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== VertexPtr addVertex(const std::shared_ptr& thePart, const std::list& theBaseObjects) diff --git a/src/BuildAPI/BuildAPI_Wire.cpp b/src/BuildAPI/BuildAPI_Wire.cpp index 66631c74f..58a498954 100644 --- a/src/BuildAPI/BuildAPI_Wire.cpp +++ b/src/BuildAPI/BuildAPI_Wire.cpp @@ -45,7 +45,6 @@ void BuildAPI_Wire::addContour() feature()->customAction(BuildPlugin_Wire::ADD_CONTOUR_ACTION_ID()); } -// TODO(spo): make add* as static functions of the class //================================================================================================== WirePtr addWire(const std::shared_ptr& thePart, const std::list& theBaseObjects) diff --git a/src/ConnectorAPI/ConnectorAPI_Connector.cpp b/src/ConnectorAPI/ConnectorAPI_Connector.cpp index 2a48f702c..1aa191693 100644 --- a/src/ConnectorAPI/ConnectorAPI_Connector.cpp +++ b/src/ConnectorAPI/ConnectorAPI_Connector.cpp @@ -12,7 +12,7 @@ //-------------------------------------------------------------------------------------- void exportToGEOM(const std::shared_ptr & thePart) { - // TODO(spo): check that theConnector is not empty + // TODO(spo): check that thePart is not empty std::shared_ptr aFeature = thePart->addFeature("ExportToGEOM"); aFeature->execute(); } diff --git a/src/ConstructionAPI/ConstructionAPI_Axis.cpp b/src/ConstructionAPI/ConstructionAPI_Axis.cpp index 2d42f790e..352320e1d 100644 --- a/src/ConstructionAPI/ConstructionAPI_Axis.cpp +++ b/src/ConstructionAPI/ConstructionAPI_Axis.cpp @@ -89,8 +89,6 @@ void ConstructionAPI_Axis::setPointAndDirection( } //-------------------------------------------------------------------------------------- -// TODO(spo): make add* as static functions of the class - AxisPtr addAxis(const std::shared_ptr & thePart, const ModelHighAPI_Selection & thePoint1, const ModelHighAPI_Selection & thePoint2) diff --git a/src/ConstructionAPI/ConstructionAPI_Plane.cpp b/src/ConstructionAPI/ConstructionAPI_Plane.cpp index 5799f5498..61a72e061 100644 --- a/src/ConstructionAPI/ConstructionAPI_Plane.cpp +++ b/src/ConstructionAPI/ConstructionAPI_Plane.cpp @@ -69,8 +69,6 @@ void ConstructionAPI_Plane::setGeneralEquation( } //-------------------------------------------------------------------------------------- -// TODO(spo): make add* as static functions of the class - PlanePtr addPlane(const std::shared_ptr & thePart, const ModelHighAPI_Selection & theFace, const ModelHighAPI_Double & theDistance) diff --git a/src/ConstructionAPI/ConstructionAPI_Point.cpp b/src/ConstructionAPI/ConstructionAPI_Point.cpp index bcfd93848..ff5a89de3 100644 --- a/src/ConstructionAPI/ConstructionAPI_Point.cpp +++ b/src/ConstructionAPI/ConstructionAPI_Point.cpp @@ -45,7 +45,6 @@ void ConstructionAPI_Point::setPoint(const ModelHighAPI_Double & theX, } //-------------------------------------------------------------------------------------- -// TODO(spo): make add* as static functions of the class PointPtr addPoint( const std::shared_ptr & thePart, const ModelHighAPI_Double& theX, diff --git a/src/ExchangeAPI/ExchangeAPI_Import.cpp b/src/ExchangeAPI/ExchangeAPI_Import.cpp index fe1bf0bf0..0c2e7ff7d 100644 --- a/src/ExchangeAPI/ExchangeAPI_Import.cpp +++ b/src/ExchangeAPI/ExchangeAPI_Import.cpp @@ -39,7 +39,6 @@ void ExchangeAPI_Import::setFilePath(const std::string & theFilePath) } //-------------------------------------------------------------------------------------- -// TODO(spo): make add* as static functions of the class ImportPtr addImport( const std::shared_ptr & thePart, const std::string & theFilePath) diff --git a/src/FeaturesAPI/FeaturesAPI_Boolean.cpp b/src/FeaturesAPI/FeaturesAPI_Boolean.cpp index 128b9abfc..0774fb529 100644 --- a/src/FeaturesAPI/FeaturesAPI_Boolean.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Boolean.cpp @@ -63,7 +63,6 @@ void FeaturesAPI_Boolean::setToolObjects(const std::list execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== BooleanPtr addCut(const std::shared_ptr& thePart, const std::list& theMainObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_Extrusion.cpp b/src/FeaturesAPI/FeaturesAPI_Extrusion.cpp index 7c993db0b..d79749b5f 100644 --- a/src/FeaturesAPI/FeaturesAPI_Extrusion.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Extrusion.cpp @@ -160,7 +160,6 @@ void FeaturesAPI_Extrusion::setPlanesAndOffsets(const ModelHighAPI_Selection& th execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== ExtrusionPtr addExtrusion(const std::shared_ptr& thePart, const std::list& theBaseObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_ExtrusionBoolean.cpp b/src/FeaturesAPI/FeaturesAPI_ExtrusionBoolean.cpp index 92587dc85..357421b6e 100644 --- a/src/FeaturesAPI/FeaturesAPI_ExtrusionBoolean.cpp +++ b/src/FeaturesAPI/FeaturesAPI_ExtrusionBoolean.cpp @@ -195,7 +195,6 @@ FeaturesAPI_ExtrusionCut::FeaturesAPI_ExtrusionCut(const std::shared_ptr& thePart, const std::list& theBaseObjects, @@ -401,7 +400,6 @@ FeaturesAPI_ExtrusionFuse::FeaturesAPI_ExtrusionFuse(const std::shared_ptr& thePart, const std::list& theBaseObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_Group.cpp b/src/FeaturesAPI/FeaturesAPI_Group.cpp index f942c0925..274fe8e40 100644 --- a/src/FeaturesAPI/FeaturesAPI_Group.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Group.cpp @@ -41,7 +41,6 @@ void FeaturesAPI_Group::setGroupList(const std::list& th execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== GroupPtr addGroup(const std::shared_ptr& thePart, const std::list& theGroupList) diff --git a/src/FeaturesAPI/FeaturesAPI_Intersection.cpp b/src/FeaturesAPI/FeaturesAPI_Intersection.cpp index cefd80e6e..ce33f83da 100644 --- a/src/FeaturesAPI/FeaturesAPI_Intersection.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Intersection.cpp @@ -51,7 +51,6 @@ void FeaturesAPI_Intersection::setTools(const std::list& execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== IntersectionPtr addIntersection(const std::shared_ptr& thePart, const std::list& theObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_Partition.cpp b/src/FeaturesAPI/FeaturesAPI_Partition.cpp index b0e3589cd..2b4515fc2 100644 --- a/src/FeaturesAPI/FeaturesAPI_Partition.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Partition.cpp @@ -39,7 +39,6 @@ void FeaturesAPI_Partition::setBase(const std::list& the execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== PartitionPtr addPartition(const std::shared_ptr& thePart, const std::list& theBaseObjects) diff --git a/src/FeaturesAPI/FeaturesAPI_Pipe.cpp b/src/FeaturesAPI/FeaturesAPI_Pipe.cpp index a7e49e031..3ca9a4e54 100644 --- a/src/FeaturesAPI/FeaturesAPI_Pipe.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Pipe.cpp @@ -110,7 +110,6 @@ void FeaturesAPI_Pipe::setByBasePathLocations(const std::list& thePart, const std::list& theBaseObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_Placement.cpp b/src/FeaturesAPI/FeaturesAPI_Placement.cpp index e70411417..f45264e14 100644 --- a/src/FeaturesAPI/FeaturesAPI_Placement.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Placement.cpp @@ -79,7 +79,6 @@ void FeaturesAPI_Placement::setCentering(const bool theCentering) execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== PlacementPtr addPlacement(const std::shared_ptr& thePart, const std::list& theObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_RemoveSubShapes.cpp b/src/FeaturesAPI/FeaturesAPI_RemoveSubShapes.cpp index 79c3c6f0b..4d0726eff 100644 --- a/src/FeaturesAPI/FeaturesAPI_RemoveSubShapes.cpp +++ b/src/FeaturesAPI/FeaturesAPI_RemoveSubShapes.cpp @@ -49,7 +49,6 @@ void FeaturesAPI_RemoveSubShapes::setSubShapesToKeep(const std::list& thePart, const ModelHighAPI_Selection& theBase) diff --git a/src/FeaturesAPI/FeaturesAPI_Revolution.cpp b/src/FeaturesAPI/FeaturesAPI_Revolution.cpp index bae189abf..fc982e9c1 100644 --- a/src/FeaturesAPI/FeaturesAPI_Revolution.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Revolution.cpp @@ -120,7 +120,6 @@ void FeaturesAPI_Revolution::setPlanesAndOffsets(const ModelHighAPI_Selection& t execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== RevolutionPtr addRevolution(const std::shared_ptr& thePart, const std::list& theBaseObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_RevolutionBoolean.cpp b/src/FeaturesAPI/FeaturesAPI_RevolutionBoolean.cpp index 6590d1acc..3ca6f2b7d 100644 --- a/src/FeaturesAPI/FeaturesAPI_RevolutionBoolean.cpp +++ b/src/FeaturesAPI/FeaturesAPI_RevolutionBoolean.cpp @@ -144,7 +144,6 @@ FeaturesAPI_RevolutionCut::FeaturesAPI_RevolutionCut(const std::shared_ptr& thePart, const std::list& theBaseObjects, @@ -259,7 +258,6 @@ FeaturesAPI_RevolutionFuse::FeaturesAPI_RevolutionFuse(const std::shared_ptr& thePart, const std::list& theBaseObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_Rotation.cpp b/src/FeaturesAPI/FeaturesAPI_Rotation.cpp index 053a10f7d..861f3da00 100644 --- a/src/FeaturesAPI/FeaturesAPI_Rotation.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Rotation.cpp @@ -59,7 +59,6 @@ void FeaturesAPI_Rotation::setAngle(const ModelHighAPI_Double& theAngle) execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== RotationPtr addRotation(const std::shared_ptr& thePart, const std::list& theMainObjects, diff --git a/src/FeaturesAPI/FeaturesAPI_Translation.cpp b/src/FeaturesAPI/FeaturesAPI_Translation.cpp index 5037e4bfd..46a977c96 100644 --- a/src/FeaturesAPI/FeaturesAPI_Translation.cpp +++ b/src/FeaturesAPI/FeaturesAPI_Translation.cpp @@ -59,7 +59,6 @@ void FeaturesAPI_Translation::setDistance(const ModelHighAPI_Double& theDistance execute(); } -// TODO(spo): make add* as static functions of the class //================================================================================================== TranslationPtr addTranslation(const std::shared_ptr& thePart, const std::list& theMainObjects, diff --git a/src/ParametersAPI/ParametersAPI_Parameter.cpp b/src/ParametersAPI/ParametersAPI_Parameter.cpp index fc89a2392..0faa1346a 100644 --- a/src/ParametersAPI/ParametersAPI_Parameter.cpp +++ b/src/ParametersAPI/ParametersAPI_Parameter.cpp @@ -37,12 +37,12 @@ ParametersAPI_Parameter::~ParametersAPI_Parameter() } //-------------------------------------------------------------------------------------- -ParameterPtr addParameter(const std::shared_ptr & theParameter, +ParameterPtr addParameter(const std::shared_ptr & thePart, const std::string & theName, const std::string & theExpression, const std::string & theComment) { - // TODO(spo): check that theParameter is not empty - std::shared_ptr aFeature = theParameter->addFeature(ParametersAPI_Parameter::ID()); + // TODO(spo): check that thePart is not empty + std::shared_ptr aFeature = thePart->addFeature(ParametersAPI_Parameter::ID()); return ParameterPtr(new ParametersAPI_Parameter(aFeature, theName, theExpression, theComment)); } diff --git a/src/SketchAPI/SketchAPI_Sketch.h b/src/SketchAPI/SketchAPI_Sketch.h index 35edecfe2..e23f9dd90 100644 --- a/src/SketchAPI/SketchAPI_Sketch.h +++ b/src/SketchAPI/SketchAPI_Sketch.h @@ -75,8 +75,6 @@ public: SKETCHAPI_EXPORT void setExternal(const ModelHighAPI_Selection & theExternal); - // TODO(spo): addIntersection - /// Add point SKETCHAPI_EXPORT std::shared_ptr addPoint( -- 2.30.2