From 98b0eab889ee176f038e9b0b0ff947b7ed110719 Mon Sep 17 00:00:00 2001 From: nds Date: Wed, 15 Apr 2015 18:50:39 +0300 Subject: [PATCH] Export definition for compillation on Windows; clear virtual method isValid is moved to protected area because it is not called outside this validator. --- .../ModuleBase_SelectionValidator.cpp | 4 ---- .../ModuleBase_SelectionValidator.h | 11 +++++----- src/PartSet/PartSet_Validators.h | 20 +++++++++---------- 3 files changed, 15 insertions(+), 20 deletions(-) diff --git a/src/ModuleBase/ModuleBase_SelectionValidator.cpp b/src/ModuleBase/ModuleBase_SelectionValidator.cpp index fa9b27e5e..7c92d953d 100644 --- a/src/ModuleBase/ModuleBase_SelectionValidator.cpp +++ b/src/ModuleBase/ModuleBase_SelectionValidator.cpp @@ -6,10 +6,6 @@ #include -ModuleBase_SelectionValidator::~ModuleBase_SelectionValidator() -{ -} - bool ModuleBase_SelectionValidator::isValid(const ModuleBase_ISelection* theSelection, const std::list& theArguments) const { diff --git a/src/ModuleBase/ModuleBase_SelectionValidator.h b/src/ModuleBase/ModuleBase_SelectionValidator.h index f3d34617f..60d957400 100644 --- a/src/ModuleBase/ModuleBase_SelectionValidator.h +++ b/src/ModuleBase/ModuleBase_SelectionValidator.h @@ -22,17 +22,16 @@ class ModuleBase_SelectionValidator : public ModelAPI_Validator { public: - virtual ~ModuleBase_SelectionValidator(); - /// Returns True if selection is valid - /// \param theSelection selection instance - virtual bool isValid(const ModuleBase_ISelection* theSelection) const = 0; - /// Returns True if selection is valid /// \param theSelection selection instance /// \param theArguments list of arguments - virtual bool isValid(const ModuleBase_ISelection* theSelection, + virtual MODULEBASE_EXPORT bool isValid(const ModuleBase_ISelection* theSelection, const std::list& theArguments) const; + protected: + /// Returns True if selection is valid + /// \param theSelection selection instance + virtual bool isValid(const ModuleBase_ISelection* theSelection) const = 0; }; #endif diff --git a/src/PartSet/PartSet_Validators.h b/src/PartSet/PartSet_Validators.h index 7d78aeb10..92eb3a71d 100644 --- a/src/PartSet/PartSet_Validators.h +++ b/src/PartSet/PartSet_Validators.h @@ -21,7 +21,7 @@ //! A class to validate a selection for Distance constraint operation class PartSet_DistanceSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -29,7 +29,7 @@ class PartSet_DistanceSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Length constraint operation class PartSet_LengthSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -37,7 +37,7 @@ class PartSet_LengthSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Perpendicular constraint operation class PartSet_PerpendicularSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -45,7 +45,7 @@ class PartSet_PerpendicularSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Parallel constraint operation class PartSet_ParallelSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -53,7 +53,7 @@ class PartSet_ParallelSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Radius constraint operation class PartSet_RadiusSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -61,7 +61,7 @@ class PartSet_RadiusSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Rigid constraint operation class PartSet_RigidSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -70,7 +70,7 @@ class PartSet_RigidSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for coincedence constraint operation class PartSet_CoincidentSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -78,7 +78,7 @@ class PartSet_CoincidentSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Horizontal and Vertical constraints operation class PartSet_HVDirSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -86,7 +86,7 @@ class PartSet_HVDirSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Tangential constraints operation class PartSet_TangentSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; @@ -94,7 +94,7 @@ class PartSet_TangentSelection : public ModuleBase_SelectionValidator //! A class to validate a selection for Fillet constraints operation class PartSet_FilletSelection : public ModuleBase_SelectionValidator { - public: + protected: PARTSET_EXPORT virtual bool isValid(const ModuleBase_ISelection* theSelection) const; }; -- 2.39.2