]> SALOME platform Git repositories - modules/shaper.git/log
Salome HOME
modules/shaper.git
8 years agoRemove unused static function
azv [Wed, 20 Jan 2016 07:17:27 +0000 (10:17 +0300)]
Remove unused static function

8 years agoTODO cleanup
dbv [Tue, 19 Jan 2016 14:47:39 +0000 (17:47 +0300)]
TODO cleanup

8 years agoUpdate sketcher unit tests for code coverage
azv [Mon, 18 Jan 2016 07:55:25 +0000 (10:55 +0300)]
Update sketcher unit tests for code coverage

8 years agoImrove multi-selector control to provide items multi-selection. Delete key in line...
nds [Mon, 18 Jan 2016 07:35:38 +0000 (10:35 +0300)]
Imrove multi-selector control to provide items multi-selection. Delete key in line edit should not abort the current operation.

8 years agoImrove multi-selector control to provide items multi-selection. Activate/deactivate...
nds [Fri, 15 Jan 2016 18:33:33 +0000 (21:33 +0300)]
Imrove multi-selector control to provide items multi-selection. Activate/deactivate highlight customization of the active widget.

When the widget is deactivated, selected items should not be visualized in the viewer in half-highlighted color.

8 years agoImrove multi-selector control to provide items multi-selection. Preferences color...
nds [Fri, 15 Jan 2016 17:29:51 +0000 (20:29 +0300)]
Imrove multi-selector control to provide items multi-selection. Preferences color should be applyed by the next presentations visualization.

8 years agoImrove multi-selector control to provide items multi-selection. Preferences color...
nds [Fri, 15 Jan 2016 15:58:34 +0000 (18:58 +0300)]
Imrove multi-selector control to provide items multi-selection. Preferences color should be applyed by the next presentations visualization.

8 years agoImrove multi-selector control to provide items multi-selection. Division of the opera...
nds [Fri, 15 Jan 2016 15:41:43 +0000 (18:41 +0300)]
Imrove multi-selector control to provide items multi-selection. Division of the operation presentation in two parts: shape+result and multi-selector highlighted. For better performance: by multi-selector control selection, the shape+result should not be recomputed and redisplayed.

8 years agoRemoved OpenParts windows scripts
dbv [Fri, 15 Jan 2016 14:26:42 +0000 (17:26 +0300)]
Removed OpenParts windows scripts

8 years agoPlaneGCS hangs up (issue #1183)
azv [Fri, 15 Jan 2016 13:45:46 +0000 (16:45 +0300)]
PlaneGCS hangs up (issue #1183)

Avoid adding copied entities of MultiRotation and MultiTranslation constraints into solver to decrease number of used unknowns and constraints.

8 years agoInvalid shape after extrusion (issue #1203)
azv [Fri, 15 Jan 2016 13:43:07 +0000 (16:43 +0300)]
Invalid shape after extrusion (issue #1203)

1. Use General Fuse to build areas of a sketch
2. Update unit tests

8 years agoLinux compilation fix.
dbv [Fri, 15 Jan 2016 13:35:45 +0000 (16:35 +0300)]
Linux compilation fix.

8 years agoImprovement #630: Positive validator: avoid hard constants
dbv [Fri, 15 Jan 2016 13:30:29 +0000 (16:30 +0300)]
Improvement #630: Positive validator: avoid hard constants

8 years agoIssue #1199 - Fatal error when edit parameter: do not visualize operation prs when...
nds [Fri, 15 Jan 2016 08:21:00 +0000 (11:21 +0300)]
Issue #1199 - Fatal error when edit parameter: do not visualize operation prs when result has no a shape.

8 years agoBUG: Sketch plane is initialized by click in empty place
nds [Thu, 14 Jan 2016 13:40:48 +0000 (16:40 +0300)]
BUG: Sketch plane is initialized by click in empty place

Scenario:
Start sketch
Move mouse over planes(one of them is highlighted)
Click in empty place
Result: sketch nested actions are enabled, sketch planes stayed in the viewer.

8 years agoCorrection for Delete processing.
nds [Thu, 14 Jan 2016 11:41:05 +0000 (14:41 +0300)]
Correction for Delete processing.

It should be done in a separate listener. Because when operation manager is an install filter for qApp, it will process, besides Delete key, Enter key release of application. But we need to process Enter key release only for Property Panel.
In previous case there were regressions, such as:
1. OpenParts: dimension constraint, Enter in flyout point do nothing
2. OpenParts: enter in save dialog leads to crash.

8 years ago3.9 Clean the history. Compilation correction.
nds [Thu, 14 Jan 2016 10:04:11 +0000 (13:04 +0300)]
3.9 Clean the history. Compilation correction.

8 years ago3.9 Clean the history
nds [Wed, 13 Jan 2016 14:52:28 +0000 (17:52 +0300)]
3.9 Clean the history

8 years agoIssue 812:
nds [Wed, 13 Jan 2016 10:36:24 +0000 (13:36 +0300)]
Issue 812:

"In the Sketcher, it is required to be able to display or not separatly the dimensional and geometrical constraints. For that, a check button must be added in the panel of the Sketcher, by default both (""Show dimensional contraints"", ""Show geometrical contraints"") checked."

8 years agoChecking Enter processing functionality(with Delete processing). Sketch-Mirror featur...
nds [Wed, 13 Jan 2016 07:53:33 +0000 (10:53 +0300)]
Checking Enter processing functionality(with Delete processing). Sketch-Mirror feature do not deactivate multi-selector control however focus is moved to Apply button. It is corrected.

8 years agoImprove multi-selector control to provide "Delete" key processing.
nds [Wed, 13 Jan 2016 05:36:42 +0000 (08:36 +0300)]
Improve multi-selector control to provide "Delete" key processing.

Shortcut can not be used for it because there is a conflict in Qt which one should be performed.
So, OperationMgr processes it from property panel and application on the whole(qApp->installEventFilter(this)).

8 years agoImprove multi-selector control to provide width colored presentation of selected...
nds [Tue, 12 Jan 2016 13:13:22 +0000 (16:13 +0300)]
Improve multi-selector control to provide width colored presentation of selected items.

8 years agoImprove multi-selector control to provide items multi-selection and "Delete" context...
nds [Tue, 12 Jan 2016 03:48:04 +0000 (06:48 +0300)]
Improve multi-selector control to provide items multi-selection and "Delete" context menu action.

8 years agoImplementation of remove of elements from the list by indexes
mpv [Mon, 11 Jan 2016 17:04:21 +0000 (20:04 +0300)]
Implementation of remove of elements from the list by indexes

8 years agoBug #1204: Boolean operations input panel misprint
dbv [Mon, 11 Jan 2016 14:13:49 +0000 (17:13 +0300)]
Bug #1204: Boolean operations input panel misprint

8 years agoImprove multi-selector control to provide items multi-selection and "Delete" context...
nds [Mon, 11 Jan 2016 13:21:31 +0000 (16:21 +0300)]
Improve multi-selector control to provide items multi-selection and "Delete" context menu action.

8 years agoPrepare CMakeLists.txt files to use for OpenParts
spo [Mon, 11 Jan 2016 10:46:45 +0000 (13:46 +0300)]
Prepare CMakeLists.txt files to use for OpenParts

8 years agoUpdate processing coincidence between origin and a line's attribute (issue #1181)
azv [Tue, 29 Dec 2015 13:57:39 +0000 (16:57 +0300)]
Update processing coincidence between origin and a line's attribute (issue #1181)

8 years agoIncorrect working of Sketch builder is fixed (issue #1184)
azv [Tue, 29 Dec 2015 12:16:12 +0000 (15:16 +0300)]
Incorrect working of Sketch builder is fixed (issue #1184)

8 years ago#1199 Fatal error when edit parameter
nds [Tue, 29 Dec 2015 12:31:12 +0000 (15:31 +0300)]
#1199 Fatal error when edit parameter

8 years agoConcealed state should be checked on feature created signal accepting.
nds [Tue, 29 Dec 2015 12:30:09 +0000 (15:30 +0300)]
Concealed state should be checked on feature created signal accepting.

Scenario:
1. Create Extrusion, ExtrusionSketch, Boolean between them, ExtrusionCut, Partition.
2. Save study
3. Open saved study. The ExtrusionCut result is visualized. Call Hide for Partition, ExtrusionCut is in the viewer however there is no such a result in Bodies.

8 years agoPreparation for delivery 2.1.0 Dev_2.1.0 V_2.1.0
mpv [Mon, 28 Dec 2015 15:12:40 +0000 (18:12 +0300)]
Preparation for delivery 2.1.0

8 years agoFix Squsih test suite_FEATURE_REVOLUTION/tst_revolution_005
spo [Mon, 28 Dec 2015 14:24:27 +0000 (17:24 +0300)]
Fix Squsih test suite_FEATURE_REVOLUTION/tst_revolution_005

8 years agoFix for the issue #1196
mpv [Mon, 28 Dec 2015 13:43:56 +0000 (16:43 +0300)]
Fix for the issue #1196

8 years agoImp - Placement Name of field “Select a solid objects” should be renamed into “Selec...
nds [Mon, 28 Dec 2015 13:21:00 +0000 (16:21 +0300)]
Imp - Placement Name of field  “Select a solid objects” should be renamed into “Select objects to move”.  from

2015-11-30-Meeting-Minutes

8 years agoBug #1190: Height of extrusion is shown wrong in opened study
dbv [Mon, 28 Dec 2015 13:17:19 +0000 (16:17 +0300)]
Bug #1190: Height of extrusion is shown wrong in opened study

8 years agoShow tool tip of shape multi selector. Remove an article.
nds [Mon, 28 Dec 2015 13:14:11 +0000 (16:14 +0300)]
Show tool tip of shape multi selector. Remove an article.

8 years agoPoint should be initialized on start.
nds [Mon, 28 Dec 2015 12:17:46 +0000 (15:17 +0300)]
Point should be initialized on start.

8 years agoSpecial symbol for Angle/Radius. For consistency it sets the empty special symbol...
nds [Mon, 28 Dec 2015 11:53:06 +0000 (14:53 +0300)]
Special symbol for Angle/Radius. For consistency it sets the empty special symbol if a parameter is not used.

8 years agoSketch should stop contour in origin point if the contour is closed.
nds [Mon, 28 Dec 2015 11:01:25 +0000 (14:01 +0300)]
Sketch should stop contour in origin point if the contour is closed.

Scenario:
1. Start sketch creation in Origin
2. Create contour
3. Finish the contour in Origin.
The line creation operation should stop.

8 years agoSketch should stop contour in origin point if the contour is closed.
nds [Mon, 28 Dec 2015 10:58:01 +0000 (13:58 +0300)]
Sketch should stop contour in origin point if the contour is closed.

Scenario:
1. Start sketch creation in Origin
2. Create contour
3. Finish the contour in Origin.
The line creation operation should stop.

8 years agoMerge branch 'Dev_2.1.0' of salome:modules/shaper into Dev_2.1.0
mpv [Mon, 28 Dec 2015 09:44:48 +0000 (12:44 +0300)]
Merge branch 'Dev_2.1.0' of salome:modules/shaper into Dev_2.1.0

8 years agoStore the rotated values also into the GCS solver. Partial fix for the issue #1184
mpv [Mon, 28 Dec 2015 09:44:24 +0000 (12:44 +0300)]
Store the rotated values also into the GCS solver. Partial fix for the issue #1184

8 years ago#1112 tab key doesn't work on the last field of left panels
nds [Mon, 28 Dec 2015 09:37:44 +0000 (12:37 +0300)]
#1112 tab key doesn't work on the last field of left panels

8 years agoBug #1187: Partition Combine results check box
dbv [Mon, 28 Dec 2015 09:22:44 +0000 (12:22 +0300)]
Bug #1187: Partition Combine results check box

8 years agoRevert "Issue #1191 ExtrusionCut on compound works wrong: Temporary modification...
dbv [Mon, 28 Dec 2015 09:16:26 +0000 (12:16 +0300)]
Revert "Issue #1191 ExtrusionCut on compound works wrong: Temporary modification to provide possibility to perform the issue scenario. It should be validated and corrected. This is undo of 56393d00e7087f057b64198bfed1d95c0ad64850 integration."

This reverts commit 84edbb434d7d0e7b9502192301b16192e8ed606b.

8 years agoImprove make.sh
spo [Mon, 28 Dec 2015 09:28:59 +0000 (12:28 +0300)]
Improve make.sh

8 years agoImprove lcov scripts for Linux
spo [Mon, 28 Dec 2015 09:28:04 +0000 (12:28 +0300)]
Improve lcov scripts for Linux

8 years agoCrash in sketch on external objects use. Scenario:
nds [Mon, 28 Dec 2015 06:18:03 +0000 (09:18 +0300)]
Crash in sketch on external objects use. Scenario:

1. Create crossed controur in sketch
2. Create extrusion(CompSolid).
3. Create a controur with all points belong to external sketch lines.
Problem: 1.found compsolid was used instead of found external object
2. the second selection of external object should be checked by isExternal flag of the feature.

8 years ago#1188 - crash when delete segmnet used in rotation/translation
nds [Sat, 26 Dec 2015 18:36:14 +0000 (21:36 +0300)]
#1188 - crash when delete segmnet used in rotation/translation

8 years agoCrash in solver in the following case:
nds [Sat, 26 Dec 2015 18:16:36 +0000 (21:16 +0300)]
Crash in solver in the following case:

1. Start sketch
2. Create a line
3. Start Fixed constraint
4. Select a point on the line. Apply
5. Select the line by rectangle
6. Delete button click
BUG: crash

8 years agoIssue #1112 tab key doesn't work on the last field of left panels
nds [Sat, 26 Dec 2015 17:44:39 +0000 (20:44 +0300)]
Issue #1112 tab key doesn't work on the last field of left panels

It is improved for plane feature. Moreover, it provides the focus to Cancel button if Ok is disabled. This is implemented in order to property panel does not lose the focus.

8 years agoIssue #1191 ExtrusionCut on compound works wrong: Temporary modification to provide...
nds [Sat, 26 Dec 2015 16:56:41 +0000 (19:56 +0300)]
Issue #1191 ExtrusionCut on compound works wrong: Temporary modification to provide possibility to perform the issue scenario. It should be validated and corrected. This is undo of 56393d00e7087f057b64198bfed1d95c0ad64850 integration.

8 years ago#1189 Tab - Cancel - Enter validate not cancel: In case of disabled Apply button...
nds [Sat, 26 Dec 2015 16:54:01 +0000 (19:54 +0300)]
#1189 Tab - Cancel - Enter validate not cancel: In case of disabled Apply button, set focus to the Cancel

8 years ago#1189 Tab - Cancel - Enter validate not cancel
nds [Sat, 26 Dec 2015 16:47:21 +0000 (19:47 +0300)]
#1189 Tab - Cancel - Enter validate not cancel

8 years agoUpdate viewer on close just started sketcher
vsv [Sat, 26 Dec 2015 15:58:07 +0000 (18:58 +0300)]
Update viewer on close just started sketcher

8 years agoIssue #1194: Visibility of object browser under Salome has to be managed only in...
vsv [Sat, 26 Dec 2015 15:37:09 +0000 (18:37 +0300)]
Issue #1194: Visibility of object browser under Salome has to be managed only in NewGeom module

8 years agoIssue #1192: On closing of property panel close only current operation
vsv [Sat, 26 Dec 2015 13:44:04 +0000 (16:44 +0300)]
Issue #1192: On closing of property panel close only current operation

8 years agoIssue #1195: Fix of Show constraint toggle.
vsv [Sat, 26 Dec 2015 13:08:55 +0000 (16:08 +0300)]
Issue #1195: Fix of Show constraint toggle.

8 years agoFix for the issue #1179
mpv [Fri, 25 Dec 2015 18:16:49 +0000 (21:16 +0300)]
Fix for the issue #1179

8 years agoComposite feature adding subsolids. Fix problem with tag.
dbv [Fri, 25 Dec 2015 18:10:21 +0000 (21:10 +0300)]
Composite feature adding subsolids. Fix problem with tag.

8 years agoBug #1170: wrong object names in Main objects field Partition
dbv [Fri, 25 Dec 2015 16:55:56 +0000 (19:55 +0300)]
Bug #1170: wrong object names in Main objects field Partition

Additional fix

8 years ago#1182 point is attched to Sketch Constraint line
nds [Fri, 25 Dec 2015 16:10:28 +0000 (19:10 +0300)]
#1182  point is attched to Sketch Constraint line

8 years ago#1150 Tab buttons problems
nds [Fri, 25 Dec 2015 15:45:41 +0000 (18:45 +0300)]
#1150  Tab buttons problems

#1112 tab key doesn't work on the last field of left panels

We should not check visibility of internal widget: flyout point in dimention constraints.

8 years ago#1150 Tab buttons problems
nds [Fri, 25 Dec 2015 14:53:12 +0000 (17:53 +0300)]
#1150  Tab buttons problems

#1112 tab key doesn't work on the last field of left panels

8 years ago#1150 Tab buttons problems
nds [Fri, 25 Dec 2015 14:42:04 +0000 (17:42 +0300)]
#1150  Tab buttons problems

#1112 tab key doesn't work on the last field of left panels
Regression during the circle creation: the second restarted circle has no active control.

8 years ago#1150 Tab buttons problems
nds [Fri, 25 Dec 2015 14:25:42 +0000 (17:25 +0300)]
#1150  Tab buttons problems

#1112 tab key doesn't work on the last field of left panels
Regression during the circle creation: the second restarted circle has no active control.

8 years agoUpdate adjusting of the Angle constraint (issue #1181)
azv [Fri, 25 Dec 2015 14:24:56 +0000 (17:24 +0300)]
Update adjusting of the Angle constraint (issue #1181)

8 years agoBug #1180: impossible to select axis x as Line1 in angle constraint
dbv [Fri, 25 Dec 2015 14:07:18 +0000 (17:07 +0300)]
Bug #1180: impossible to select axis x as Line1 in angle constraint

8 years agoFix Squish tests spo/squish
spo [Fri, 25 Dec 2015 13:38:19 +0000 (16:38 +0300)]
Fix Squish tests

8 years agoFix regression in unit tests
azv [Fri, 25 Dec 2015 12:54:00 +0000 (15:54 +0300)]
Fix regression in unit tests

8 years ago#1150 Tab buttons problems
nds [Fri, 25 Dec 2015 12:37:58 +0000 (15:37 +0300)]
#1150  Tab buttons problems

#1112 tab key doesn't work on the last field of left panels
Sketch Multi-translation tab for start/end points selection, it should be on number of objects after the end point. Before it, the tab is moved to the start point because the same attribute is used inside it(isCase in activateNextWidget allows this widget)

8 years ago#1150 Tab buttons problems
nds [Fri, 25 Dec 2015 09:14:25 +0000 (12:14 +0300)]
#1150  Tab buttons problems

#1112 tab key doesn't work on the last field of left panels

8 years agoFix Squish object map
spo [Fri, 25 Dec 2015 12:31:38 +0000 (15:31 +0300)]
Fix Squish object map

8 years agoFix for issue #1049
azv [Fri, 25 Dec 2015 12:22:12 +0000 (15:22 +0300)]
Fix for issue #1049

8 years agoFix Squish object map
spo [Fri, 25 Dec 2015 12:19:10 +0000 (15:19 +0300)]
Fix Squish object map

8 years agoEliminate regression in "Multi" constraints (issue #1185)
azv [Fri, 25 Dec 2015 11:34:02 +0000 (14:34 +0300)]
Eliminate regression in "Multi" constraints (issue #1185)

8 years agoCrash fix
dbv [Fri, 25 Dec 2015 11:32:37 +0000 (14:32 +0300)]
Crash fix

8 years agoFix solver.sh
spo [Fri, 25 Dec 2015 10:44:36 +0000 (13:44 +0300)]
Fix solver.sh

8 years agoBug #1179: rotation after translation is wrong
dbv [Fri, 25 Dec 2015 09:17:51 +0000 (12:17 +0300)]
Bug #1179: rotation after translation is wrong

8 years agoCorrect processing parameters in "Multi" constraints
azv [Fri, 25 Dec 2015 09:11:38 +0000 (12:11 +0300)]
Correct processing parameters in "Multi" constraints

8 years agoAdd CMake flags DEFAULT_SOLVER, NO_SolveSpace & NO_PlaneGCS to switch solvers.
spo [Fri, 25 Dec 2015 08:56:03 +0000 (11:56 +0300)]
Add CMake flags DEFAULT_SOLVER, NO_SolveSpace & NO_PlaneGCS to switch solvers.

8 years agoUpdate Angle constraint processing (issue #1181)
azv [Fri, 25 Dec 2015 08:10:13 +0000 (11:10 +0300)]
Update Angle constraint processing (issue #1181)

8 years agoFix for the issue #1179, first part
mpv [Fri, 25 Dec 2015 07:32:57 +0000 (10:32 +0300)]
Fix for the issue #1179, first part

8 years agoIssue #1171 parameter value for dimension constarint - sigma sign is not shown in...
nds [Fri, 25 Dec 2015 07:26:28 +0000 (10:26 +0300)]
Issue #1171 parameter value for dimension constarint - sigma sign is not shown in viewer

If the problem is returned back, try to use Font_FontMgr::RegisterFont and has the font for the symbol in sources.
The problem is reproduced on Debian Linux station.

8 years agoIssue #1171 parameter value for dimension constarint - sigma sign is not shown in...
nds [Fri, 25 Dec 2015 07:24:36 +0000 (10:24 +0300)]
Issue #1171 parameter value for dimension constarint - sigma sign is not shown in viewer

If the problem is returned back, try to use Font_FontMgr::RegisterFont and has the font for the symbol in sources.

8 years agoBug #1170: wrong object names in Main objects field Partition
dbv [Fri, 25 Dec 2015 07:17:20 +0000 (10:17 +0300)]
Bug #1170: wrong object names in Main objects field Partition

8 years agoFix crash when walking out of array boundaries (issue #1178)
azv [Fri, 25 Dec 2015 07:15:17 +0000 (10:15 +0300)]
Fix crash when walking out of array boundaries (issue #1178)

8 years agoIssue #1177: improve removing coincidence of the fixed points
azv [Fri, 25 Dec 2015 05:28:30 +0000 (08:28 +0300)]
Issue #1177: improve removing coincidence of the fixed points

8 years agoFix for issue #1174
azv [Thu, 24 Dec 2015 15:24:36 +0000 (18:24 +0300)]
Fix for issue #1174

8 years agoCorrection tab logic.
nds [Thu, 24 Dec 2015 12:48:15 +0000 (15:48 +0300)]
Correction tab logic.

8 years agoCorrection tab logic.
nds [Wed, 23 Dec 2015 15:52:10 +0000 (18:52 +0300)]
Correction tab logic.

8 years agoCorrection tab logic.
nds [Wed, 23 Dec 2015 13:35:09 +0000 (16:35 +0300)]
Correction tab logic.

8 years agoIssue #1169 : support the width of the copied objects on undo/redo and delete
mpv [Thu, 24 Dec 2015 15:01:14 +0000 (18:01 +0300)]
Issue #1169 : support the width of the copied objects on undo/redo and delete

8 years agoImprovement #1140: Display of replicated Sketch entities with thinner line
dbv [Thu, 24 Dec 2015 14:34:23 +0000 (17:34 +0300)]
Improvement #1140: Display of replicated Sketch entities with thinner line
Line thickness now restored after constraint delete

8 years agoCOPY attribute in SketchEntity now persistent
dbv [Thu, 24 Dec 2015 14:04:49 +0000 (17:04 +0300)]
COPY attribute in SketchEntity now persistent

8 years agoIssue #1158: To use parameters in integer attributes -- GUI
spo [Thu, 24 Dec 2015 09:18:46 +0000 (12:18 +0300)]
Issue #1158: To use parameters in integer attributes -- GUI

8 years agoIssue #1158: To use parameters in integer attributes -- Data Model
spo [Wed, 23 Dec 2015 14:27:48 +0000 (17:27 +0300)]
Issue #1158: To use parameters in integer attributes -- Data Model

8 years agoIssue #1111 Sketch invisible
nds [Thu, 24 Dec 2015 12:28:33 +0000 (15:28 +0300)]
Issue #1111 Sketch invisible

It is not enough to create selector on initialize(). The problem still exists in the second study because it is not called there. So, it is decided to perform this in connectToStudy() of module.
An alternative is to do this in NewGEOM_DataModel before Mgr->load(). The problem is in this place because it causes redisplay signals flush. The viewer should be initialized before this case.

8 years agoIssue #1111 Sketch invisible
nds [Thu, 24 Dec 2015 12:26:43 +0000 (15:26 +0300)]
Issue #1111 Sketch invisible

It is not enough to create selector on initialize(). The problem still exists in the second study because it is not called there. So, it is decided to perform this in connectToStudy() of module.
An alternative is to do this in NewGEOM_DataModel before Mgr->load(). The problem is in this place because it causes redisplay signals flush. The viewer should be initialized before this case.