From: Gbkng <guillaume.brooking@gmail.com>
Date: Mon, 17 Jun 2024 22:23:01 +0000 (+0200)
Subject: clean cmake possibility to activate extra-warnings
X-Git-Url: http://git.salome-platform.org/gitweb/?a=commitdiff_plain;h=cc9086ff52475d105a139e7411d911cc6d011dd4;p=tools%2Fmedcoupling.git

clean cmake possibility to activate extra-warnings
---

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8d4e63c45..9e803239d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -52,30 +52,6 @@ MESSAGE(STATUS "Building ${PROJECT_NAME_UC} ${${PROJECT_NAME_UC}_VERSION} from \
 # ==============
 INCLUDE(SalomeSetupPlatform)
 
-# [ABN]: use the below for aggressive code quality check: 
-#if( EXISTS "aaaa")
-#    add_definitions(-Weverything)
-#    add_definitions(-Wno-inconsistent-missing-override)
-#    add_definitions(-Wno-c++98-compat -Wno-c++98-compat-pedantic)
-#    add_definitions(-Wsign-conversion)
-#    add_definitions(-Wno-switch-enum)
-#
-#    add_definitions(-Wno-documentation-unknown-command) # \image in Doxygen
-#    add_definitions(-Wno-gnu-statement-expression)      # assert(...)
-#
-#    add_definitions(-Wno-reserved-id-macro -Wno-padded -Wno-weak-vtables -Wdouble-promotion -Wno-comma -Wno-unused-parameter)
-#    add_definitions(-Wno-unreachable-code-break -Wno-old-style-cast -Wno-deprecated -Wno-double-promotion)
-#    add_definitions(-Wno-exit-time-destructors -Wno-global-constructors -Wno-missing-prototypes)
-#    add_definitions(-Wno-covered-switch-default -Wno-weak-template-vtables -Wno-undefined-func-template -Wno-used-but-marked-unused)
-#    add_definitions(-Wno-unreachable-code-return -Wno-missing-noreturn -Wno-unused-member-function -Wno-header-hygiene)
-#    add_definitions(-Wno-ignored-qualifiers) # because of MED-file 
-#    add_definitions(-Wno-unused-function -Wno-unused-macros)
-#    add_definitions(-Wno-missing-field-initializers)
-#    add_definitions(-Wno-shadow)  # SWIG generates a lot of those ...
-#
-#    add_definitions(-Wno-float-equal)  # OUCH
-#endif()
-
 #
 # User options
 # ============
@@ -91,6 +67,27 @@ OPTION(MEDCOUPLING_BUILD_PY_TESTS "Build MEDCoupling Python tests." ON)
 OPTION(MEDCOUPLING_BUILD_DOC "Build MEDCoupling doc." ON)
 OPTION(MEDCOUPLING_BUILD_STATIC "Build MEDCoupling library in static mode." OFF)
 OPTION(MEDCOUPLING_USE_64BIT_IDS "Size of IDs to refer cells and nodes. 32 bits when OFF (default), 64 bits when ON." ON)
+OPTION(MEDCOUPLING_EXTRA_BUILD_WARNINGS "Activate extra compiler warnings" OFF)
+
+if(MEDCOUPLING_EXTRA_BUILD_WARNINGS)
+   add_definitions(-Weverything)
+   add_definitions(-Wno-inconsistent-missing-override)
+   add_definitions(-Wno-c++98-compat -Wno-c++98-compat-pedantic)
+   add_definitions(-Wsign-conversion)
+   add_definitions(-Wno-switch-enum)
+   add_definitions(-Wno-documentation-unknown-command) # \image in Doxygen
+   add_definitions(-Wno-gnu-statement-expression)      # assert(...)
+   add_definitions(-Wno-reserved-id-macro -Wno-padded -Wno-weak-vtables -Wdouble-promotion -Wno-comma -Wno-unused-parameter)
+   add_definitions(-Wno-unreachable-code-break -Wno-old-style-cast -Wno-deprecated -Wno-double-promotion)
+   add_definitions(-Wno-exit-time-destructors -Wno-global-constructors -Wno-missing-prototypes)
+   add_definitions(-Wno-covered-switch-default -Wno-weak-template-vtables -Wno-undefined-func-template -Wno-used-but-marked-unused)
+   add_definitions(-Wno-unreachable-code-return -Wno-missing-noreturn -Wno-unused-member-function -Wno-header-hygiene)
+   add_definitions(-Wno-ignored-qualifiers) # because of MED-file 
+   add_definitions(-Wno-unused-function -Wno-unused-macros)
+   add_definitions(-Wno-missing-field-initializers)
+   add_definitions(-Wno-shadow)  # SWIG generates a lot of those ...
+   add_definitions(-Wno-float-equal)  # OUCH
+endif()
 
 IF(${MEDCOUPLING_USE_MPI})
   SET(USE_METIS_NOT_PARMETIS OFF)