From: Artem Zhidkov <Artem.Zhidkov@opencascade.com>
Date: Thu, 26 Mar 2020 07:00:48 +0000 (+0300)
Subject: Issue #18905: SIGSEGV when edit a sketch if a change sketch plane has been aborted... 
X-Git-Tag: V9_5_0a2~19
X-Git-Url: http://git.salome-platform.org/gitweb/?a=commitdiff_plain;h=6e7b39b6ae7c905f289c58b22ab572c4c25d5ff4;p=modules%2Fshaper.git

Issue #18905: SIGSEGV when edit a sketch if a change sketch plane has been aborted before
---

diff --git a/src/GeomData/GeomData_Dir.cpp b/src/GeomData/GeomData_Dir.cpp
index 23c7ce1c4..07ed1e0d6 100644
--- a/src/GeomData/GeomData_Dir.cpp
+++ b/src/GeomData/GeomData_Dir.cpp
@@ -82,3 +82,13 @@ void GeomData_Dir::reinit()
     myIsInitialized = true;
   }
 }
+
+bool GeomData_Dir::isInitialized()
+{
+  // Check once again the direction is initialized.
+  // Use case (bos #18905): draw a sketch, click "Change sketch plane", then abort it.
+  //                        myIsInitialized value is dropped to false, thus recheck.
+  if (!myIsInitialized)
+    myIsInitialized = myLab.FindAttribute(TDataStd_RealArray::GetID(), myCoords) == Standard_True;
+  return ModelAPI_Attribute::isInitialized();
+}
diff --git a/src/GeomData/GeomData_Dir.h b/src/GeomData/GeomData_Dir.h
index 1cc7f2ff9..bb4b52abb 100644
--- a/src/GeomData/GeomData_Dir.h
+++ b/src/GeomData/GeomData_Dir.h
@@ -54,6 +54,9 @@ class GeomData_Dir : public GeomDataAPI_Dir
   /// Returns the coordinates of this attribute
   GEOMDATA_EXPORT virtual std::shared_ptr<GeomAPI_XYZ> xyz();
 
+  /// Returns \c ture if the direction is initialized
+  GEOMDATA_EXPORT virtual bool isInitialized();
+
  protected:
   /// Initializes attributes
   GEOMDATA_EXPORT GeomData_Dir(TDF_Label& theLabel);
diff --git a/src/SketcherPrs/SketcherPrs_PositionMgr.cpp b/src/SketcherPrs/SketcherPrs_PositionMgr.cpp
index eb87e2884..81b5018b7 100644
--- a/src/SketcherPrs/SketcherPrs_PositionMgr.cpp
+++ b/src/SketcherPrs/SketcherPrs_PositionMgr.cpp
@@ -260,7 +260,8 @@ gp_Pnt SketcherPrs_PositionMgr::getPosition(ObjectPtr theShape,
 
   // Compute shifting vector for a one symbol
   gp_Vec aShift = aVec1.Crossed(thePrs->plane()->normal()->impl<gp_Dir>());
-  aShift.Normalize();
+  if (aShift.SquareMagnitude() > Precision::SquareConfusion())
+    aShift.Normalize();
   aShift.Multiply(theStep * 0.8);
 
   // Shift the position coordinate according to position index