Satisfy some PMD rules.

diff --git a/Workspace/Siman-Common/src/org/splat/service/StudyService.java b/Workspace/Siman-Common/src/org/splat/service/StudyService.java
index 507a5f3ff5244896b3d05df764685c8ee339dba7..73d498da2e2bd6d533e8015b91e0ef70049cfcc3 100644 (file)
--- a/Workspace/Siman-Common/src/org/splat/service/StudyService.java
+++ b/Workspace/Siman-Common/src/org/splat/service/StudyService.java
@@ -9,7 +9,6 @@
 
 package org.splat.service;
 
-import java.util.Date;
 import java.util.List;
 
 import org.splat.dal.bo.kernel.User;
@@ -63,7 +62,7 @@ public interface StudyService {
         * @param index
         *            the study id
         */
-       public void removeStudy(final Long index);
+       void removeStudy(final Long index);
 
        /**
         * Create a new study.

diff --git a/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java b/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java
index d7e6b900fe130d0fb998ec468fce2b091b9db7bb..d75d3ccfa29cd440919d9bd6ac10de208b6a8753 100644 (file)
--- a/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java
+++ b/Workspace/Siman-Common/src/org/splat/service/StudyServiceImpl.java
@@ -1361,7 +1361,7 @@ public class StudyServiceImpl implements StudyService {
        public List<UserDTO> getReaders(final long studyId) throws InvalidParameterException {
                Study aStudy = selectStudy(studyId);
                if(aStudy == null){
-                       throw new InvalidParameterException("studyId", String.valueOf(studyId));
+                       throw new InvalidParameterException(PARAM_STUDY_ID, String.valueOf(studyId));
                }
                List<Relation> relations = aStudy.getRelations(ReaderRelation.class);
                List<UserDTO> result = new ArrayList<UserDTO>();
@@ -1379,7 +1379,7 @@ public class StudyServiceImpl implements StudyService {
        public boolean addReader(final long studyId, final long userId) throws InvalidParameterException {
                Study aStudy = selectStudy(studyId);
                if(aStudy == null){
-                       throw new InvalidParameterException("studyId", String.valueOf(studyId));
+                       throw new InvalidParameterException(PARAM_STUDY_ID, String.valueOf(studyId));
                }
                User user = _userService.selectUser(userId);
                if(user == null){
@@ -1404,7 +1404,7 @@ public class StudyServiceImpl implements StudyService {
        public boolean removeReader(final long studyId, final long userId) throws InvalidParameterException {
                Study aStudy = selectStudy(studyId);
                if(aStudy == null){
-                       throw new InvalidParameterException("studyId", String.valueOf(studyId));
+                       throw new InvalidParameterException(PARAM_STUDY_ID, String.valueOf(studyId));
                }
                User user = _userService.selectUser(userId);
                if(user == null){