Code improvement: separate restore selection functionality in an additional method

diff --git a/src/ModuleBase/ModuleBase_WidgetMultiSelector.cpp b/src/ModuleBase/ModuleBase_WidgetMultiSelector.cpp
index 57c4d06dc7ac42e4b68bc6df28b8a2ab466b5a6d..312183b9e0a5cdb5ea304c76616dc6335a40d019 100644 (file)
--- a/src/ModuleBase/ModuleBase_WidgetMultiSelector.cpp
+++ b/src/ModuleBase/ModuleBase_WidgetMultiSelector.cpp
@@ -109,7 +109,7 @@ void ModuleBase_WidgetMultiSelector::activateCustom()
   activateShapeSelection(true);
 
   // Restore selection in the viewer by the attribute selection list
-  myWorkshop->setSelected(getCurrentSelection());
+  myWorkshop->setSelected(getAttributeSelection());
 
   activateFilters(myWorkshop, true);
 }
@@ -224,6 +224,7 @@ bool ModuleBase_WidgetMultiSelector::setSelection(const QList<ModuleBase_ViewerP
   }
   if (isDone) {
     updateObject(myFeature);
+    // this emit is necessary to call store/restore method an restore type of selection
     emit valuesChanged();
   }
   return isDone;
@@ -373,7 +374,7 @@ void ModuleBase_WidgetMultiSelector::activateShapeSelection(const bool isActivat
   }
 }
 
-QList<ModuleBase_ViewerPrs> ModuleBase_WidgetMultiSelector::getCurrentSelection() const
+QList<ModuleBase_ViewerPrs> ModuleBase_WidgetMultiSelector::getAttributeSelection() const
 {
   QList<ModuleBase_ViewerPrs> aSelected;
   // Restore selection in the viewer by the attribute selection list

diff --git a/src/ModuleBase/ModuleBase_WidgetMultiSelector.h b/src/ModuleBase/ModuleBase_WidgetMultiSelector.h
index fe665938f0db5525026eef61f0f9980406b98b17..033b260b4888c3912ea80ef46cb338fd3cee7407 100644 (file)
--- a/src/ModuleBase/ModuleBase_WidgetMultiSelector.h
+++ b/src/ModuleBase/ModuleBase_WidgetMultiSelector.h
@@ -125,7 +125,7 @@ protected slots:
   /// Return the attribute values wrapped in a list of viewer presentations
   /// \return a list of viewer presentations, which contains an attribute result and
   /// a shape. If the attribute do not uses the shape, it is empty
-  QList<ModuleBase_ViewerPrs> getCurrentSelection() const;
+  QList<ModuleBase_ViewerPrs> getAttributeSelection() const;
 
  protected:
    /// Update selection list

diff --git a/src/ModuleBase/ModuleBase_WidgetShapeSelector.cpp b/src/ModuleBase/ModuleBase_WidgetShapeSelector.cpp
index 9d80e0f79ef5250bab380d711dfe4a542fc54cbd..cea370ba22459d542c78437cc3e13f7c637347af 100644 (file)
--- a/src/ModuleBase/ModuleBase_WidgetShapeSelector.cpp
+++ b/src/ModuleBase/ModuleBase_WidgetShapeSelector.cpp
@@ -147,7 +147,7 @@ bool ModuleBase_WidgetShapeSelector::setObject(ObjectPtr theSelectedObject,
 }
 
 //********************************************************************
-QList<ModuleBase_ViewerPrs> ModuleBase_WidgetShapeSelector::getCurrentSelection() const
+QList<ModuleBase_ViewerPrs> ModuleBase_WidgetShapeSelector::getAttributeSelection() const
 {
   QList<ModuleBase_ViewerPrs> aSelected;
   if(myFeature) {
@@ -330,7 +330,7 @@ void ModuleBase_WidgetShapeSelector::activateCustom()
   activateSelection(true);
 
   // Restore selection in the viewer by the attribute selection list
-  myWorkshop->setSelected(getCurrentSelection());
+  myWorkshop->setSelected(getAttributeSelection());
 
   activateFilters(myWorkshop, true);
 }

diff --git a/src/ModuleBase/ModuleBase_WidgetShapeSelector.h b/src/ModuleBase/ModuleBase_WidgetShapeSelector.h
index 66d766d9fba3fac26adffedf9710ef07af23e72a..e21d756fd7751ffb54c52b3130e7b7590f66f7e4 100644 (file)
--- a/src/ModuleBase/ModuleBase_WidgetShapeSelector.h
+++ b/src/ModuleBase/ModuleBase_WidgetShapeSelector.h
@@ -139,7 +139,7 @@ Q_OBJECT
   /// Return the attribute values wrapped in a list of viewer presentations
   /// \return a list of viewer presentations, which contains an attribute result and
   /// a shape. If the attribute do not uses the shape, it is empty
-  QList<ModuleBase_ViewerPrs> getCurrentSelection() const;
+  QList<ModuleBase_ViewerPrs> getAttributeSelection() const;
 
   //----------- Class members -------------
   protected: