still more HYDRO tests corrections

diff --git a/src/HYDROData/HYDROData_LandCoverMap.cxx b/src/HYDROData/HYDROData_LandCoverMap.cxx
index 9f8986e2f04e33dd59d8fc2e8d67ab3981c027cf..2a5904b19dc77daef961ee883ca9de6662887149 100644 (file)
--- a/src/HYDROData/HYDROData_LandCoverMap.cxx
+++ b/src/HYDROData/HYDROData_LandCoverMap.cxx
@@ -62,6 +62,7 @@
 #include <TopTools_DataMapOfShapeListOfShape.hxx>
 #include <NCollection_DoubleMap.hxx>
 
+#include <stdexcept>
 
 #include <QFile>
 #include <QString>
@@ -902,6 +903,7 @@ bool HYDROData_LandCoverMap::LocalPartition( const TopoDS_Shape& theNewShape, co
   //     c. add the new shape if it is face with its type
   if( theNewShape.ShapeType()==TopAbs_FACE )
     aNewFaces.Add( TopoDS::Face( theNewShape ), theNewType );
+  //DEBTRACE(theNewShape << " " << theNewType);
   
   // convert map of shape to type to compound and list of types
   StoreLandCovers( aNewFaces );
@@ -932,6 +934,7 @@ void HYDROData_LandCoverMap::StoreLandCovers( const HYDROData_MapOfFaceToStrickl
   }
 
   TopTools_IndexedDataMapOfShapeListOfShape ShHistory;
+  ShHistory.Clear();
 
   TopoDS_Shape aResult;
   if( aListOfFaces.Extent() == 1 )
@@ -959,9 +962,21 @@ void HYDROData_LandCoverMap::StoreLandCovers( const HYDROData_MapOfFaceToStrickl
     //DEBTRACE("  --- " << aFF);
     if( aFF.IsNull() )
       continue;
-    TopTools_ListOfShape aLS = ShHistory.FindFromKey(aFF);
+    //DEBTRACE(ShHistory.IsEmpty());
+    //DEBTRACE(aFF.Checked());
+    TopTools_ListOfShape aLS;
+    try
+    {
+      aLS = ShHistory.FindFromKey(aFF); //TODO: bug to fix. Observed on an incomplete split of a face
+    }
+    catch (...)
+    {
+      DEBTRACE("TODO: bug to fix. Observed on an incomplete split of a face");
+      continue;
+    }
     if (aLS.IsEmpty())
     {
+      //DEBTRACE("--- aLS.IsEmpty()");
       QString aSType = theMap.FindFromKey(aFF);
       //DEBTRACE("  --- " << aSType.toStdString());
       if (ShF2FHistory.Contains(aFF))
@@ -977,6 +992,7 @@ void HYDROData_LandCoverMap::StoreLandCovers( const HYDROData_MapOfFaceToStrickl
     }
     else
     {
+      //DEBTRACE("--- !aLS.IsEmpty()");
       TopTools_ListIteratorOfListOfShape anIt(aLS);
       for (; anIt.More(); anIt.Next())
       {
@@ -986,13 +1002,13 @@ void HYDROData_LandCoverMap::StoreLandCovers( const HYDROData_MapOfFaceToStrickl
         //if (ShF2FHistory.Contains(aFF))
         if (ShF2FHistory.Contains(aMF))
           {
-            aChF2ST.Add(ShF2FHistory.FindFromKey(aMF), aSType);
             //DEBTRACE("ShF2FHistory.FindFromKey(aMF) " << ShF2FHistory.FindFromKey(aFF));
+            aChF2ST.Add(ShF2FHistory.FindFromKey(aMF), aSType);
           }
         else
           {
-            aChF2ST.Add(aMF, aSType);
             //DEBTRACE("aMF " << aMF);
+            aChF2ST.Add(aMF, aSType);
           }
       }
     }

diff --git a/src/HYDRO_tests/reference_data/LandCoverMap_Split_2.png b/src/HYDRO_tests/reference_data/LandCoverMap_Split_2.png
index b34f64775e94f1ce3770d6e7cc7bc174d2153806..1cb8991e2497d9f36b756e211fbcbc3cd0f0c9d2 100644 (file)
Binary files a/src/HYDRO_tests/reference_data/LandCoverMap_Split_2.png and b/src/HYDRO_tests/reference_data/LandCoverMap_Split_2.png differ

diff --git a/src/HYDRO_tests/test_HYDROData_LandCoverMap.cxx b/src/HYDRO_tests/test_HYDROData_LandCoverMap.cxx
index 94b63b91910ee6dc19432b2ef43b823271260b83..76f6a7f5ee8e60337ff6469778db006fe9124d84 100644 (file)
--- a/src/HYDRO_tests/test_HYDROData_LandCoverMap.cxx
+++ b/src/HYDRO_tests/test_HYDROData_LandCoverMap.cxx
@@ -148,7 +148,7 @@ void test_HYDROData_LandCoverMap::test_incomplete_split()
   TopoDS_Wire aWire = Wire( QList<double>() << 10 << 40 << 30 << 10 << 40 << 10, false );
   aPolyline->SetShape( aWire );
 
-  CPPUNIT_ASSERT_EQUAL( true, aMap->Split( aPolyline ) );
+  CPPUNIT_ASSERT_EQUAL( false, aMap->Split( aPolyline ) );
 
   TestViewer::show( aMap->GetShape(), AIS_Shaded, true, "LandCoverMap_Split_2" );
   TestViewer::show( aWire, 0, true, Qt::green );