PAL13117: Bug in RemoveObject method.

diff --git a/src/GEOMImpl/GEOMImpl_IGroupOperations.cxx b/src/GEOMImpl/GEOMImpl_IGroupOperations.cxx
index 3bc83464cbabe16013a88eeda44d21f794429617..7535fd4075aebd31a04b13f103301a064d33d577 100644 (file)
--- a/src/GEOMImpl/GEOMImpl_IGroupOperations.cxx
+++ b/src/GEOMImpl/GEOMImpl_IGroupOperations.cxx
@@ -196,20 +196,18 @@ void GEOMImpl_IGroupOperations::RemoveObject (Handle(GEOM_Object) theGroup, int
     else {
       aNewSeq = new TColStd_HArray1OfInteger(1, aLength-1);
       Standard_Boolean isFound = Standard_False;
-      for(Standard_Integer i = 1, k=1; i<=aLength; i++) {
-       if(i == aLength && !isFound) {
-         SetErrorCode(NOT_EXISTS);
-         return; 
-       }
-       if(aSeq->Value(i) == theSubShapeID) {
+      for (Standard_Integer i = 1, k = 1; i <= aLength; i++) {
+       if (aSeq->Value(i) == theSubShapeID) {
          isFound = Standard_True;
-         continue;
-       }
-       aNewSeq->SetValue(k, aSeq->Value(i));
-       k++;
+       } else {
+          if (k < aLength) { // this check is to avoid sequence <aNewSeq> overflow
+            aNewSeq->SetValue(k, aSeq->Value(i));
+            k++;
+          }
+        }
       }
 
-      if(!isFound) {
+      if (!isFound) {
        SetErrorCode(NOT_EXISTS);
        return; 
       }