Issue #19725: Error when loading python dump

Fix the issue related to the on-the-fly projection to sketch, when projecting a periodic B-spline curve orthogonal to the sketch plane.

diff --git a/src/GeomAPI/GeomAPI_BSpline2d.cpp b/src/GeomAPI/GeomAPI_BSpline2d.cpp
index 5835d9707d4a06a278429c48375e45382ab0f91f..a5bd94a16b38f853ccd561543c3acf0e5db717fe 100644 (file)
--- a/src/GeomAPI/GeomAPI_BSpline2d.cpp
+++ b/src/GeomAPI/GeomAPI_BSpline2d.cpp
@@ -48,8 +48,15 @@ static Handle_Geom2d_BSplineCurve* newBSpline2d(
     return newBSpline2d(thePoles, theWeights, theDegree, thePeriodic);
 
   int anAuxPole = 0;
-  if (thePeriodic && thePoles.front()->distance(thePoles.back()) < Precision::Confusion())
-    anAuxPole = -1;
+  if (thePeriodic && thePoles.front()->distance(thePoles.back()) < Precision::Confusion()) {
+    // additionally check the number of poles is greater than needed for th periodic B-spline
+    int aNbPoles = 0;
+    std::list<int>::const_iterator it = theMults.begin();
+    for (++it; it != theMults.end(); ++it)
+      aNbPoles += *it;
+    if ((int)thePoles.size() > aNbPoles)
+      anAuxPole = -1;
+  }
 
   // collect arrays of poles, weights, knots and multiplicities
   TColgp_Array1OfPnt2d aPoles(1, (int)thePoles.size() + anAuxPole);

diff --git a/src/PartSet/PartSet_Tools.cpp b/src/PartSet/PartSet_Tools.cpp
index fc615f4d1e00a6b55014ab567973208d652ac182..169ea993dd0f519ebb6e2172b9cb0134765eccc1 100644 (file)
--- a/src/PartSet/PartSet_Tools.cpp
+++ b/src/PartSet/PartSet_Tools.cpp
@@ -384,10 +384,13 @@ ResultPtr PartSet_Tools::createFixedObjectByExternal(
   anIntoResult->setValue(SKETCH_PROJECTION_INCLUDE_INTO_RESULT);
   aProjectionFeature->execute();
 
+  ModelAPI_ValidatorsFactory* aValidators = ModelAPI_Session::get()->validators();
+  bool isValid = aValidators->validate(aProjectionFeature);
+
   // if projection feature has not been created, exit
   AttributeRefAttrPtr aRefAttr = aProjectionFeature->data()->refattr(
     SketchPlugin_Projection::PROJECTED_FEATURE_ID());
-  if (!aRefAttr || !aRefAttr->isInitialized())
+  if (!isValid || !aRefAttr || !aRefAttr->isInitialized())
   {
     // remove external feature if the attribute is not filled
     std::set<FeaturePtr> aFeatures;

diff --git a/src/SketchPlugin/SketchPlugin_Validators.cpp b/src/SketchPlugin/SketchPlugin_Validators.cpp
index 9feba7df8772bba8cba3aa638643262b508a9bee..91b76d1b100d9cb7d569a196100141678386eb79 100644 (file)
--- a/src/SketchPlugin/SketchPlugin_Validators.cpp
+++ b/src/SketchPlugin/SketchPlugin_Validators.cpp
@@ -62,6 +62,7 @@
 #include <GeomAlgoAPI_EdgeBuilder.h>
 #include <GeomAlgoAPI_ShapeTools.h>
 
+#include <GeomAPI_BSpline.h>
 #include <GeomAPI_Circ.h>
 #include <GeomAPI_Dir2d.h>
 #include <GeomAPI_Ellipse.h>
@@ -1246,6 +1247,29 @@ bool SketchPlugin_ProjectionValidator::isValid(const AttributePtr& theAttribute,
       theError.arg(anEdge->isClosed() ? "Error: Ellipse is orthogonal to the sketch plane."
                                       : "Error: Elliptic Arc is orthogonal to the sketch plane.");
   }
+  else if (anEdge->isBSpline()) {
+    // check B-spline is periodic and planar
+    std::shared_ptr<GeomAPI_Curve> aCurve(new GeomAPI_Curve(anEdge));
+    std::shared_ptr<GeomAPI_BSpline> aBSpline(new GeomAPI_BSpline(aCurve));
+    if (aBSpline->isPeriodic()) {
+      GeomPlanePtr aPlane = GeomAlgoAPI_ShapeTools::findPlane(ListOfShape(1, anEdge));
+      std::shared_ptr<GeomAPI_Dir> aBSplineNormal = aPlane->direction();
+      double aDot = fabs(aNormal->dot(aBSplineNormal));
+      aValid = fabs(aDot - 1.0) <= tolerance * tolerance;
+      if (!aValid) {
+        // B-spline's plane is orthogonal to the sketch plane,
+        // thus, need to check whether B-spline is planar.
+        std::list<GeomPointPtr> aPoles = aBSpline->poles();
+        for (std::list<GeomPointPtr>::iterator it = aPoles.begin();
+             it != aPoles.end() && !aValid; ++it) {
+          if (aPlane->distance(*it) > tolerance)
+            aValid = true; // non-planar B-spline curve
+        }
+        if (!aValid)
+          theError = "Error: Periodic B-spline is orthogonal to the sketch plane.";
+      }
+    }
+  }
 
   return aValid;
 }

diff --git a/src/SketchPlugin/SketchPlugin_msg_en.ts b/src/SketchPlugin/SketchPlugin_msg_en.ts
index 5dd2eaa01fc945eaaaeb20aa1e60cb458fcaf672..b2271f3eaf956b761204531293791f1ab20571d8 100644 (file)
--- a/src/SketchPlugin/SketchPlugin_msg_en.ts
+++ b/src/SketchPlugin/SketchPlugin_msg_en.ts
@@ -2250,6 +2250,10 @@
       <source>Error: Elliptic Arc is orthogonal to the sketch plane.</source>
       <translation>Error: Elliptic Arc is orthogonal to the sketch plane.</translation>
     </message>
+    <message>
+      <source>Error: Periodic B-spline is orthogonal to the sketch plane.</source>
+      <translation>Error: Periodic B-spline is orthogonal to the sketch plane.</translation>
+    </message>
     <message>
       <source>Error: Selected object is not supported for projection.</source>
       <translation>Error: Selected object is not supported for projection.</translation>

diff --git a/src/SketchPlugin/SketchPlugin_msg_fr.ts b/src/SketchPlugin/SketchPlugin_msg_fr.ts
index 86f682282b786fc9a6225b2091549c988ea142b3..369a4050f432c4d39c458981f840a1b2f82fd2c3 100644 (file)
--- a/src/SketchPlugin/SketchPlugin_msg_fr.ts
+++ b/src/SketchPlugin/SketchPlugin_msg_fr.ts
@@ -2156,6 +2156,10 @@
       <source>Error: Elliptic Arc is orthogonal to the sketch plane.</source>
       <translation>Erreur: L&apos;arc d&apos;ellipse est orthogonal au plan d&apos;esquisse.</translation>
     </message>
+    <message>
+      <source>Error: Periodic B-spline is orthogonal to the sketch plane.</source>
+      <translation>Erreur: La B-spline périodique est orthogonale au plan d&apos;esquisse.</translation>
+    </message>
     <message>
       <source>Error: Selected object is not supported for projection.</source>
       <translation>Erreur: L&apos;objet sélectionné n&apos;est pas pris en charge pour la projection.</translation>