X-Git-Url: http://git.salome-platform.org/gitweb/?a=blobdiff_plain;f=src%2FModel%2FModel_Objects.cpp;h=320bc86becb0c57933dc60136aa6bc64205444ee;hb=fc72d43b677baa05ae7fd317346fd8b723b799ed;hp=152aaaeb84ee27a8c4211c1c3d3618dae7221f50;hpb=749e980caeebfe4d16441703b7028dbbb1f1d91a;p=modules%2Fshaper.git diff --git a/src/Model/Model_Objects.cpp b/src/Model/Model_Objects.cpp index 152aaaeb8..320bc86be 100644 --- a/src/Model/Model_Objects.cpp +++ b/src/Model/Model_Objects.cpp @@ -1,4 +1,4 @@ -// Copyright (C) 2014-2019 CEA/DEN, EDF R&D +// Copyright (C) 2014-2023 CEA/DEN, EDF R&D // // This library is free software; you can redistribute it and/or // modify it under the terms of the GNU Lesser General Public @@ -38,6 +38,8 @@ #include #include +#include + #include #include #include @@ -49,6 +51,10 @@ #include #include +// for TDF_Label map usage +static Standard_Integer HashCode(const TDF_Label& theLab, const Standard_Integer theUpper); +static Standard_Boolean IsEqual(const TDF_Label& theLab1, const TDF_Label& theLab2); + int kUNDEFINED_FEATURE_INDEX = -1; static const std::string& groupNameFoldering(const std::string& theGroupID, @@ -619,14 +625,11 @@ ObjectPtr Model_Objects::object(const std::string& theGroupID, return ObjectPtr(); createHistory(theGroupID); const std::string& aGroupID = groupNameFoldering(theGroupID, theAllowFolder); - const std::vector& aVec = myHistory[theGroupID]; - //if (aVec.size() <= theIndex) - // return aVec[aVec.size() - 1]; // too high index requested (to avoid crash in #2360) return aGroupID.empty() ? myHistory[theGroupID][theIndex] : myHistory[aGroupID][theIndex]; } std::shared_ptr Model_Objects::objectByName( - const std::string& theGroupID, const std::string& theName) + const std::string& theGroupID, const std::wstring& theName) { createHistory(theGroupID); if (theGroupID == ModelAPI_Feature::group()) { // searching among features (in history or not) @@ -730,22 +733,22 @@ TDF_Label Model_Objects::featuresLabel() const return myMain.FindChild(TAG_OBJECTS); } -static std::string composeName(const std::string& theFeatureKind, const int theIndex) +static std::wstring composeName(const std::string& theFeatureKind, const int theIndex) { std::stringstream aNameStream; aNameStream << theFeatureKind << "_" << theIndex; - return aNameStream.str(); + return Locale::Convert::toWString(aNameStream.str()); } void Model_Objects::setUniqueName(FeaturePtr theFeature) { if (!theFeature->data()->name().empty()) return; // not needed, name is already defined - std::string aName; // result + std::wstring aName; // result // first count all features of such kind to start with index = count + 1 int aNumObjects = -1; // this feature is already in this map NCollection_DataMap::Iterator aFIter(myFeatures); - std::set allNames; + std::set allNames; for (; aFIter.More(); aFIter.Next()) { if (aFIter.Value()->getKind() == theFeature->getKind()) aNumObjects++; @@ -766,7 +769,7 @@ void Model_Objects::setUniqueName(FolderPtr theFolder) return; // name is already defined int aNbFolders = myFolders.Size(); - std::string aName = composeName(ModelAPI_Folder::ID(), aNbFolders); + std::wstring aName = composeName(ModelAPI_Folder::ID(), aNbFolders); // check the uniqueness of the name NCollection_DataMap::Iterator anIt(myFolders); @@ -809,11 +812,11 @@ void Model_Objects::synchronizeFeatures( return; // after all updates, sends a message that groups of features were created or updated Events_Loop* aLoop = Events_Loop::loop(); - static Events_ID aDispEvent = aLoop->eventByName(EVENT_OBJECT_TO_REDISPLAY); - static Events_ID aCreateEvent = Events_Loop::eventByName(EVENT_OBJECT_CREATED); - static Events_ID anUpdateEvent = Events_Loop::eventByName(EVENT_OBJECT_UPDATED); + //static Events_ID aDispEvent = aLoop->eventByName(EVENT_OBJECT_TO_REDISPLAY); + static Events_ID aCreateEvent = aLoop->eventByName(EVENT_OBJECT_CREATED); + static Events_ID anUpdateEvent = aLoop->eventByName(EVENT_OBJECT_UPDATED); static Events_ID aRedispEvent = aLoop->eventByName(EVENT_OBJECT_TO_REDISPLAY); - static Events_ID aDeleteEvent = Events_Loop::eventByName(EVENT_OBJECT_DELETED); + static Events_ID aDeleteEvent = aLoop->eventByName(EVENT_OBJECT_DELETED); static Events_ID aToHideEvent = aLoop->eventByName(EVENT_OBJECT_TO_REDISPLAY); bool isActive = aLoop->activateFlushes(false); @@ -892,10 +895,8 @@ void Model_Objects::synchronizeFeatures( ModelAPI_Tools::allResults(aFeature, aResults); std::list::iterator aResIter = aResults.begin(); for(; aResIter != aResults.end(); aResIter++) { - std::list > anAttrs = - (*aResIter)->data()->attributes(""); - std::list >::iterator anAttr = anAttrs.begin(); - for(; anAttr != anAttrs.end(); anAttr++) + anAttrs = (*aResIter)->data()->attributes(""); + for(anAttr = anAttrs.begin(); anAttr != anAttrs.end(); anAttr++) (*anAttr)->reinit(); } } @@ -1188,8 +1189,8 @@ TDF_Label Model_Objects::resultLabel( bool Model_Objects::hasCustomName(DataPtr theFeatureData, ResultPtr theResult, - int theResultIndex, - std::string& theParentName) const + int /*theResultIndex*/, + std::wstring& theParentName) const { ResultBodyPtr aBodyRes = std::dynamic_pointer_cast(theFeatureData->owner()); if (aBodyRes) { @@ -1200,7 +1201,7 @@ bool Model_Objects::hasCustomName(DataPtr theFeatureData, // result of boolean operation 'Boolean_1' is a CompSolid which is renamed to 'MyBOOL', // however, sub-elements of 'MyBOOL' should be named 'Boolean_1_1', 'Boolean_1_2' etc.) if (std::dynamic_pointer_cast(aBodyRes->data())->label().Depth() == 6) { - std::ostringstream aDefaultName; + std::wostringstream aDefaultName; // compute default name of CompSolid (name of feature + index of CompSolid's result) int aBodyResultIndex = 0; const std::list& aResults = anOwner->results(); @@ -1217,7 +1218,7 @@ bool Model_Objects::hasCustomName(DataPtr theFeatureData, return false; } - std::pair aName = ModelAPI_Tools::getDefaultName(theResult); + std::pair aName = ModelAPI_Tools::getDefaultName(theResult); if (aName.second) theParentName = aName.first; return aName.second; @@ -1225,25 +1226,30 @@ bool Model_Objects::hasCustomName(DataPtr theFeatureData, void Model_Objects::storeResult(std::shared_ptr theFeatureData, std::shared_ptr theResult, - const int theResultIndex) + const int theResultIndex, + const std::wstring& theNameShape) { theResult->init(); theResult->setDoc(myDoc); initData(theResult, resultLabel(theFeatureData, theResultIndex), TAG_FEATURE_ARGUMENTS); if (theResult->data()->name().empty()) { // if was not initialized, generate event and set a name - std::string aNewName = theFeatureData->name(); + std::wstring aNewName = theFeatureData->name(); if (hasCustomName(theFeatureData, theResult, theResultIndex, aNewName)) { // if the name of result is user-defined, then, at first time, assign name of the result // by empty string to be sure that corresponding flag in the data model is set - theResult->data()->setName(""); + theResult->data()->setName(L""); } else { - std::stringstream aName; - aName << aNewName; - // if there are several results (issue #899: any number of result), - // add unique prefix starting from second - if (theResultIndex > 0 || theResult->groupName() == ModelAPI_ResultBody::group()) - aName << "_" << theResultIndex + 1; + std::wstringstream aName; + if ( theNameShape != L"" ){ + aName << theNameShape; + } else { + aName << aNewName; + // if there are several results (issue #899: any number of result), + // add unique prefix starting from second + if (theResultIndex > 0 || theResult->groupName() == ModelAPI_ResultBody::group()) + aName << "_" << theResultIndex + 1; + } aNewName = aName.str(); } theResult->data()->setName(aNewName); @@ -1268,7 +1274,9 @@ std::shared_ptr Model_Objects::createConstruction( } std::shared_ptr Model_Objects::createBody( - const std::shared_ptr& theFeatureData, const int theIndex) + const std::shared_ptr& theFeatureData, + const int theIndex, + const std::wstring& theNameShape) { TDF_Label aLab = resultLabel(theFeatureData, theIndex); TDataStd_Comment::Set(aLab, ModelAPI_ResultBody::group().c_str()); @@ -1279,7 +1287,7 @@ std::shared_ptr Model_Objects::createBody( } if (!aResult.get()) { aResult = std::shared_ptr(new Model_ResultBody); - storeResult(theFeatureData, aResult, theIndex); + storeResult(theFeatureData, aResult, theIndex, theNameShape); } return aResult; } @@ -1490,17 +1498,20 @@ std::shared_ptr Model_Objects::findFolder( if (theBelow) continue; - // if feature is in sub-component, skip it - FeaturePtr aCurFeature = feature(aCurLabel); - if (isSkippedFeature(aCurFeature)) - continue; - + // issue #18733: check for the last feature in folder before checking the sub-feature, + // because the folder may end by the feature which is + // neither a sub-feature nor a feature in history. if (!aLastFeatureInFolder.IsNull()) { if (IsEqual(aCurLabel, aLastFeatureInFolder)) aLastFeatureInFolder.Nullify(); // the last feature in the folder is achieved continue; } + // if feature is in sub-component, skip it + FeaturePtr aCurFeature = feature(aCurLabel); + if (isSkippedFeature(aCurFeature)) + continue; + const ObjectPtr& aFolderObj = folder(aCurLabel); if (aFolderObj.get()) { aFoundFolder = std::dynamic_pointer_cast(aFolderObj); @@ -1823,7 +1834,7 @@ std::string Model_Objects::featureResultGroup(FeaturePtr theFeature) if (aLabIter.More()) { TDF_Label anArgLab = aLabIter.Value(); Handle(TDataStd_Comment) aGroup; - if (aLabIter.Value().FindAttribute(TDataStd_Comment::GetID(), aGroup)) { + if (anArgLab.FindAttribute(TDataStd_Comment::GetID(), aGroup)) { return TCollection_AsciiString(aGroup->Get()).ToCString(); } } @@ -1882,20 +1893,24 @@ void Model_Objects::updateResults(FeaturePtr theFeature, std::set& t if (aGroup->Get() == ModelAPI_ResultBody::group().c_str()) { aNewBody = createBody(theFeature->data(), aResIndex); } else if (aGroup->Get() == ModelAPI_ResultPart::group().c_str()) { - if (aResIndex <= theFeature->results().size()) { // to avoid crash if previous execute + if (aResIndex <= (int)theFeature->results().size()) {// to avoid crash if previous execute // for index = 0 erases result std::shared_ptr aNewP = createPart(theFeature->data(), aResIndex); - theFeature->setResult(aNewP, aResIndex); - if (!aNewP->partDoc().get()) - // create the part result: it is better to restore the previous result if possible - theFeature->execute(); + if (!aNewP->data()->isDeleted()) { + theFeature->setResult(aNewP, aResIndex); + if (!aNewP->partDoc().get()) + // create the part result: it is better to restore the previous result if possible + theFeature->execute(); + } } } else if (aGroup->Get() == ModelAPI_ResultConstruction::group().c_str()) { ResultConstructionPtr aConstr = createConstruction(theFeature->data(), aResIndex); - if (!aConstr->updateShape()) - theFeature->execute(); // not stored shape in the data structure, execute to have it - else - theFeature->setResult(aConstr, aResIndex); // result is ready without execution + if (!aConstr->data()->isDeleted()) { + if (!aConstr->updateShape()) + theFeature->execute(); // not stored shape in the data structure, execute to have it + else + theFeature->setResult(aConstr, aResIndex); // result is ready without execution + } } else if (aGroup->Get() == ModelAPI_ResultGroup::group().c_str()) { aNewBody = createGroup(theFeature->data(), aResIndex); } else if (aGroup->Get() == ModelAPI_ResultField::group().c_str()) { @@ -1932,7 +1947,7 @@ void Model_Objects::updateResults(FeaturePtr theFeature, std::set& t } } -ResultPtr Model_Objects::findByName(const std::string theName) +ResultPtr Model_Objects::findByName(const std::wstring theName) { ResultPtr aResult; FeaturePtr aResFeature; // keep feature to return the latest one @@ -2024,6 +2039,8 @@ FeaturePtr Model_Objects::lastFeature() bool Model_Objects::isLater(FeaturePtr theLater, FeaturePtr theCurrent) const { + if (theLater->getKind() == "InternalSelectionInPartFeature") + return true; std::shared_ptr aLaterD = std::static_pointer_cast(theLater->data()); std::shared_ptr aCurrentD = std::static_pointer_cast(theCurrent->data()); if (aLaterD.get() && aLaterD->isValid() && aCurrentD.get() && aCurrentD->isValid()) { @@ -2098,7 +2115,6 @@ std::shared_ptr Model_Objects::internalFeature(const int theIn Standard_Integer HashCode(const TDF_Label& theLab, const Standard_Integer theUpper) { return TDF_LabelMapHasher::HashCode(theLab, theUpper); - } Standard_Boolean IsEqual(const TDF_Label& theLab1, const TDF_Label& theLab2) {