#include <Events_InfoMessage.h>
#include <ModelAPI_AttributeString.h>
#include <ModelAPI_Events.h>
+#include <SketchPlugin_ConstraintMirror.h>
#include <SketchPlugin_ConstraintRigid.h>
+#include <SketchPlugin_MultiRotation.h>
+#include <SketchPlugin_MultiTranslation.h>
static void sendMessage(const char* theMessageName)
: mySketch(theWorkplane),
myPrevResult(PlaneGCSSolver_Solver::STATUS_UNKNOWN),
myDOF(0),
- myIsEventsBlocked(false)
+ myIsEventsBlocked(false),
+ myMultiConstraintUpdateStack(0)
{
mySketchSolver = SolverPtr(new PlaneGCSSolver_Solver);
myStorage = StoragePtr(new PlaneGCSSolver_Storage(mySketchSolver));
}
else
myConstraints[theConstraint]->update();
+
+ // constraint is created/updated => reset stack of "multi" constraints updates
+ myMultiConstraintUpdateStack = 0;
return true;
}
bool SketchSolver_Group::moveFeature(FeaturePtr theFeature)
{
- if (myDOF == 0) {
+ bool isFeatureExists = (myStorage->entity(theFeature).get() != 0);
+ if (myDOF == 0 && isFeatureExists) {
// avoid moving elements of fully constrained sketch
myStorage->refresh();
return true;
}
// Create temporary Fixed constraint
- SolverConstraintPtr aConstraint = PlaneGCSSolver_Tools::createMovementConstraint(theFeature);
+ std::shared_ptr<SketchSolver_ConstraintFixed> aConstraint =
+ PlaneGCSSolver_Tools::createMovementConstraint(theFeature);
if (!aConstraint)
return false;
- aConstraint->process(myStorage, myIsEventsBlocked);
- if (aConstraint->error().empty())
+ SolverConstraintPtr(aConstraint)->process(myStorage, myIsEventsBlocked);
+ if (aConstraint->error().empty()) {
setTemporary(aConstraint);
- else
+ if (!myStorage->isEmpty())
+ myStorage->setNeedToResolve(true);
+
+ mySketchSolver->initialize();
+ aConstraint->moveFeature();
+ } else
myStorage->notify(theFeature);
return true;
// ============================================================================
bool SketchSolver_Group::resolveConstraints()
{
+ static const int MAX_STACK_SIZE = 5;
+ // check the "Multi" constraints do not drop sketch into infinite loop
+ if (myMultiConstraintUpdateStack > MAX_STACK_SIZE) {
+ myMultiConstraintUpdateStack = 0;
+ myPrevResult = PlaneGCSSolver_Solver::STATUS_FAILED;
+ // generate error message due to loop update of the sketch
+ getWorkplane()->string(SketchPlugin_Sketch::SOLVER_ERROR())
+ ->setValue(SketchSolver_Error::INFINITE_LOOP());
+ sendMessage(EVENT_SOLVER_FAILED, myConflictingConstraints);
+ return false;
+ }
+
bool aResolved = false;
bool isGroupEmpty = isEmpty() && myStorage->isEmpty();
if (myStorage->isNeedToResolve() &&
try {
if (!isGroupEmpty)
aResult = mySketchSolver->solve();
+ if (aResult == PlaneGCSSolver_Solver::STATUS_FAILED &&
+ !myTempConstraints.empty()) {
+ mySketchSolver->undo();
+ removeTemporaryConstraints();
+ aResult = mySketchSolver->solve();
+ }
} catch (...) {
getWorkplane()->string(SketchPlugin_Sketch::SOLVER_ERROR())
->setValue(SketchSolver_Error::SOLVESPACE_CRASH());
aResult == PlaneGCSSolver_Solver::STATUS_EMPTYSET) {
myStorage->setNeedToResolve(false);
myStorage->refresh();
-//// updateMultiConstraints(myConstraints);
-//// // multi-constraints updated some parameters, need to store them
-//// if (myStorage->isNeedToResolve())
-//// resolveConstraints();
- if (myPrevResult != PlaneGCSSolver_Solver::STATUS_OK ||
- myPrevResult == PlaneGCSSolver_Solver::STATUS_UNKNOWN) {
- getWorkplane()->string(SketchPlugin_Sketch::SOLVER_ERROR())->setValue("");
- std::set<ObjectPtr> aConflicting = myConflictingConstraints;
- myConflictingConstraints.clear();
- myPrevResult = PlaneGCSSolver_Solver::STATUS_OK;
- // the error message should be changed before sending the message
- sendMessage(EVENT_SOLVER_REPAIRED, aConflicting);
+ // additional check that copied entities used in Mirror and other "Multi" constraints
+ // is not connected with their originals by constraints.
+ myMultiConstraintUpdateStack += 1;
+ aResolved = true;
+ if (myStorage->isNeedToResolve())
+ aResolved = resolveConstraints();
+
+ if (aResolved) {
+ myMultiConstraintUpdateStack -= 1;
+
+ if (myPrevResult != PlaneGCSSolver_Solver::STATUS_OK ||
+ myPrevResult == PlaneGCSSolver_Solver::STATUS_UNKNOWN) {
+ getWorkplane()->string(SketchPlugin_Sketch::SOLVER_ERROR())->setValue("");
+ std::set<ObjectPtr> aConflicting = myConflictingConstraints;
+ myConflictingConstraints.clear();
+ myPrevResult = PlaneGCSSolver_Solver::STATUS_OK;
+ // the error message should be changed before sending the message
+ sendMessage(EVENT_SOLVER_REPAIRED, aConflicting);
+ }
}
// show degrees of freedom
}
}
- aResolved = true;
- } else if (!isGroupEmpty) {
- // Check if the group contains only constraints Fixed, update parameters by stored values
- aResolved = true;
- ConstraintConstraintMap::iterator aCIt = myConstraints.begin();
- for (; aCIt != myConstraints.end(); ++aCIt)
- if (aCIt->first->getKind() != SketchPlugin_ConstraintRigid::ID()) {
- aResolved = false;
- break;
- }
- if (aCIt == myConstraints.end())
- myStorage->refresh();
} else if (isGroupEmpty && isWorkplaneValid())
computeDoF();
removeTemporaryConstraints();
{
std::ostringstream aDoFMsg;
int aDoF = mySketchSolver->dof();
+ /// "DoF = 0" content of string value is used in PartSet by Sketch edit
+ /// If it is changed, it should be corrected also there
if (aDoF == 0)
aDoFMsg << "Sketch is fully fixed (DoF = 0)";
else
// ============================================================================
void SketchSolver_Group::repairConsistency()
{
- if (!myStorage->isConsistent()) {
+ if (!areConstraintsValid() || !myStorage->areFeaturesValid()) {
// remove invalid constraints
std::set<ConstraintPtr> anInvalidConstraints;
ConstraintConstraintMap::iterator aCIter = myConstraints.begin();
for (; aCIter != myConstraints.end(); aCIter++)
if (aCIter->first == theConstraint) {
aCIter->second->remove(); // the constraint is not fully removed
+
+ // constraint is removed => reset stack of "multi" constraints updates
+ myMultiConstraintUpdateStack = 0;
break;
}
if (aCIter != myConstraints.end())
myIsEventsBlocked = isBlocked;
}
+
+bool SketchSolver_Group::areConstraintsValid() const
+{
+ // Check the constraints are valid
+ ConstraintConstraintMap::const_iterator aCIter = myConstraints.begin();
+ for (; aCIter != myConstraints.end(); ++aCIter)
+ if (!aCIter->first->data() || !aCIter->first->data()->isValid())
+ return false;
+ return true;
+}
