anIt = theRefsList.cbegin(); anIt != theRefsList.cend(); ++anIt) {
std::shared_ptr<ModelAPI_Attribute> aAttr = (*anIt);
FeaturePtr aFeature = std::dynamic_pointer_cast<ModelAPI_Feature>(aAttr->owner());
+ if (!aFeature)
+ continue;
if (aFeature->getKind() == SketchPlugin_ConstraintTangent::ID()) {
AttributeRefAttrPtr anAttrRefA = std::dynamic_pointer_cast<ModelAPI_AttributeRefAttr>(
aFeature->attribute(SketchPlugin_ConstraintTangent::ENTITY_A()));
theError.arg(theAttribute->attributeType());
return false;
}
- AttributeSelectionPtr aLineAttr =
- std::dynamic_pointer_cast<ModelAPI_AttributeSelection>(theAttribute);
+ AttributeSelectionPtr anExternalAttr =
+ std::dynamic_pointer_cast<ModelAPI_AttributeSelection>(theAttribute);
std::shared_ptr<GeomAPI_Edge> anEdge;
- if(aLineAttr && aLineAttr->value() && aLineAttr->value()->isEdge()) {
- anEdge = std::shared_ptr<GeomAPI_Edge>(new GeomAPI_Edge(aLineAttr->value()));
- } else if(aLineAttr->context() &&
- aLineAttr->context()->shape() && aLineAttr->context()->shape()->isEdge()) {
- anEdge = std::shared_ptr<GeomAPI_Edge>(new GeomAPI_Edge(aLineAttr->context()->shape()));
+ if (anExternalAttr && anExternalAttr->value() && anExternalAttr->value()->isEdge()) {
+ anEdge = std::shared_ptr<GeomAPI_Edge>(new GeomAPI_Edge(anExternalAttr->value()));
+ } else if(anExternalAttr->context() && anExternalAttr->context()->shape() &&
+ anExternalAttr->context()->shape()->isEdge()) {
+ anEdge = std::shared_ptr<GeomAPI_Edge>(new GeomAPI_Edge(anExternalAttr->context()->shape()));
}
- if (!anEdge || !anEdge->isLine()) {
- theError = "The attribute %1 should be a line";
+ if (!anEdge) {
+ theError = "The attribute %1 should be an edge";
theError.arg(theAttribute->id());
return false;
}
- std::shared_ptr<GeomAPI_Dir> aLineDir = anEdge->line()->direction();
-
// find a sketch
std::shared_ptr<SketchPlugin_Sketch> aSketch;
- std::set<AttributePtr> aRefs = aLineAttr->owner()->data()->refsToMe();
+ std::set<AttributePtr> aRefs = anExternalAttr->owner()->data()->refsToMe();
std::set<AttributePtr>::const_iterator anIt = aRefs.begin();
for (; anIt != aRefs.end(); ++anIt) {
CompositeFeaturePtr aComp =
return false;
}
+ // check the edge is intersected with sketch plane
std::shared_ptr<GeomAPI_Pln> aPlane = aSketch->plane();
- std::shared_ptr<GeomAPI_Dir> aNormal = aPlane->direction();
- return fabs(aNormal->dot(aLineDir)) > tolerance * tolerance;
+
+ std::list<GeomPointPtr> anIntersectionsPoints;
+ anEdge->intersectWithPlane(aPlane, anIntersectionsPoints);
+ if (anIntersectionsPoints.empty()) {
+ theError = "The edge is not intersected with sketch plane";
+ return false;
+ }
+ return true;
}
bool SketchPlugin_SplitValidator::isValid(const AttributePtr& theAttribute,