-// Copyright (C) 2014-2019 CEA/DEN, EDF R&D
+// Copyright (C) 2014-2020 CEA/DEN, EDF R&D
//
// This library is free software; you can redistribute it and/or
// modify it under the terms of the GNU Lesser General Public
Selector_Modify::Selector_Modify() : Selector_Algo()
{
myWeakIndex = -1; // no index by default
+ myRecomputeWeakIndex = false;
}
// adds to theResult all labels that contain initial shapes for theValue located in theFinal
TDF_Label Selector_Modify::restoreByName(std::wstring theName,
const TopAbs_ShapeEnum theShapeType, Selector_NameGenerator* theNameGenerator)
{
+ typedef NCollection_DataMap<TopoDS_Shape, bool, TopTools_ShapeMapHasher> MapOfCompsolids;
+ MapOfCompsolids aWrongSubsCompsolids;
+
TDF_Label aContext;
- for(size_t anEnd, aStart = 0; aStart != std::string::npos; aStart = anEnd) {
+ for(size_t anEnd, aStart = 0; aStart != std::wstring::npos; aStart = anEnd) {
if (aStart != 0)
aStart++;
- anEnd = theName.find('&', aStart);
+ anEnd = theName.find(L'&', aStart);
std::wstring aSubStr =
- theName.substr(aStart, anEnd == std::string::npos ? anEnd : anEnd - aStart);
- if (aSubStr.find(weakNameID()) == 0) { // weak name identifier
- std::wstring aWeakIndex = aSubStr.substr(weakNameID().size());
- myWeakIndex = std::stoi(aWeakIndex.c_str());
+ theName.substr(aStart, anEnd == std::wstring::npos ? anEnd : anEnd - aStart);
+ size_t aFoundOldWeak = aSubStr.find(oldWeakNameID());
+ size_t aFoundNewWeak = aFoundOldWeak != std::wstring::npos ?
+ aSubStr.find(weakNameID()) :
+ aFoundOldWeak;
+ if (aFoundOldWeak == 0 || aFoundNewWeak == 0) { // weak name identifier
+ std::wstring aWeakIndex = aSubStr.substr(aFoundOldWeak + oldWeakNameID().size());
+ myWeakIndex = atoi(Locale::Convert::toString(aWeakIndex).c_str());
+ myRecomputeWeakIndex = aFoundOldWeak == 0;
continue;
}
TDF_Label aSubContext, aValue;
if (!theNameGenerator->restoreContext(aSubStr, aSubContext, aValue))
return TDF_Label(); // can not restore
- if(aSubContext.IsNull() || aValue.IsNull())
+ if (aSubContext.IsNull() || (aValue.IsNull() && theShapeType <= TopAbs_SHELL))
return TDF_Label(); // can not restore
if (myFinal.IsNull()) {
myFinal = aValue;
aContext = aSubContext;
- } else
- myBases.Append(aValue);
+ } else {
+ // This could be a solid in a compsolid, which was not modified by the previous operation,
+ // however, the selected subshape is stored on its sub-label by mistake. Thus, wait until
+ // the end of processing to check whether the subshape is found in another solid.
+ TDF_Label aParent = aSubContext.Father().Father();
+ Handle(TNaming_NamedShape) aNS;
+ if (aParent.FindAttribute(TNaming_NamedShape::GetID(), aNS)) {
+ TopoDS_Shape aShape = aNS->Get();
+ if (aShape.ShapeType() == TopAbs_COMPSOLID) {
+ if (aWrongSubsCompsolids.IsBound(aShape)) {
+ if (!aValue.IsNull())
+ aWrongSubsCompsolids.Bind(aShape, true);
+ } else
+ aWrongSubsCompsolids.Bind(aShape, !aValue.IsNull());
+ }
+ } else if (aValue.IsNull())
+ return TDF_Label();
+
+ if (!aValue.IsNull())
+ myBases.Append(aValue);
+ }
}
+
+ // check all compsolids are processed and names are resolved
+ for (MapOfCompsolids::Iterator anIt(aWrongSubsCompsolids); anIt.More(); anIt.Next())
+ if (!anIt.Value())
+ return TDF_Label();
+
return aContext;
}
aCommon.Append(aNewShape);
}
}
- Selector_NExplode aNexp(aCommon);
+ Selector_NExplode aNexp(aCommon, myRecomputeWeakIndex);
aResult = aNexp.shape(myWeakIndex);
+ myRecomputeWeakIndex = false;
} else { // standard case
TopoDS_ListOfShape aFinalsCommon; // final shapes presented in all results from bases
findModificationResult(aFinalsCommon);
aResult = aFinalsCommon.First();
findNewVersion(theContext, aResult);
} else if (aFinalsCommon.Extent() > 1 && myWeakIndex > 0) {
- Selector_NExplode aNExp(aFinalsCommon);
+ Selector_NExplode aNExp(aFinalsCommon, myRecomputeWeakIndex);
aResult = aNExp.shape(myWeakIndex);
+ myRecomputeWeakIndex = false;
findNewVersion(theContext, aResult);
} else if (aFinalsCommon.Extent() > 1 && geometricalNaming()) {// if same geometry - compound
TopoDS_ListOfShape::Iterator aCommonIter(aFinalsCommon);