Providing Action class to have a common approach to start/finish/abort model transact...

[modules/shaper.git] / src / ParametersPlugin / ParametersPlugin_Parameter.cpp

diff --git a/src/ParametersPlugin/ParametersPlugin_Parameter.cpp b/src/ParametersPlugin/ParametersPlugin_Parameter.cpp
index 58280994c84c8f539cb36813329816f454046332..54dc39581185a6892ddb35ce04310de7b19e044e 100644 (file)
--- a/src/ParametersPlugin/ParametersPlugin_Parameter.cpp
+++ b/src/ParametersPlugin/ParametersPlugin_Parameter.cpp
@@ -4,6 +4,8 @@
 // Created:     23 MArch 2015
 // Author:      sbh
 
+#include <pyconfig.h>
+
 #include "ParametersPlugin_Parameter.h"
 #include <ParametersPlugin_PyInterp.h>
 
@@ -33,6 +35,7 @@ void ParametersPlugin_Parameter::initAttributes()
   data()->addAttribute(VARIABLE_ID(), ModelAPI_AttributeString::typeId());
   data()->addAttribute(EXPRESSION_ID(), ModelAPI_AttributeString::typeId());
   data()->addAttribute(ARGUMENTS_ID(), ModelAPI_AttributeRefList::typeId());
+  data()->reflist(ARGUMENTS_ID())->setIsArgument(false);
   ModelAPI_Session::get()->validators()->registerNotObligatory(getKind(), ARGUMENTS_ID());
 }
 
@@ -43,50 +46,58 @@ bool ParametersPlugin_Parameter::isInHistory()
 
 void ParametersPlugin_Parameter::attributeChanged(const std::string& theID)
 {
-  if (theID == EXPRESSION_ID()) { // recompute only on change of the expression
-    ResultParameterPtr aParam = document()->createParameter(data());
-
-    std::string anExpression = string(EXPRESSION_ID())->value();
-    if(anExpression.empty()) {
-      // clear error/result if the expression is empty
-      setError("", false);
-      return;
-    }
-    std::string outErrorMessage;
-    double aValue = evaluate(anExpression, outErrorMessage);
-    // Name
-    std::string aName = string(VARIABLE_ID())->value();
-    std::ostringstream sstream;
-    sstream << aValue;
-    std::string aParamValue = sstream.str();
-    data()->setName(aName);
-    aParam->data()->setName(aName);
-    // Error
-    if (!outErrorMessage.empty()) {
-      std::string aStateMsg("Error: " + outErrorMessage);
-      data()->execState(ModelAPI_StateExecFailed);
-      setError(aStateMsg, false);
-    } else {
-      static const std::string anEmptyMsg(""); // it is checked in the validator by the empty message
-      setError(anEmptyMsg, false);
-      data()->execState(ModelAPI_StateDone);
-    }
-    // Value
-    AttributeDoublePtr aValueAttribute = aParam->data()->real(ModelAPI_ResultParameter::VALUE());
-    aValueAttribute->setValue(aValue);
-    setResult(aParam);
+  if (theID == EXPRESSION_ID())
+    updateExpression();
+}
+
+void ParametersPlugin_Parameter::updateName()
+{
+  std::string aName = string(VARIABLE_ID())->value();
+  data()->setName(aName);
+
+  ResultParameterPtr aParam = document()->createParameter(data());
+  aParam->data()->setName(aName);
+  setResult(aParam);
+}
+
+void ParametersPlugin_Parameter::updateExpression()
+{
+  std::string anExpression = string(EXPRESSION_ID())->value();
+  if(anExpression.empty()) {
+    // clear error/result if the expression is empty
+    setError("", false);
+    return;
+  }
+  std::string outErrorMessage;
+  double aValue = evaluate(anExpression, outErrorMessage);
+  std::ostringstream sstream;
+  sstream << aValue;
+  std::string aParamValue = sstream.str();
+  // Error
+  if (!outErrorMessage.empty()) {
+    std::string aStateMsg("Error: " + outErrorMessage);
+    data()->execState(ModelAPI_StateExecFailed);
+    setError(aStateMsg, false);
+  } else {
+    static const std::string anEmptyMsg(""); // it is checked in the validator by the empty message
+    setError(anEmptyMsg, false);
+    data()->execState(ModelAPI_StateDone);
   }
+
+  ResultParameterPtr aParam = document()->createParameter(data());
+  AttributeDoublePtr aValueAttribute = aParam->data()->real(ModelAPI_ResultParameter::VALUE());
+  aValueAttribute->setValue(aValue);
+  setResult(aParam);
 }
 
 void ParametersPlugin_Parameter::execute()
 {
-  // just call recompute
-  attributeChanged(EXPRESSION_ID());
+  updateName();
+  updateExpression();
 }
 
 double ParametersPlugin_Parameter::evaluate(const std::string& theExpression, std::string& theError)
 {
-
   std::list<std::string> anExprParams = myInterp->compile(theExpression);
   // find expression's params in the model
   std::list<std::string> aContext;
@@ -95,7 +106,7 @@ double ParametersPlugin_Parameter::evaluate(const std::string& theExpression, st
   for ( ; it != anExprParams.end(); it++) {
     double aValue;
     ResultParameterPtr aParamRes;
-    if (!ModelAPI_Tools::findVariable(*it, aValue, aParamRes)) continue;
+    if (!ModelAPI_Tools::findVariable(*it, aValue, aParamRes, document())) continue;
     aParamsList.push_back(aParamRes);
 
     std::ostringstream sstream;