using namespace std;
Model_Update MY_UPDATER_INSTANCE; /// the only one instance initialized on load of the library
+//#define DEB_UPDATE
Model_Update::Model_Update()
{
Events_Loop* aLoop = Events_Loop::loop();
static const Events_ID kChangedEvent = aLoop->eventByName("PreferenceChanged");
aLoop->registerListener(this, kChangedEvent);
- static const Events_ID kRebuildEvent = aLoop->eventByName("Rebuild");
- aLoop->registerListener(this, kRebuildEvent);
static const Events_ID kCreatedEvent = Events_Loop::loop()->eventByName(EVENT_OBJECT_CREATED);
aLoop->registerListener(this, kCreatedEvent);
static const Events_ID kUpdatedEvent = Events_Loop::loop()->eventByName(EVENT_OBJECT_UPDATED);
aLoop->registerListener(this, kUpdatedEvent);
- static const Events_ID kMovedEvent = Events_Loop::loop()->eventByName(EVENT_OBJECT_MOVED);
- aLoop->registerListener(this, kMovedEvent);
static const Events_ID kOpFinishEvent = aLoop->eventByName("FinishOperation");
aLoop->registerListener(this, kOpFinishEvent);
static const Events_ID kOpAbortEvent = aLoop->eventByName("AbortOperation");
aLoop->registerListener(this, kOpAbortEvent);
static const Events_ID kOpStartEvent = aLoop->eventByName("StartOperation");
aLoop->registerListener(this, kOpStartEvent);
+ static const Events_ID kStabilityEvent = aLoop->eventByName(EVENT_STABILITY_CHANGED);
+ aLoop->registerListener(this, kStabilityEvent);
- Config_PropManager::registerProp("Model update", "automatic_rebuild", "Rebuild immediately",
- Config_Prop::Boolean, "false");
- myIsAutomatic =
- Config_PropManager::findProp("Model update", "automatic_rebuild")->value() == "true";
+ // Config_PropManager::findProp("Model update", "automatic_rebuild")->value() == "true";
+ myIsParamUpdated = false;
+ myIsFinish = false;
+ myIsProcessed = false;
+}
+
+void Model_Update::addModified(FeaturePtr theFeature, FeaturePtr theReason) {
+ if (!theFeature->isPreviewNeeded() && !myIsFinish) {
+ myProcessOnFinish.insert(theFeature);
+ return;
+ }
+ if (myModified.find(theFeature) != myModified.end()) {
+ if (theReason.get()) {
+#ifdef DEB_UPDATE
+ std::cout<<"*** Add already modified "<<theFeature->name()<<std::endl;
+#endif
+ myModified[theFeature].insert(theReason);
+ }
+ return; // already is marked as modified, so, nothing to do, it will be processed
+ }
+ // do not add the disabled, but possibly the sub-elements are not disabled
+ bool aIsDisabled = theFeature->isDisabled();
+ if (!aIsDisabled) {
+ std::set<std::shared_ptr<ModelAPI_Feature> > aNewSet;
+ if (theFeature->data()->execState() == ModelAPI_StateMustBeUpdated) {
+ // do not forget that in this case all were the reasons
+ aNewSet.insert(theFeature);
+ } else {
+ if (theReason.get())
+ aNewSet.insert(theReason);
+ }
+ myModified[theFeature] = aNewSet;
+#ifdef DEB_UPDATE
+ std::cout<<"*** Add modified "<<theFeature->name()<<std::endl;
+#endif
+ } else { // will be updated during the finish of the operation, or when it becomes enabled
+ if (theFeature->data()->execState() == ModelAPI_StateDone)
+ theFeature->data()->execState(ModelAPI_StateMustBeUpdated);
+ else
+ return; // do not need iteration deeply if it is already marked as modified or so
+#ifdef DEB_UPDATE
+ std::cout<<"*** Set modified state "<<theFeature->name()<<std::endl;
+#endif
+ }
+ // clear processed and fill modified recursively
+ const std::set<std::shared_ptr<ModelAPI_Attribute> >& aRefs = theFeature->data()->refsToMe();
+ std::set<std::shared_ptr<ModelAPI_Attribute> >::const_iterator aRefIter = aRefs.cbegin();
+ for(; aRefIter != aRefs.cend(); aRefIter++) {
+ FeaturePtr aReferenced = std::dynamic_pointer_cast<ModelAPI_Feature>((*aRefIter)->owner());
+ if (aReferenced.get()) {
+ addModified(aReferenced, theFeature);
+ }
+ }
+ // proccess also results
+ std::list<ResultPtr> allResults; // list of this feature and results
+ ModelAPI_Tools::allResults(theFeature, allResults);
+ std::list<ResultPtr>::iterator aRes = allResults.begin();
+ for(; aRes != allResults.end(); aRes++) {
+ const std::set<std::shared_ptr<ModelAPI_Attribute> >& aRefs = (*aRes)->data()->refsToMe();
+ std::set<std::shared_ptr<ModelAPI_Attribute> >::const_iterator aRefIter = aRefs.cbegin();
+ for(; aRefIter != aRefs.cend(); aRefIter++) {
+ FeaturePtr aReferenced = std::dynamic_pointer_cast<ModelAPI_Feature>((*aRefIter)->owner());
+ if (aReferenced.get()) {
+ addModified(aReferenced, theFeature);
+ }
+ }
+ }
+
+ // also add part feature that contains this feature to the modified
+ if (theFeature->document()->kind() != "PartSet") {
+ FeaturePtr aPart = ModelAPI_Tools::findPartFeature(
+ ModelAPI_Session::get()->moduleDocument(), theFeature->document());
+ if (aPart.get())
+ addModified(aPart, theFeature);
+ }
+ return;
}
void Model_Update::processEvent(const std::shared_ptr<Events_Message>& theMessage)
{
static Events_Loop* aLoop = Events_Loop::loop();
- static const Events_ID kChangedEvent = aLoop->eventByName("PreferenceChanged");
- static const Events_ID kRebuildEvent = aLoop->eventByName("Rebuild");
static const Events_ID kCreatedEvent = aLoop->eventByName(EVENT_OBJECT_CREATED);
static const Events_ID kUpdatedEvent = aLoop->eventByName(EVENT_OBJECT_UPDATED);
- static const Events_ID kMovedEvent = Events_Loop::loop()->eventByName(EVENT_OBJECT_MOVED);
static const Events_ID kOpFinishEvent = aLoop->eventByName("FinishOperation");
static const Events_ID kOpAbortEvent = aLoop->eventByName("AbortOperation");
static const Events_ID kOpStartEvent = aLoop->eventByName("StartOperation");
- bool isOperationChanged = false;
- if (theMessage->eventID() == kChangedEvent) { // automatic and manual rebuild flag is changed
- bool aPropVal =
- Config_PropManager::findProp("Model update", "automatic_rebuild")->value() == "true";
- if (aPropVal != myIsAutomatic) { // something is changed
- myIsAutomatic = aPropVal;
- if (myIsAutomatic) // higher level of automatization => to rebuild
- processOperation(false);
+ static const Events_ID kStabilityEvent = aLoop->eventByName(EVENT_STABILITY_CHANGED);
+#ifdef DEB_UPDATE
+ std::cout<<"****** Event "<<theMessage->eventID().eventText()<<std::endl;
+#endif
+ if (theMessage->eventID() == kStabilityEvent) {
+ updateStability(theMessage->sender());
+ return;
+ }
+ // creation is added to "update" to avoid recomputation twice: on create and immediately after on update
+ if (theMessage->eventID() == kCreatedEvent) {
+ std::shared_ptr<ModelAPI_ObjectUpdatedMessage> aMsg =
+ std::dynamic_pointer_cast<ModelAPI_ObjectUpdatedMessage>(theMessage);
+ const std::set<ObjectPtr>& anObjs = aMsg->objects();
+ std::set<ObjectPtr>::const_iterator anObjIter = anObjs.cbegin();
+ for(; anObjIter != anObjs.cend(); anObjIter++) {
+ ModelAPI_EventCreator::get()->sendUpdated(*anObjIter, kUpdatedEvent);
}
- } else if (theMessage->eventID() == kRebuildEvent) { // the rebuild command
- processOperation(true);
- } else if (theMessage->eventID() == kCreatedEvent || theMessage->eventID() == kUpdatedEvent ||
- theMessage->eventID() == kMovedEvent) {
+ return;
+ }
+ if (theMessage->eventID() == kUpdatedEvent) {
std::shared_ptr<ModelAPI_ObjectUpdatedMessage> aMsg =
std::dynamic_pointer_cast<ModelAPI_ObjectUpdatedMessage>(theMessage);
const std::set<ObjectPtr>& anObjs = aMsg->objects();
std::set<ObjectPtr>::const_iterator anObjIter = anObjs.cbegin();
- bool isOnlyResults = true; // check that only results were changed: only redisplay is needed
+ bool aSomeModified = false; // check that features not changed: only redisplay is needed
for(; anObjIter != anObjs.cend(); anObjIter++) {
- if (!std::dynamic_pointer_cast<ModelAPI_Result>(*anObjIter).get()) {
- isOnlyResults = false;
+ if (!(*anObjIter)->data()->isValid())
+ continue;
+ if ((*anObjIter)->groupName() == ModelAPI_ResultParameter::group()) {
+ myIsParamUpdated = true;
}
- // created objects are always must be up to date (python box feature)
- // and updated not in internal uptation chain
- if (theMessage->eventID() == kCreatedEvent) {
- myJustCreated.insert(*anObjIter);
- } else if (myJustCreated.find(*anObjIter) == myJustCreated.end()) { // moved and updated
- myJustUpdated.insert(*anObjIter);
+ // on undo/redo, abort do not update persisten features
+ bool anUpdateOnlyNotPersistent =
+ !std::dynamic_pointer_cast<Model_Document>((*anObjIter)->document())->executeFeatures();
+ FeaturePtr anUpdated = std::dynamic_pointer_cast<ModelAPI_Feature>(*anObjIter);
+ if (anUpdated.get()) {
+ if (!anUpdateOnlyNotPersistent || anUpdated->isPersistentResult()) {
+ addModified(anUpdated, FeaturePtr());
+ aSomeModified = true;
+ }
+ } else { // process the updated result as update of features that refers to this result
+ const std::set<std::shared_ptr<ModelAPI_Attribute> >& aRefs = (*anObjIter)->data()->refsToMe();
+ std::set<std::shared_ptr<ModelAPI_Attribute> >::const_iterator aRefIter = aRefs.cbegin();
+ for(; aRefIter != aRefs.cend(); aRefIter++) {
+ if (!(*aRefIter)->owner()->data()->isValid())
+ continue;
+ FeaturePtr anUpdated = std::dynamic_pointer_cast<ModelAPI_Feature>((*aRefIter)->owner());
+ if (anUpdated.get() && (!anUpdateOnlyNotPersistent || anUpdated->isPersistentResult())) {
+ addModified(anUpdated, FeaturePtr());
+ aSomeModified = true;
+ }
+ }
}
}
- // this event is for solver update, not here, do not react immideately
- if (!isOnlyResults && !(theMessage->eventID() == kMovedEvent))
- processOperation(false);
- } else if (theMessage->eventID() == kOpStartEvent) {
- // we don't need the update only on operation start (caused problems in PartSet_Listener::processEvent)
- isOperationChanged = true;
- } else if (theMessage->eventID() == kOpFinishEvent || theMessage->eventID() == kOpAbortEvent) {
- processOperation(true, theMessage->eventID() == kOpFinishEvent);
- isOperationChanged = true;
- }
- if (isOperationChanged) {
- // remove all macros before clearing all created and execute all not-previewed
- std::set<ObjectPtr>::iterator aCreatedIter = myJustCreated.begin();
- std::set<ObjectPtr>::iterator anUpdatedIter = myJustUpdated.begin();
- for(; aCreatedIter != myJustCreated.end() || anUpdatedIter != myJustUpdated.end();
- aCreatedIter == myJustCreated.end() ? anUpdatedIter++ : aCreatedIter++) {
- FeaturePtr aFeature = std::dynamic_pointer_cast<ModelAPI_Feature>(*
- (aCreatedIter == myJustCreated.end() ? anUpdatedIter : aCreatedIter));
+ // this event is for solver update, not here, do not react immediately
+ if (aSomeModified) {
+ processFeatures();
+ }
+ } else if (theMessage->eventID() == kOpFinishEvent || theMessage->eventID() == kOpAbortEvent ||
+ theMessage->eventID() == kOpStartEvent) {
+
+ if (!(theMessage->eventID() == kOpStartEvent)) {
+ if (theMessage->eventID() == kOpFinishEvent) {
+ myIsFinish = true;
+ // add features that wait for finish as modified
+ std::set<std::shared_ptr<ModelAPI_Feature> >::iterator aFeature = myProcessOnFinish.begin();
+ for(; aFeature != myProcessOnFinish.end(); aFeature++)
+ if ((*aFeature)->data()->isValid()) // there may be already removed wait for features
+ addModified(*aFeature, FeaturePtr());
+ myIsFinish = false;
+ }
+ myProcessOnFinish.clear();
+ processFeatures();
+ }
+ // remove all macros before clearing all created
+ std::set<FeaturePtr>::iterator anUpdatedIter = myWaitForFinish.begin();
+ while(anUpdatedIter != myWaitForFinish.end()) {
+ FeaturePtr aFeature = std::dynamic_pointer_cast<ModelAPI_Feature>(*anUpdatedIter);
if (aFeature.get()) {
- // execute not-previewed feature on "apply"
- if (!aFeature->isPreviewNeeded() && (myJustCreated.find(aFeature) != myJustCreated.end() ||
- myJustUpdated.find(aFeature) != myJustUpdated.end())) {
- static ModelAPI_ValidatorsFactory* aFactory = ModelAPI_Session::get()->validators();
- if (aFactory->validate(aFeature)) {
- executeFeature(aFeature);
- }
- }
- // remove macro on apply
+ // remove macro on finish
if (aFeature->isMacro()) {
aFeature->document()->removeFeature(aFeature);
+ myWaitForFinish.erase(aFeature);
+ }
+ // to avoid the map update problems on "remove"
+ if (myWaitForFinish.find(aFeature) == myWaitForFinish.end()) {
+ anUpdatedIter = myWaitForFinish.begin();
+ } else {
+ anUpdatedIter++;
}
+ } else {
+ anUpdatedIter++;
}
}
- myJustCreated.clear();
- myJustUpdated.clear();
+ // in the end of transaction everything is updated, so clear the old objects
+ myIsParamUpdated = false;
+ myWaitForFinish.clear();
}
}
-void Model_Update::processOperation(const bool theTotalUpdate, const bool theFinish)
+void Model_Update::processFeatures()
{
- if (theFinish) {
- // the hardcode (DBC asked): hide the sketch referenced by extrusion on apply
- std::set<std::shared_ptr<ModelAPI_Object> >::iterator aFIter;
- for(aFIter = myJustCreated.begin(); aFIter != myJustCreated.end(); aFIter++)
- {
- FeaturePtr aF = std::dynamic_pointer_cast<ModelAPI_Feature>(*aFIter);
- if (aF && aF->data()->isValid() && aF->getKind() == "Extrusion") {
- AttributeSelectionListPtr aBase = aF->selectionList("base");
- if (aBase.get()) {
- for(int a = aBase->size() - 1; a >= 0; a--) {
- ResultPtr aSketchRes = aBase->value(a)->context();
- if (aSketchRes) {
- aSketchRes->setDisplayed(false);
- }
- }
- }
- }
- }
- }
- // perform update of everything if needed
- if (!myIsExecuted) {
- myIsExecuted = true;
+ if (!myIsProcessed) { // perform update of everything if it is not performed right now
+ myIsProcessed = true;
+ #ifdef DEB_UPDATE
+ std::cout<<"****** Start processing"<<std::endl;
+ #endif
- bool isAutomaticChanged = false;
-
- if (theTotalUpdate && !myIsAutomatic) { // Apply button now works as "Rebuild"
- isAutomaticChanged = true;
- myIsAutomatic = true;
+ while(!myModified.empty()) {
+ processFeature(myModified.begin()->first);
}
+ myIsProcessed = false;
- updateInDoc(ModelAPI_Session::get()->moduleDocument());
-
- if (isAutomaticChanged) myIsAutomatic = false;
- myIsExecuted = false;
+ // flush updates just before "myModification" increment: to distinguish
+ // updates by "execute" produced by this updater and other updates, coming outside,
+ // which are really important for "processEvent" of this updater
+ static Events_Loop* aLoop = Events_Loop::loop();
+ static const Events_ID kUpdatedEvent = aLoop->eventByName(EVENT_OBJECT_UPDATED);
+ aLoop->flush(kUpdatedEvent);
// flush to update display
- static Events_Loop* aLoop = Events_Loop::loop();
static Events_ID EVENT_DISP = aLoop->eventByName(EVENT_OBJECT_TO_REDISPLAY);
aLoop->flush(EVENT_DISP);
+ #ifdef DEB_UPDATE
+ std::cout<<"****** End processing"<<std::endl;
+ #endif
}
}
-void Model_Update::updateInDoc(std::shared_ptr<ModelAPI_Document> theDoc)
+bool Model_Update::processFeature(FeaturePtr theFeature)
{
- std::set<FeaturePtr> alreadyProcessed; // features that are processed before others
- // all features one by one
- Model_Objects* anObjs = std::dynamic_pointer_cast<Model_Document>(theDoc)->objects();
- if (!anObjs) return;
- FeaturePtr aFeatureIter = anObjs->firstFeature();
- for (; aFeatureIter.get(); aFeatureIter = anObjs->nextFeature(aFeatureIter)) {
- if (aFeatureIter && alreadyProcessed.find(aFeatureIter) == alreadyProcessed.end()) {
- // update selection and parameters attributes first, before sub-features analysis (sketch plane)
- updateArguments(aFeatureIter);
- // composite feature must be executed after sub-features execution
- CompositeFeaturePtr aComposite =
- std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(aFeatureIter);
- if (aComposite) {
- // number of subs can be changed in execution: like fillet
- for(int a = 0; a < aComposite->numberOfSubs(); a++) {
- FeaturePtr aSub = aComposite->subFeature(a);
- updateArguments(aSub);
- updateFeature(aSub);
- alreadyProcessed.insert(aSub);
+ static ModelAPI_ValidatorsFactory* aFactory = ModelAPI_Session::get()->validators();
+
+ if (!theFeature->data()->isValid()) { // deleted feature, just remove from all containers
+ if (myModified.find(theFeature) != myModified.end())
+ myModified.erase(theFeature);
+ return false;
+ }
+
+ // check this feature is not yet checked or processed
+ bool aIsModified = myModified.find(theFeature) != myModified.end();
+ if (!aIsModified && myIsFinish) { // get info about the modification for features without preview
+ if (theFeature->data()->execState() == ModelAPI_StateMustBeUpdated) {
+ aIsModified = true;
+ std::set<std::shared_ptr<ModelAPI_Feature> > aNewSet;
+ aNewSet.insert(theFeature); // contains itself, so, we don't know which was the reason and the reason is any
+ myModified[theFeature] = aNewSet;
+ }
+ }
+
+#ifdef DEB_UPDATE
+ std::cout<<"* Process feature "<<theFeature->name()<<std::endl;
+#endif
+
+ // update the sketch plane before the sketch sub-elements are recomputed
+ // (otherwise sketch will update plane, modify subs, after executed, but with old subs edges)
+ if (aIsModified && theFeature->getKind() == "Sketch") {
+#ifdef DEB_UPDATE
+ std::cout<<"****** Update sketch args "<<theFeature->name()<<std::endl;
+#endif
+ AttributeSelectionPtr anExtSel = theFeature->selection("External");
+ if (anExtSel.get()) {
+ ResultPtr aContext = anExtSel->context();
+ if (aContext.get() && aContext->document().get()) {
+ FeaturePtr anExtBase = aContext->document()->feature(aContext);
+ if (anExtBase.get()) {
+ processFeature(anExtBase);
}
}
+ }
+ updateArguments(theFeature);
+ }
- updateFeature(aFeatureIter);
- // update the document results recursively
- const std::list<std::shared_ptr<ModelAPI_Result> >& aResults = aFeatureIter->results();
- std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aRIter = aResults.begin();
- for (; aRIter != aResults.cend(); aRIter++) {
- ResultPartPtr aPart = std::dynamic_pointer_cast<ModelAPI_ResultPart>(*aRIter);
- if (aPart.get()) {
- if (!aPart->isDisabled() && aPart->isActivated()) {
- updateInDoc(aPart->partDoc());
+ if (!aIsModified) { // no modification is needed
+ return false;
+ }
+
+ // check all features this feature depended on (recursive call of updateFeature)
+ std::set<std::shared_ptr<ModelAPI_Feature> >& aReasons = myModified[theFeature];
+ if (aReasons.find(theFeature) == aReasons.end()) {
+ std::set<std::shared_ptr<ModelAPI_Feature> >::iterator aReasonIter = aReasons.begin();
+ for(; aReasonIter != aReasons.end(); aReasonIter++) {
+ if (*aReasonIter != theFeature && processFeature(*aReasonIter)) {
+ aIsModified = true;
+ }
+ }
+ } else { // check all features this feature depended on because here which one was modified is unknown
+ std::list<std::pair<std::string, std::list<std::shared_ptr<ModelAPI_Object> > > > aDeps;
+ theFeature->data()->referencesToObjects(aDeps);
+ std::list<std::pair<std::string, std::list<std::shared_ptr<ModelAPI_Object> > > >::iterator
+ anAttrsIter = aDeps.begin();
+ for(; anAttrsIter != aDeps.end(); anAttrsIter++) {
+ std::list<std::shared_ptr<ModelAPI_Object> >::iterator aDepIter = anAttrsIter->second.begin();
+ for(; aDepIter != anAttrsIter->second.end(); aDepIter++) {
+ FeaturePtr aDepFeat = std::dynamic_pointer_cast<ModelAPI_Feature>(*aDepIter);
+ if (!aDepFeat.get()) { // so, it depends on the result and process the feature owner of it
+ ResultPtr aDepRes = std::dynamic_pointer_cast<ModelAPI_Result>(*aDepIter);
+ if (aDepRes.get()) {
+ aDepFeat = (*aDepIter)->document()->feature(aDepRes);
}
}
+ if (aDepFeat.get()) {
+ if (processFeature(aDepFeat))
+ aIsModified = true;
+ }
+ }
+ }
+ if (theFeature->getKind() == "Part") { // part is not depended on its subs directly, but subs must be iterated anyway
+ CompositeFeaturePtr aPart = std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(theFeature);
+ int aNum = aPart->numberOfSubs();
+ for(int a = 0; a < aNum; a++) {
+ FeaturePtr aSub = aPart->subFeature(a);
+ if (aSub.get()) {
+ if (processFeature(aSub))
+ aIsModified = true;
+ }
}
}
}
+
+ // do not execute the composite that contains the current
+ bool isPostponedMain = false;
+ CompositeFeaturePtr aCompos = std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(theFeature);
+ if (theFeature->getKind() == "ExtrusionSketch" && aCompos.get()) {
+ CompositeFeaturePtr aCurrentOwner =
+ ModelAPI_Tools::compositeOwner(theFeature->document()->currentFeature(false));
+ isPostponedMain = aCurrentOwner.get() && aCompos->isSub(aCurrentOwner);
+ }
+
+ #ifdef DEB_UPDATE
+ std::cout<<"Update args "<<theFeature->name()<<std::endl;
+ #endif
+ // Update selection and parameters attributes first, before sub-features analysis (sketch plane).
+ updateArguments(theFeature);
+
+ // add this feature to the processed right now to be able remove it from this list on
+ // update signal during this feature execution
+ myModified.erase(theFeature);
+ if (theFeature->data()->execState() == ModelAPI_StateMustBeUpdated)
+ theFeature->data()->execState(ModelAPI_StateDone);
+
+ // this checking must be after the composite feature sub-elements processing:
+ // composite feature status may depend on it's subelements
+ if (theFeature->data()->execState() == ModelAPI_StateInvalidArgument) {
+ theFeature->eraseResults();
+ redisplayWithResults(theFeature, ModelAPI_StateInvalidArgument); // result also must be updated
+ return true; // so, feature is modified (results are erased)
+ }
+
+ // On abort, undo or redo execute is not needed: results in document are updated automatically
+ // But redisplay is needed: results are updated, must be also updated in the viewer.
+ if (!std::dynamic_pointer_cast<Model_Document>(theFeature->document())->executeFeatures()) {
+ if (!theFeature->isPersistentResult()) { // not persistent must be re-executed on abort, etc.
+ ModelAPI_ExecState aState = theFeature->data()->execState();
+ if (aFactory->validate(theFeature)) {
+ executeFeature(theFeature);
+ } else {
+ theFeature->eraseResults();
+ redisplayWithResults(theFeature, ModelAPI_StateInvalidArgument); // result also must be updated
+ }
+ } else {
+ redisplayWithResults(theFeature, ModelAPI_StateNothing);
+ if (theFeature->data()->execState() == ModelAPI_StateMustBeUpdated) { // it is done (in the tree)
+ theFeature->data()->execState(ModelAPI_StateDone);
+ }
+ }
+ } else {
+ // execute feature if it must be updated
+ ModelAPI_ExecState aState = theFeature->data()->execState();
+ if (aFactory->validate(theFeature)) {
+ if (!isPostponedMain) {
+ executeFeature(theFeature);
+ }
+ } else {
+ #ifdef DEB_UPDATE
+ std::cout<<"Feature is not valid, erase results "<<theFeature->name()<<std::endl;
+ #endif
+ theFeature->eraseResults();
+ redisplayWithResults(theFeature, ModelAPI_StateInvalidArgument); // result also must be updated
+ }
+ }
+ return true;
}
void Model_Update::redisplayWithResults(FeaturePtr theFeature, const ModelAPI_ExecState theState)
{
// make updated and redisplay all results
static Events_ID EVENT_DISP = Events_Loop::loop()->eventByName(EVENT_OBJECT_TO_REDISPLAY);
- const std::list<std::shared_ptr<ModelAPI_Result> >& aResults = theFeature->results();
- std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aRIter = aResults.begin();
- for (; aRIter != aResults.cend(); aRIter++) {
+
+ std::list<ResultPtr> allResults;
+ ModelAPI_Tools::allResults(theFeature, allResults);
+ std::list<ResultPtr>::iterator aRIter = allResults.begin();
+ for (; aRIter != allResults.cend(); aRIter++) {
std::shared_ptr<ModelAPI_Result> aRes = *aRIter;
- aRes->data()->execState(theState);
- myJustUpdated.insert(aRes);
+ if (!aRes->isDisabled()) {// update state only for enabled results (Placement Result Part may make the original Part Result as invalid)
+ aRes->data()->execState(theState);
+ }
+ if (theFeature->data()->updateID() > aRes->data()->updateID()) {
+ aRes->data()->setUpdateID(theFeature->data()->updateID());
+ }
ModelAPI_EventCreator::get()->sendUpdated(aRes, EVENT_DISP);
}
// to redisplay "presentable" feature (for ex. distance constraint)
if (theTarget) {
ModelAPI_ExecState aRefState = theTarget->data()->execState();
if (aRefState == ModelAPI_StateMustBeUpdated) {
- return ModelAPI_StateMustBeUpdated;
+ if (theCurrent == ModelAPI_StateDone)
+ return ModelAPI_StateMustBeUpdated;
} else if (aRefState != ModelAPI_StateDone) {
return ModelAPI_StateInvalidArgument;
}
void Model_Update::updateArguments(FeaturePtr theFeature) {
// perform this method also for disabled features: to make "not done" state for
- // featuers referenced to the active and modified features
+ // features referenced to the active and modified features
static ModelAPI_ValidatorsFactory* aFactory = ModelAPI_Session::get()->validators();
- bool aJustUpdated = false;
ModelAPI_ExecState aState = theFeature->data()->execState();
+ if (aState == ModelAPI_StateExecFailed) { // try again failed feature: issue 577
+ aState = ModelAPI_StateMustBeUpdated;
+ }
if (aState == ModelAPI_StateInvalidArgument) // a chance to be corrected
aState = ModelAPI_StateMustBeUpdated;
// check the parameters state
+ // Integer
+ {
+ std::list<AttributePtr> anAttrinbutes =
+ theFeature->data()->attributes(ModelAPI_AttributeInteger::typeId());
+ std::list<AttributePtr>::iterator anIter = anAttrinbutes.begin();
+ for(; anIter != anAttrinbutes.end(); anIter++) {
+ AttributeIntegerPtr anAttribute =
+ std::dynamic_pointer_cast<ModelAPI_AttributeInteger>(*anIter);
+ if (anAttribute.get() && !anAttribute->text().empty()) {
+ if (myIsParamUpdated) {
+ ModelAPI_AttributeEvalMessage::send(anAttribute, this);
+ }
+ if (anAttribute->expressionInvalid()) {
+ aState = ModelAPI_StateInvalidArgument;
+ }
+ }
+ }
+ }
// Double
- std::list<AttributePtr> aDoubles =
- theFeature->data()->attributes(ModelAPI_AttributeDouble::typeId());
- std::list<AttributePtr>::iterator aDoubleIter = aDoubles.begin();
- for(; aDoubleIter != aDoubles.end(); aDoubleIter++) {
- AttributeDoublePtr aDouble =
- std::dynamic_pointer_cast<ModelAPI_AttributeDouble>(*aDoubleIter);
- if (aDouble.get() && !aDouble->text().empty()) {
- if (aDouble->expressionInvalid()) {
- aState = ModelAPI_StateInvalidArgument;
+ {
+ std::list<AttributePtr> aDoubles =
+ theFeature->data()->attributes(ModelAPI_AttributeDouble::typeId());
+ std::list<AttributePtr>::iterator aDoubleIter = aDoubles.begin();
+ for(; aDoubleIter != aDoubles.end(); aDoubleIter++) {
+ AttributeDoublePtr aDouble =
+ std::dynamic_pointer_cast<ModelAPI_AttributeDouble>(*aDoubleIter);
+ if (aDouble.get() && !aDouble->text().empty()) {
+ if (myIsParamUpdated) {
+ ModelAPI_AttributeEvalMessage::send(aDouble, this);
+ }
+ if (aDouble->expressionInvalid()) {
+ aState = ModelAPI_StateInvalidArgument;
+ }
}
}
}
AttributePointPtr aPointAttribute =
std::dynamic_pointer_cast<GeomDataAPI_Point>(*anIter);
if (aPointAttribute.get()) {
+ if (myIsParamUpdated) {
+ ModelAPI_AttributeEvalMessage::send(aPointAttribute, this);
+ }
if ((!aPointAttribute->textX().empty() && aPointAttribute->expressionInvalid(0)) ||
- (!aPointAttribute->textY().empty() && aPointAttribute->expressionInvalid(1)) ||
- (!aPointAttribute->textZ().empty() && aPointAttribute->expressionInvalid(2)))
+ (!aPointAttribute->textY().empty() && aPointAttribute->expressionInvalid(1)) ||
+ (!aPointAttribute->textZ().empty() && aPointAttribute->expressionInvalid(2)))
aState = ModelAPI_StateInvalidArgument;
}
}
AttributePoint2DPtr aPoint2DAttribute =
std::dynamic_pointer_cast<GeomDataAPI_Point2D>(*anIter);
if (aPoint2DAttribute.get()) {
+ if (myIsParamUpdated) {
+ ModelAPI_AttributeEvalMessage::send(aPoint2DAttribute, this);
+ }
if ((!aPoint2DAttribute->textX().empty() && aPoint2DAttribute->expressionInvalid(0)) ||
- (!aPoint2DAttribute->textY().empty() && aPoint2DAttribute->expressionInvalid(1)))
+ (!aPoint2DAttribute->textY().empty() && aPoint2DAttribute->expressionInvalid(1)))
aState = ModelAPI_StateInvalidArgument;
}
}
}
-
- //if (aState == ModelAPI_StateDone) {// all referenced objects are ready to be used
- //std::cout<<"Execute feature "<<theFeature->getKind()<<std::endl;
- // before execution update the selection attributes if any
- list<AttributePtr> aRefs =
- theFeature->data()->attributes(ModelAPI_AttributeSelection::typeId());
- list<AttributePtr>::iterator aRefsIter = aRefs.begin();
- for (; aRefsIter != aRefs.end(); aRefsIter++) {
- std::shared_ptr<ModelAPI_AttributeSelection> aSel =
- std::dynamic_pointer_cast<ModelAPI_AttributeSelection>(*aRefsIter);
- ObjectPtr aContext = aSel->context();
- // update argument onlt if the referenced object is changed
- if (aContext.get() && isUpdated(aContext) && !aContext->isDisabled()) {
- if (aState == ModelAPI_StateDone)
- aState = ModelAPI_StateMustBeUpdated;
- if (!aSel->update()) { // this must be done on execution since it may be long operation
- if (!aFactory->isNotObligatory(theFeature->getKind(), theFeature->data()->id(aSel)) &&
- aFactory->isCase(theFeature, theFeature->data()->id(aSel)))
- aState = ModelAPI_StateInvalidArgument;
- }
+ // update the selection attributes if any
+ list<AttributePtr> aRefs =
+ theFeature->data()->attributes(ModelAPI_AttributeSelection::typeId());
+ list<AttributePtr>::iterator aRefsIter = aRefs.begin();
+ for (; aRefsIter != aRefs.end(); aRefsIter++) {
+ std::shared_ptr<ModelAPI_AttributeSelection> aSel =
+ std::dynamic_pointer_cast<ModelAPI_AttributeSelection>(*aRefsIter);
+ ObjectPtr aContext = aSel->context();
+ // update argument only if the referenced object is ready to use
+ if (aContext.get() && !aContext->isDisabled() && isReason(theFeature, aContext)) {
+ if (!aSel->update()) { // this must be done on execution since it may be long operation
+ bool isObligatory = !aFactory->isNotObligatory(
+ theFeature->getKind(), theFeature->data()->id(aSel)) &&
+ aFactory->isCase(theFeature, theFeature->data()->id(aSel));
+ if (isObligatory)
+ aState = ModelAPI_StateInvalidArgument;
}
}
- aRefs = theFeature->data()->attributes(ModelAPI_AttributeSelectionList::typeId());
- for (aRefsIter = aRefs.begin(); aRefsIter != aRefs.end(); aRefsIter++) {
- std::shared_ptr<ModelAPI_AttributeSelectionList> aSel =
- std::dynamic_pointer_cast<ModelAPI_AttributeSelectionList>(*aRefsIter);
- for(int a = aSel->size() - 1; a >= 0; a--) {
- std::shared_ptr<ModelAPI_AttributeSelection> aSelAttr =
- std::dynamic_pointer_cast<ModelAPI_AttributeSelection>(aSel->value(a));
- if (aSelAttr) {
- ObjectPtr aContext = aSelAttr->context();
- // update argument onlt if the referenced object is changed
- if (aContext.get() && isUpdated(aContext) && !aContext->isDisabled()) {
- if (aState == ModelAPI_StateDone)
- aState = ModelAPI_StateMustBeUpdated;
- if (!aSelAttr->update()) {
- if (!aFactory->isNotObligatory(
- theFeature->getKind(), theFeature->data()->id(aSel)) &&
- aFactory->isCase(theFeature, theFeature->data()->id(aSel)))
- aState = ModelAPI_StateInvalidArgument;
- }
+ }
+ // update the selection list attributes if any
+ aRefs = theFeature->data()->attributes(ModelAPI_AttributeSelectionList::typeId());
+ for (aRefsIter = aRefs.begin(); aRefsIter != aRefs.end(); aRefsIter++) {
+ std::shared_ptr<ModelAPI_AttributeSelectionList> aSel =
+ std::dynamic_pointer_cast<ModelAPI_AttributeSelectionList>(*aRefsIter);
+ for(int a = aSel->size() - 1; a >= 0; a--) {
+ std::shared_ptr<ModelAPI_AttributeSelection> aSelAttr =
+ std::dynamic_pointer_cast<ModelAPI_AttributeSelection>(aSel->value(a));
+ if (aSelAttr) {
+ ObjectPtr aContext = aSelAttr->context();
+ // update argument only if the referenced object is ready to use
+ if (aContext.get() && !aContext->isDisabled() && isReason(theFeature, aContext)) {
+ if (!aSelAttr->update()) {
+ bool isObligatory = !aFactory->isNotObligatory(
+ theFeature->getKind(), theFeature->data()->id(aSel)) &&
+ aFactory->isCase(theFeature, theFeature->data()->id(aSel));
+ if (isObligatory)
+ aState = ModelAPI_StateInvalidArgument;
}
}
}
}
- //}
- if (aJustUpdated && myJustCreated.find(theFeature) == myJustCreated.end())
- myJustUpdated.insert(theFeature);
+ }
+
if (aState != ModelAPI_StateDone)
theFeature->data()->execState(aState);
}
-void Model_Update::updateFeature(FeaturePtr theFeature)
+bool Model_Update::isReason(std::shared_ptr<ModelAPI_Feature>& theFeature,
+ std::shared_ptr<ModelAPI_Object> theReason)
{
- // check all features this feature depended on (recursive call of updateFeature)
- static ModelAPI_ValidatorsFactory* aFactory = ModelAPI_Session::get()->validators();
-
- if (theFeature->isDisabled() || // nothing to do with disabled feature
- theFeature->data()->execState() == ModelAPI_StateInvalidArgument)
- return;
- bool aJustUpdated = false;
-
- if (theFeature) {
- if (myIsAutomatic && theFeature->data()->execState() == ModelAPI_StateMustBeUpdated)
- aJustUpdated = true;
-
- ModelAPI_ExecState aState = ModelAPI_StateDone;
-
- // check all references: if referenced objects are updated, this object also must be updated
- // also check state of referenced objects: if they are not ready, inherit corresponding state
- std::list<std::pair<std::string, std::list<ObjectPtr> > > aRefs;
- std::shared_ptr<Model_Data> aData =
- std::dynamic_pointer_cast<Model_Data>(theFeature->data());
- aData->referencesToObjects(aRefs);
- std::list<std::pair<std::string, std::list<ObjectPtr> > >::iterator aRef = aRefs.begin();
- for(; aRef != aRefs.end(); aRef++) {
- std::list<ObjectPtr>::iterator aRefObj = aRef->second.begin();
- for(; aRefObj != aRef->second.end(); aRefObj++) {
- if (myJustCreated.find(*aRefObj) != myJustCreated.end() ||
- myJustUpdated.find(*aRefObj) != myJustUpdated.end()) {
- aJustUpdated = true;
- }
- aState = stateByReference(*aRefObj, aState);
- }
- }
-
- // some arguments were changed, so, this feature must be updated
- if (myJustCreated.find(theFeature) != myJustCreated.end()) {
- aJustUpdated = true;
- } else {
- if (aJustUpdated) {
- if (myJustUpdated.find(theFeature) == myJustUpdated.end())
- myJustUpdated.insert(theFeature);
- } else {
- aJustUpdated = myJustUpdated.find(theFeature) != myJustUpdated.end();
- }
- }
- //std::cout<<"Update feature "<<theFeature->getKind()<<" must be updated = "<<aMustbeUpdated<<std::endl;
- // execute feature if it must be updated
- if (aJustUpdated) {
- if (theFeature->isPreviewNeeded()) {
- if (std::dynamic_pointer_cast<Model_Document>(theFeature->document())->executeFeatures() ||
- !theFeature->isPersistentResult()) {
- if (aFactory->validate(theFeature)) {
- FeaturePtr aCurrent = theFeature->document()->currentFeature(false);
- if (myIsAutomatic || !theFeature->isPersistentResult() /* execute quick, not persistent results */
- || (isUpdated(theFeature) &&
- (theFeature == aCurrent ||
- (aCurrent.get() && aCurrent->isMacro())))) // currently edited
- {
- if (aState == ModelAPI_StateDone || aState == ModelAPI_StateMustBeUpdated) {
- executeFeature(theFeature);
- }
- } else { // must be updatet, but not updated yet
- theFeature->data()->execState(ModelAPI_StateMustBeUpdated);
- const std::list<std::shared_ptr<ModelAPI_Result> >& aResults = theFeature->results();
- std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aRIter = aResults.begin();
- for (; aRIter != aResults.cend(); aRIter++) {
- std::shared_ptr<ModelAPI_Result> aRes = *aRIter;
- aRes->data()->execState(ModelAPI_StateMustBeUpdated);
- }
- }
- } else {
- theFeature->eraseResults();
- redisplayWithResults(theFeature, ModelAPI_StateInvalidArgument); // result also must be updated
- }
- } else { // for automatically updated features (on abort, etc) it is necessary to redisplay anyway
- redisplayWithResults(theFeature, ModelAPI_StateNothing);
- }
- } else { // preview is not needed => make state Done
- if (theFeature->data()->execState() == ModelAPI_StateMustBeUpdated)
- theFeature->data()->execState(ModelAPI_StateDone);
- }
- }
+ std::map<std::shared_ptr<ModelAPI_Feature>, std::set<std::shared_ptr<ModelAPI_Feature> > >
+ ::iterator aReasonsIt = myModified.find(theFeature);
+ if (aReasonsIt->second.find(theFeature) != aReasonsIt->second.end())
+ return true; // any is reason if it contains itself
+ FeaturePtr aReasFeat = std::dynamic_pointer_cast<ModelAPI_Feature>(theReason);
+ if (!aReasFeat.get()) { // try to get feature of this result
+ ResultPtr aReasRes = std::dynamic_pointer_cast<ModelAPI_Result>(theReason);
+ if (aReasRes.get())
+ aReasFeat = theReason->document()->feature(aReasRes);
}
+ return aReasonsIt->second.find(aReasFeat) != aReasonsIt->second.end();
+
}
void Model_Update::executeFeature(FeaturePtr theFeature)
{
+#ifdef DEB_UPDATE
+ std::cout<<"Execute Feature "<<theFeature->name()<<std::endl;
+#endif
// execute in try-catch to avoid internal problems of the feature
ModelAPI_ExecState aState = ModelAPI_StateDone;
theFeature->data()->execState(ModelAPI_StateDone);
Events_Error::send(
"Feature " + theFeature->getKind() + " has failed during the execution");
}
+ // The macro feature has to be deleted in any case even its execution is failed
+ myWaitForFinish.insert(theFeature);
if (aState != ModelAPI_StateDone) {
theFeature->eraseResults();
}
+ theFeature->data()->setUpdateID(ModelAPI_Session::get()->transactionID());
redisplayWithResults(theFeature, aState);
}
-bool Model_Update::isUpdated(const ObjectPtr& theObj)
+void Model_Update::updateStability(void* theSender)
{
- return myJustCreated.find(theObj) != myJustCreated.end() ||
- myJustUpdated.find(theObj) != myJustUpdated.end();
+ if (theSender) {
+ bool added = false; // object may be was crated
+ ModelAPI_Object* aSender = static_cast<ModelAPI_Object*>(theSender);
+ if (aSender && aSender->document()) {
+ FeaturePtr aFeatureSender =
+ std::dynamic_pointer_cast<ModelAPI_Feature>(aSender->data()->owner());
+ if (aFeatureSender.get()) {
+ Model_Objects* aDocObjects =
+ std::dynamic_pointer_cast<Model_Document>(aSender->document())->objects();
+ if (aDocObjects) {
+ //aDocObjects->synchronizeBackRefs();
+ // remove or add all concealment refs from this feature
+ std::list<std::pair<std::string, std::list<ObjectPtr> > > aRefs;
+ aSender->data()->referencesToObjects(aRefs);
+ std::list<std::pair<std::string, std::list<ObjectPtr> > >::iterator aRefIt = aRefs.begin();
+ for(; aRefIt != aRefs.end(); aRefIt++) {
+ std::list<ObjectPtr>& aRefFeaturesList = aRefIt->second;
+ std::list<ObjectPtr>::iterator aReferenced = aRefFeaturesList.begin();
+ for(; aReferenced != aRefFeaturesList.end(); aReferenced++) {
+ // stability is only on results: feature to feature reference mean nested
+ // features, that will remove nesting references
+ if (aReferenced->get() && (*aReferenced)->data()->isValid() &&
+ (*aReferenced)->groupName() != ModelAPI_Feature::group()) {
+ std::shared_ptr<Model_Data> aData =
+ std::dynamic_pointer_cast<Model_Data>((*aReferenced)->data());
+ if (aFeatureSender->isStable()) {
+ aData->addBackReference(aFeatureSender, aRefIt->first);
+ } else {
+ aData->removeBackReference(aFeatureSender, aRefIt->first);
+ added = true; // remove of concealment may be caused creation of some result
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+ if (added) {
+ static Events_Loop* aLoop = Events_Loop::loop();
+ static Events_ID kEventCreated = aLoop->eventByName(EVENT_OBJECT_CREATED);
+ aLoop->flush(kEventCreated);
+ }
+ }
}