Salome HOME
Add dumping named of copied entities in the sketch (issue #1924)
[modules/shaper.git] / src / Model / Model_AttributeSelection.cpp
index 1de8bcb7e9595e1ca948ad4424fe0c115fee9afb..8391d72f551a6f083722c39e003b7b065145bcb6 100644 (file)
@@ -11,6 +11,7 @@
 #include "Model_Document.h"
 #include "Model_SelectionNaming.h"
 #include <Model_Objects.h>
+#include <Model_AttributeSelectionList.h>
 #include <ModelAPI_Feature.h>
 #include <ModelAPI_ResultBody.h>
 #include <ModelAPI_ResultConstruction.h>
@@ -18,6 +19,7 @@
 #include <ModelAPI_CompositeFeature.h>
 #include <ModelAPI_Tools.h>
 #include <GeomAPI_Shape.h>
+#include <ModelAPI_Session.h>
 #include <GeomAPI_PlanarEdges.h>
 #include <Events_InfoMessage.h>
 
@@ -26,6 +28,9 @@
 #include <TNaming_Tool.hxx>
 #include <TNaming_Builder.hxx>
 #include <TNaming_Localizer.hxx>
+#include <TNaming_SameShapeIterator.hxx>
+#include <TNaming_Iterator.hxx>
+#include <TNaming_NewShapeIterator.hxx>
 #include <TopoDS_Shape.hxx>
 #include <TopoDS_Compound.hxx>
 #include <TDataStd_IntPackedMap.hxx>
@@ -56,9 +61,7 @@
 #include <TopAbs_ShapeEnum.hxx>
 #include <TopoDS_Iterator.hxx>
 #include <BRep_Builder.hxx>
-#include <ModelAPI_Session.h>
 
-using namespace std;
 //#define DEB_NAMING 1
 #ifdef DEB_NAMING
 #include <BRepTools.hxx>
@@ -127,7 +130,7 @@ void Model_AttributeSelection::setValue(const ResultPtr& theContext,
   if (theContext->groupName() == ModelAPI_ResultBody::group()) {
     // do not select the whole shape for body:it is already must be in the data framework
     // equal and null selected objects mean the same: object is equal to context,
-    if (theContext->shape().get() && 
+    if (theContext->shape().get() &&
         (theContext->shape()->isEqual(theSubShape) || !theSubShape.get())) {
       aSelLab.ForgetAllAttributes(true);
       TDataStd_UAttribute::Set(aSelLab, kSIMPLE_REF_ID);
@@ -139,19 +142,19 @@ void Model_AttributeSelection::setValue(const ResultPtr& theContext,
       // to sub, so the whole result is selected
       aSelLab.ForgetAllAttributes(true);
       TDataStd_UAttribute::Set(aSelLab, kCONSTUCTION_SIMPLE_REF_ID);
-      ResultConstructionPtr aConstruction = 
+      ResultConstructionPtr aConstruction =
         std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(theContext);
       if (aConstruction->isInfinite()) {
         // For correct naming selection, put the shape into the naming structure.
         // It seems sub-shapes are not needed: only this shape is (and can be ) selected.
         TNaming_Builder aBuilder(aSelLab);
         aBuilder.Generated(theContext->shape()->impl<TopoDS_Shape>());
-        std::shared_ptr<Model_Document> aMyDoc = 
+        std::shared_ptr<Model_Document> aMyDoc =
           std::dynamic_pointer_cast<Model_Document>(owner()->document());
-        std::string aName = contextName(theContext);
+        //std::string aName = contextName(theContext);
         // for selection in different document, add the document name
-        aMyDoc->addNamingName(aSelLab, aName);
-        TDataStd_Name::Set(aSelLab, aName.c_str());
+        //aMyDoc->addNamingName(aSelLab, aName);
+        //TDataStd_Name::Set(aSelLab, aName.c_str());
       } else {  // for sketch the naming is needed in DS
         BRep_Builder aCompoundBuilder;
         TopoDS_Compound aComp;
@@ -178,11 +181,20 @@ void Model_AttributeSelection::setValue(const ResultPtr& theContext,
   owner()->data()->sendAttributeUpdated(this);
 }
 
+void Model_AttributeSelection::removeTemporaryValues()
+{
+  if (myTmpContext.get() || myTmpSubShape.get()) {
+    myTmpContext.reset();
+    myTmpSubShape.reset();
+  }
+}
+
 std::shared_ptr<GeomAPI_Shape> Model_AttributeSelection::value()
 {
   GeomShapePtr aResult;
   if (myTmpContext.get() || myTmpSubShape.get()) {
-    ResultConstructionPtr aResulConstruction = std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(myTmpContext);
+    ResultConstructionPtr aResulConstruction =
+      std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(myTmpContext);
     if(aResulConstruction.get()) {
       // it is just reference to construction.
       return myTmpSubShape;
@@ -197,11 +209,12 @@ std::shared_ptr<GeomAPI_Shape> Model_AttributeSelection::value()
   if (myRef.isInitialized()) {
     if (aSelLab.IsAttribute(kSIMPLE_REF_ID)) { // it is just reference to shape, not sub-shape
       ResultPtr aContext = context();
-      if (!aContext.get()) 
+      if (!aContext.get())
         return aResult; // empty result
       return aContext->shape();
     }
-    if (aSelLab.IsAttribute(kCONSTUCTION_SIMPLE_REF_ID)) { // it is just reference to construction, nothing is in value
+    if (aSelLab.IsAttribute(kCONSTUCTION_SIMPLE_REF_ID)) {
+      // it is just reference to construction, nothing is in value
         return aResult; // empty result
     }
     if (aSelLab.IsAttribute(kPART_REF_ID)) {
@@ -217,8 +230,8 @@ std::shared_ptr<GeomAPI_Shape> Model_AttributeSelection::value()
           if (selectionLabel().FindAttribute(TDataStd_Name::GetID(), aName)) {
             std::string aSubShapeName(TCollection_AsciiString(aName->Get()).ToCString());
             std::size_t aPartEnd = aSubShapeName.find('/');
-            if (aPartEnd != string::npos && aPartEnd != aSubShapeName.rfind('/')) {
-              string aNameInPart = aSubShapeName.substr(aPartEnd + 1);
+            if (aPartEnd != std::string::npos && aPartEnd != aSubShapeName.rfind('/')) {
+              std::string aNameInPart = aSubShapeName.substr(aPartEnd + 1);
               int anIndex;
               std::string aType; // to reuse already existing selection the type is not needed
               return aPart->shapeInPart(aNameInPart, aType, anIndex);
@@ -234,7 +247,7 @@ std::shared_ptr<GeomAPI_Shape> Model_AttributeSelection::value()
       aResult = std::shared_ptr<GeomAPI_Shape>(new GeomAPI_Shape);
       aResult->setImpl(new TopoDS_Shape(aSelShape));
     } else { // for simple construction element: just shape of this construction element
-      ResultConstructionPtr aConstr = 
+      ResultConstructionPtr aConstr =
         std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(context());
       if (aConstr) {
         return aConstr->shape();
@@ -259,7 +272,8 @@ bool Model_AttributeSelection::isInitialized()
         ResultPtr aContext = context();
         return aContext.get() != NULL;
       }
-      if (aSelLab.IsAttribute(kCONSTUCTION_SIMPLE_REF_ID)) { // it is just reference to construction, nothing is in value
+      if (aSelLab.IsAttribute(kCONSTUCTION_SIMPLE_REF_ID)) {
+        // it is just reference to construction, nothing is in value
           return true;
       }
 
@@ -267,7 +281,7 @@ bool Model_AttributeSelection::isInitialized()
       if (selectionLabel().FindAttribute(TNaming_NamedShape::GetID(), aSelection)) {
         return !aSelection->Get().IsNull();
       } else { // for simple construction element: just shape of this construction element
-        ResultConstructionPtr aConstr = 
+        ResultConstructionPtr aConstr =
           std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(context());
         if (aConstr.get()) {
           return aConstr->shape().get() != NULL;
@@ -282,6 +296,7 @@ Model_AttributeSelection::Model_AttributeSelection(TDF_Label& theLabel)
   : myRef(theLabel)
 {
   myIsInitialized = myRef.isInitialized();
+  myParent = NULL;
 }
 
 void Model_AttributeSelection::setID(const std::string theID)
@@ -329,7 +344,7 @@ TDF_LabelMap& Model_AttributeSelection::scope()
     std::list<std::shared_ptr<ModelAPI_Feature> > allFeatures = aMyDoc->allFeatures();
     std::list<std::shared_ptr<ModelAPI_Feature> >::iterator aFIter = allFeatures.begin();
     bool aMePassed = false;
-    CompositeFeaturePtr aComposite = 
+    CompositeFeaturePtr aComposite =
       std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(owner());
     FeaturePtr aFeature = std::dynamic_pointer_cast<ModelAPI_Feature>(owner());
     CompositeFeaturePtr aCompositeOwner, aCompositeOwnerOwner;
@@ -348,7 +363,8 @@ TDF_LabelMap& Model_AttributeSelection::scope()
       }
       if (isGroup) aMePassed = false;
       bool isInScope = !aMePassed;
-      if (!isInScope && aComposite.get()) { // try to add sub-elements of composite if this is composite
+      if (!isInScope && aComposite.get()) {
+        // try to add sub-elements of composite if this is composite
         if (aComposite->isSub(*aFIter))
           isInScope = true;
       }
@@ -387,14 +403,15 @@ bool Model_AttributeSelection::update()
 {
   TDF_Label aSelLab = selectionLabel();
   ResultPtr aContext = context();
-  if (!aContext.get()) 
+  if (!aContext.get())
     return setInvalidIfFalse(aSelLab, false);
   if (aSelLab.IsAttribute(kSIMPLE_REF_ID)) { // it is just reference to shape, not sub-shape
     return setInvalidIfFalse(aSelLab, aContext->shape() && !aContext->shape()->isNull());
   }
-  if (aSelLab.IsAttribute(kCONSTUCTION_SIMPLE_REF_ID)) { // it is just reference to construction, not sub-shape
+  if (aSelLab.IsAttribute(kCONSTUCTION_SIMPLE_REF_ID)) {
+    // it is just reference to construction, not sub-shape
     // if there is a sketch, the sketch-naming must be updated
-    ResultConstructionPtr aConstruction = 
+    ResultConstructionPtr aConstruction =
       std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(aContext);
     if (!aConstruction->isInfinite()) {
       BRep_Builder aCompoundBuilder;
@@ -412,11 +429,8 @@ bool Model_AttributeSelection::update()
       // It seems sub-shapes are not needed: only this shape is (and can be ) selected.
       TNaming_Builder aBuilder(aSelLab);
       aBuilder.Generated(aContext->shape()->impl<TopoDS_Shape>());
-      std::shared_ptr<Model_Document> aMyDoc = 
+      std::shared_ptr<Model_Document> aMyDoc =
         std::dynamic_pointer_cast<Model_Document>(owner()->document());
-      std::string aName = contextName(aContext);
-      aMyDoc->addNamingName(aSelLab, aName);
-      TDataStd_Name::Set(aSelLab, aName.c_str());
     }
     return setInvalidIfFalse(aSelLab, aContext->shape() && !aContext->shape()->isNull());
   }
@@ -434,18 +448,58 @@ bool Model_AttributeSelection::update()
   if (aContext->groupName() == ModelAPI_ResultBody::group()) {
     // body: just a named shape, use selection mechanism from OCCT
     TNaming_Selector aSelector(aSelLab);
+    TopoDS_Shape anOldShape;
+    if (!aSelector.NamedShape().IsNull()) {
+      anOldShape = aSelector.NamedShape()->Get();
+    }
     bool aResult = aSelector.Solve(scope()) == Standard_True;
-    aResult = setInvalidIfFalse(aSelLab, aResult); // must be before sending of updated attribute (1556)
-    owner()->data()->sendAttributeUpdated(this);
+    // must be before sending of updated attribute (1556)
+    aResult = setInvalidIfFalse(aSelLab, aResult);
+    TopoDS_Shape aNewShape;
+    if (!aSelector.NamedShape().IsNull()) {
+      aNewShape = aSelector.NamedShape()->Get();
+    }
+    if (anOldShape.IsNull() || aNewShape.IsNull() ||
+        !anOldShape.IsEqual(aSelector.NamedShape()->Get())) {
+      // shape type shoud not not changed: if shape becomes compound of such shapes, then split
+      if (myParent && !anOldShape.IsNull() && !aNewShape.IsNull() &&
+          anOldShape.ShapeType() != aNewShape.ShapeType() &&
+          aNewShape.ShapeType() == TopAbs_COMPOUND) {
+        TopTools_ListOfShape aSubs;
+        for(TopoDS_Iterator anExplorer(aNewShape); anExplorer.More(); anExplorer.Next()) {
+          if (!anExplorer.Value().IsNull() &&
+              anExplorer.Value().ShapeType() == anOldShape.ShapeType()) {
+            aSubs.Append(anExplorer.Value());
+          } else { // invalid case; bad result shape, so, impossible to split easily
+            aSubs.Clear();
+            break;
+          }
+        }
+        if (aSubs.Extent() > 1) { // ok to split
+          TopTools_ListIteratorOfListOfShape aSub(aSubs);
+          GeomShapePtr aSubSh(new GeomAPI_Shape);
+          aSubSh->setImpl(new TopoDS_Shape(aSub.Value()));
+          setValue(aContext, aSubSh);
+          for(aSub.Next(); aSub.More(); aSub.Next()) {
+            GeomShapePtr aSubSh(new GeomAPI_Shape);
+            aSubSh->setImpl(new TopoDS_Shape(aSub.Value()));
+            myParent->append(aContext, aSubSh);
+          }
+        }
+      }
+      owner()->data()->sendAttributeUpdated(this);  // send updated if shape is changed
+    }
     return aResult;
-  } else if (aContext->groupName() == ModelAPI_ResultConstruction::group()) {
+  }
+
+  if (aContext->groupName() == ModelAPI_ResultConstruction::group()) {
     // construction: identification by the results indexes, recompute faces and
     // take the face that more close by the indexes
-    ResultConstructionPtr aConstructionContext = 
+    ResultConstructionPtr aConstructionContext =
       std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(aContext);
     FeaturePtr aContextFeature = aContext->document()->feature(aContext);
     // sketch sub-element
-    if (aConstructionContext && 
+    if (aConstructionContext &&
         std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(aContextFeature).get())
     {
       TDF_Label aLab = myRef.myRef->Label();
@@ -458,16 +512,17 @@ bool Model_AttributeSelection::update()
       // selected indexes will be needed in each "if"
       Handle(TDataStd_IntPackedMap) aSubIds;
       std::shared_ptr<GeomAPI_Shape> aNewSelected;
-      bool aNoIndexes = 
+      bool aNoIndexes =
         !aLab.FindAttribute(TDataStd_IntPackedMap::GetID(), aSubIds) || aSubIds->Extent() == 0;
       // for now working only with composite features
-      CompositeFeaturePtr aComposite = 
+      CompositeFeaturePtr aComposite =
         std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(aContextFeature);
       if (!aComposite.get() || aComposite->numberOfSubs() == 0) {
         return setInvalidIfFalse(aSelLab, false);
       }
 
-      if (aShapeType == TopAbs_FACE || aShapeType == TopAbs_WIRE) { // compound is for the whole sketch selection
+      if (aShapeType == TopAbs_FACE || aShapeType == TopAbs_WIRE) {
+        // compound is for the whole sketch selection
         // If this is a wire with plane defined then it is a sketch-like object
         if (!aConstructionContext->facesNum()) // no faces, update can not work correctly
           return setInvalidIfFalse(aSelLab, false);
@@ -477,7 +532,8 @@ bool Model_AttributeSelection::update()
           aNewSelected = aConstructionContext->face(0);
         } else { // searching for most looks-like initial face by the indexes
           // prepare edges of the current result for the fast searching
-          NCollection_DataMap<Handle(Geom_Curve), int> allCurves; // curves and orientations of edges
+          // curves and orientations of edges
+          NCollection_DataMap<Handle(Geom_Curve), int> allCurves;
           const int aSubNum = aComposite->numberOfSubs();
           for(int a = 0; a < aSubNum; a++) {
             int aSubID = aComposite->subFeatureId(a);
@@ -486,7 +542,7 @@ bool Model_AttributeSelection::update()
               const std::list<std::shared_ptr<ModelAPI_Result> >& aResults = aSub->results();
               std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aRes;
               for(aRes = aResults.cbegin(); aRes != aResults.cend(); aRes++) {
-                ResultConstructionPtr aConstr = 
+                ResultConstructionPtr aConstr =
                   std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(*aRes);
                 if (aConstr->shape() && aConstr->shape()->isEdge()) {
                   const TopoDS_Shape& aResShape = aConstr->shape()->impl<TopoDS_Shape>();
@@ -514,7 +570,9 @@ bool Model_AttributeSelection::update()
           setInvalidIfFalse(aSelLab, true);
           owner()->data()->sendAttributeUpdated(this);
           return true;
-        } else { // if the selection is not found, put the empty shape: it's better to have disappeared shape, than the old, the lost one
+        } else {
+          // if the selection is not found, put the empty shape:
+          // it's better to have disappeared shape, than the old, the lost one
           TNaming_Builder anEmptyBuilder(selectionLabel());
           return setInvalidIfFalse(aSelLab, false);
         }
@@ -529,7 +587,7 @@ bool Model_AttributeSelection::update()
             std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aResIter =
               aFeature->results().cbegin();
             for(;aResIter != aFeature->results().cend(); aResIter++) {
-              ResultConstructionPtr aRes = 
+              ResultConstructionPtr aRes =
                 std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(*aResIter);
               if (aRes && aRes->shape() && aRes->shape()->isEdge()) { // found!
                 selectConstruction(aContext, aRes->shape());
@@ -558,7 +616,7 @@ bool Model_AttributeSelection::update()
               std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aResIter =
                 aFeature->results().cbegin();
               for(;aResIter != aFeature->results().cend(); aResIter++) {
-                ResultConstructionPtr aRes = 
+                ResultConstructionPtr aRes =
                   std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(*aResIter);
                 if (aRes && aRes->shape()) {
                   if (aRes->shape()->isVertex() && aVertexNum == 0) { // found!
@@ -596,7 +654,6 @@ bool Model_AttributeSelection::update()
   return setInvalidIfFalse(aSelLab, false); // unknown case
 }
 
-
 void Model_AttributeSelection::selectBody(
   const ResultPtr& theContext, const std::shared_ptr<GeomAPI_Shape>& theSubShape)
 {
@@ -604,11 +661,11 @@ void Model_AttributeSelection::selectBody(
   TNaming_Selector aSel(selectionLabel());
   TopoDS_Shape aContext;
 
-  ResultBodyPtr aBody = std::dynamic_pointer_cast<ModelAPI_ResultBody>(myRef.value());
+  ResultBodyPtr aBody = std::dynamic_pointer_cast<ModelAPI_ResultBody>(theContext);//myRef.value()
   if (aBody) {
     aContext = aBody->shape()->impl<TopoDS_Shape>();
   } else {
-    ResultPtr aResult = 
+    ResultPtr aResult =
       std::dynamic_pointer_cast<ModelAPI_Result>(myRef.value());
     if (aResult) {
       aContext = aResult->shape()->impl<TopoDS_Shape>();
@@ -617,25 +674,97 @@ void Model_AttributeSelection::selectBody(
       return;
     }
   }
-  TopoDS_Shape aNewShape = theSubShape ? theSubShape->impl<TopoDS_Shape>() : aContext;
+
+  // with "recover" feature the selected context may be not up to date (issue 1710)
+  Handle(TNaming_NamedShape) aResult;
+  TDF_Label aSelLab = selectionLabel();
+  TopoDS_Shape aNewContext = aContext;
+  bool isUpdated = true;
+  while(!aNewContext.IsNull() && isUpdated) {
+    // searching for the very last shape that was produced from this one
+    isUpdated = false;
+    if (!TNaming_Tool::HasLabel(aSelLab, aNewContext))
+      // to avoid crash of TNaming_SameShapeIterator if pure shape does not exists
+      break;
+    for(TNaming_SameShapeIterator anIter(aNewContext, aSelLab); anIter.More(); anIter.Next()) {
+      TDF_Label aNSLab = anIter.Label();
+      if (!scope().Contains(aNSLab))
+        continue;
+      Handle(TNaming_NamedShape) aNS;
+      if (aNSLab.FindAttribute(TNaming_NamedShape::GetID(), aNS)) {
+        for(TNaming_Iterator aShapesIter(aNS); aShapesIter.More(); aShapesIter.Next()) {
+          if (aShapesIter.Evolution() == TNaming_SELECTED)
+            continue; // don't use the selection evolution
+          if (!aShapesIter.OldShape().IsNull() && aShapesIter.OldShape().IsSame(aNewContext)) {
+             // found the original shape
+            aNewContext = aShapesIter.NewShape(); // go to the newer shape
+            isUpdated = true;
+            break;
+          }
+        }
+      }
+    }
+  }
+  if (aNewContext.IsNull()) { // a context is already deleted
+    setInvalidIfFalse(aSelLab, false);
+    Events_InfoMessage("Model_AttributeSelection", "Failed to select shape already deleted").send();
+    return;
+  }
+
+  TopoDS_Shape aNewSub = theSubShape ? theSubShape->impl<TopoDS_Shape>() : aContext;
+  if (!aNewSub.IsEqual(aContext)) { // searching for subshape in the new context
+    bool isFound = false;
+    TopExp_Explorer anExp(aNewContext, aNewSub.ShapeType());
+    for(; anExp.More(); anExp.Next()) {
+      if (anExp.Current().IsEqual(aNewSub)) {
+        isFound = true;
+        break;
+      }
+    }
+    if (!isFound) { // sub-shape is not found in the up-to-date instance of the context shape
+      // if context is sub-result of compound/compsolid, selection of sub-shape better propagate to
+      // the main result (which is may be modified), case is in 1799
+      ResultCompSolidPtr aMain = ModelAPI_Tools::compSolidOwner(theContext);
+      if (aMain.get()) {
+        selectBody(aMain, theSubShape);
+        return;
+      }
+      setInvalidIfFalse(aSelLab, false);
+      Events_InfoMessage("Model_AttributeSelection",
+        "Failed to select sub-shape already modified").send();
+      return;
+    }
+  }
+
   /// fix for issue 411: result modified shapes must not participate in this selection mechanism
-  FeaturePtr aFeatureOwner = std::dynamic_pointer_cast<ModelAPI_Feature>(owner());
-  if (aFeatureOwner.get())
-    aFeatureOwner->eraseResults();
   if (!aContext.IsNull()) {
-    aSel.Select(aNewShape, aContext); 
+    FeaturePtr aFeatureOwner = std::dynamic_pointer_cast<ModelAPI_Feature>(owner());
+    bool aEraseResults = false;
+    if (aFeatureOwner.get()) {
+      aEraseResults = !aFeatureOwner->results().empty();
+      if (aEraseResults) // erase results without flash deleted and redisplay: do it after Select
+        aFeatureOwner->removeResults(0, false);
+    }
+    aSel.Select(aNewSub, aNewContext);
+
+    if (aEraseResults) { // flash after Select : in Groups it makes selection with shift working
+      static Events_Loop* aLoop = Events_Loop::loop();
+      static const Events_ID kDeletedEvent = aLoop->eventByName(EVENT_OBJECT_DELETED);
+      aLoop->flush(kDeletedEvent);
+    }
   }
 }
 
 /// registers the name of the shape in the label (theID == 0) of sub label (theID is a tag)
-/// if theID is zero, 
+/// if theID is zero,
 /// theOrientation is additional information about the positioning of edge relatively to face
-///    it is stored in the integer attribute of the edge sub-label: 
+///    it is stored in the integer attribute of the edge sub-label:
 ///    -1 is out, 1 is in, 0 is not needed
 static void registerSubShape(TDF_Label theMainLabel, TopoDS_Shape theShape,
   const int theID, const FeaturePtr& theContextFeature, std::shared_ptr<Model_Document> theDoc,
-  std::string theAdditionalName, std::map<int, int>& theOrientations,
-  std::map<int, std::string>& theSubNames, // name of sub-elements by ID to be exported instead of indexes
+  std::map<int, int>& theOrientations,
+  // name of sub-elements by ID to be exported instead of indexes
+  std::map<int, std::string>& theSubNames,
   Handle(TDataStd_IntPackedMap) theRefs = Handle(TDataStd_IntPackedMap)(),
   const int theOrientation = 0)
 {
@@ -646,23 +775,10 @@ static void registerSubShape(TDF_Label theMainLabel, TopoDS_Shape theShape,
   TNaming_Builder aBuilder(aLab);
   aBuilder.Generated(theShape);
   std::stringstream aName;
-  // add the part name if the selected object is located in other part
-  if (theDoc != theContextFeature->document()) {
-    if (theContextFeature->document() == ModelAPI_Session::get()->moduleDocument()) {
-      aName<<theContextFeature->document()->kind()<<"/";
-    } else {
-      ResultPtr aDocRes = ModelAPI_Tools::findPartResult(
-        ModelAPI_Session::get()->moduleDocument(), theContextFeature->document());
-      if (aDocRes.get()) {
-        aName<<aDocRes->data()->name()<<"/";
-      }
-    }
-  }
-  aName<<theContextFeature->name();
+  // #1839 : do not store name of the feature in the tree, since this name could be changed
+  //aName<<theContextFeature->name();
   if (theShape.ShapeType() != TopAbs_COMPOUND) { // compound means the whole result for construction
-    aName<<"/";
-    if (!theAdditionalName.empty())
-      aName<<theAdditionalName<<"/";
+    //aName<<"/";
     if (theShape.ShapeType() == TopAbs_FACE) aName<<"Face";
     else if (theShape.ShapeType() == TopAbs_WIRE) aName<<"Wire";
     else if (theShape.ShapeType() == TopAbs_EDGE) aName<<"Edge";
@@ -695,19 +811,19 @@ static void registerSubShape(TDF_Label theMainLabel, TopoDS_Shape theShape,
 void Model_AttributeSelection::selectConstruction(
   const ResultPtr& theContext, const std::shared_ptr<GeomAPI_Shape>& theSubShape)
 {
-  std::shared_ptr<Model_Document> aMyDoc = 
+  std::shared_ptr<Model_Document> aMyDoc =
     std::dynamic_pointer_cast<Model_Document>(owner()->document());
   FeaturePtr aContextFeature = theContext->document()->feature(theContext);
-  CompositeFeaturePtr aComposite = 
+  CompositeFeaturePtr aComposite =
     std::dynamic_pointer_cast<ModelAPI_CompositeFeature>(aContextFeature);
   const TopoDS_Shape& aSubShape = theSubShape->impl<TopoDS_Shape>();
   if (!aComposite || aComposite->numberOfSubs() == 0) {
     // saving of context is enough: result construction contains exactly the needed shape
     TNaming_Builder aBuilder(selectionLabel());
     aBuilder.Generated(aSubShape);
-    std::string aName = contextName(theContext);
-    aMyDoc->addNamingName(selectionLabel(), aName);
-    TDataStd_Name::Set(selectionLabel(), aName.c_str());
+    //std::string aName = contextName(theContext);
+    //aMyDoc->addNamingName(selectionLabel(), aName);
+    //TDataStd_Name::Set(selectionLabel(), aName.c_str());
     return;
   }
   std::shared_ptr<Model_Data> aData = std::dynamic_pointer_cast<Model_Data>(owner()->data());
@@ -720,7 +836,7 @@ void Model_AttributeSelection::selectConstruction(
   TColStd_MapOfTransient allCurves;
   if (aShapeType == TopAbs_VERTEX) { // compare positions
     aVertexPos = BRep_Tool::Pnt(TopoDS::Vertex(aSubShape));
-  } else { 
+  } else {
     for(TopExp_Explorer anEdgeExp(aSubShape, TopAbs_EDGE); anEdgeExp.More(); anEdgeExp.Next()) {
       TopoDS_Edge anEdge = TopoDS::Edge(anEdgeExp.Current());
       Standard_Real aFirst, aLast;
@@ -740,7 +856,7 @@ void Model_AttributeSelection::selectConstruction(
     std::list<std::shared_ptr<ModelAPI_Result> >::const_iterator aRes = aResults.cbegin();
     // there may be many shapes (circle and center): register if at least one is in selection
     for(; aRes != aResults.cend(); aRes++) {
-      ResultConstructionPtr aConstr = 
+      ResultConstructionPtr aConstr =
         std::dynamic_pointer_cast<ModelAPI_ResultConstruction>(*aRes);
       if (!aConstr->shape()) {
         continue;
@@ -789,7 +905,7 @@ void Model_AttributeSelection::selectConstruction(
                     int anOrient = Model_SelectionNaming::edgeOrientation(aSubShape, anEdge);
                     anOrientations[anID] = anOrient;
                     registerSubShape(
-                      selectionLabel(), anEdge, anID, aContextFeature, aMyDoc, "", anOrientations,
+                      selectionLabel(), anEdge, anID, aContextFeature, aMyDoc, anOrientations,
                       aSubNames, Handle(TDataStd_IntPackedMap)(), anOrient);
                   }
                 }
@@ -800,9 +916,9 @@ void Model_AttributeSelection::selectConstruction(
                 for(; anEdgeExp.More(); anEdgeExp.Next(), aTagIndex += kSTART_VERTEX_DELTA) {
                   TopoDS_Vertex aV = TopoDS::Vertex(anEdgeExp.Current());
 
-                  std::stringstream anAdditionalName; 
+                  std::stringstream anAdditionalName;
                   registerSubShape(
-                    selectionLabel(), aV, aTagIndex, aContextFeature, aMyDoc, "", anOrientations,
+                    selectionLabel(), aV, aTagIndex, aContextFeature, aMyDoc, anOrientations,
                     aSubNames);
                 }
               }
@@ -816,7 +932,7 @@ void Model_AttributeSelection::selectConstruction(
   TNaming_Builder aBuilder(selectionLabel());
   aBuilder.Generated(aSubShape);
     registerSubShape(
-      selectionLabel(), aSubShape, 0, aContextFeature, aMyDoc, "", anOrientations, aSubNames, aRefs); 
+      selectionLabel(), aSubShape, 0, aContextFeature, aMyDoc, anOrientations, aSubNames, aRefs);
 }
 
 bool Model_AttributeSelection::selectPart(
@@ -828,7 +944,8 @@ bool Model_AttributeSelection::selectPart(
     return true; // postponed naming
   if (theUpdate) {
     Handle(TDataStd_Integer) anIndex;
-    if (selectionLabel().FindAttribute(TDataStd_Integer::GetID(), anIndex)) { // by internal selection
+    if (selectionLabel().FindAttribute(TDataStd_Integer::GetID(), anIndex)) {
+      // by internal selection
       if (anIndex->Get() > 0) {
         // update the selection by index
         return aPart->updateInPart(anIndex->Get());
@@ -883,12 +1000,12 @@ void Model_AttributeSelection::selectSubShape(
 
   // check this is Part-name: 2 delimiters in the name
   std::size_t aPartEnd = theSubShapeName.find('/');
-  if (aPartEnd != string::npos && aPartEnd != theSubShapeName.rfind('/')) {
+  if (aPartEnd != std::string::npos && aPartEnd != theSubShapeName.rfind('/')) {
     std::string aPartName = theSubShapeName.substr(0, aPartEnd);
     ObjectPtr aFound = owner()->document()->objectByName(ModelAPI_ResultPart::group(), aPartName);
     if (aFound.get()) { // found such part, so asking it for the name
       ResultPartPtr aPart = std::dynamic_pointer_cast<ModelAPI_ResultPart>(aFound);
-      string aNameInPart = theSubShapeName.substr(aPartEnd + 1);
+      std::string aNameInPart = theSubShapeName.substr(aPartEnd + 1);
       int anIndex;
       std::shared_ptr<GeomAPI_Shape> aSelected = aPart->shapeInPart(aNameInPart, theType, anIndex);
       if (aSelected.get()) {
@@ -900,12 +1017,12 @@ void Model_AttributeSelection::selectSubShape(
   }
 
   Model_SelectionNaming aSelNaming(selectionLabel());
-  std::shared_ptr<Model_Document> aDoc = 
+  std::shared_ptr<Model_Document> aDoc =
     std::dynamic_pointer_cast<Model_Document>(owner()->document());
   std::shared_ptr<GeomAPI_Shape> aShapeToBeSelected;
   ResultPtr aCont;
   if (aSelNaming.selectSubShape(theType, theSubShapeName, aDoc, aShapeToBeSelected, aCont)) {
-    // try to find the last context to find the up to dat shape
+    // try to find the last context to find the up to date shape
     if (aCont->shape().get() && !aCont->shape()->isNull() &&
       aCont->groupName() == ModelAPI_ResultBody::group() && aDoc == owner()->document()) {
       const TopoDS_Shape aConShape = aCont->shape()->impl<TopoDS_Shape>();
@@ -1017,3 +1134,79 @@ std::string Model_AttributeSelection::contextName(const ResultPtr& theContext) c
   aResult += theContext->data()->name();
   return aResult;
 }
+
+void Model_AttributeSelection::updateInHistory()
+{
+  ResultPtr aContext = std::dynamic_pointer_cast<ModelAPI_Result>(myRef.value());
+  // only bodies may be modified later in the history, don't do anything otherwise
+  if (!aContext.get() || aContext->groupName() != ModelAPI_ResultBody::group())
+    return;
+  std::shared_ptr<Model_Data> aContData = std::dynamic_pointer_cast<Model_Data>(aContext->data());
+  if (!aContData.get() || !aContData->isValid())
+    return;
+  TDF_Label aContLab = aContData->label(); // named shape where the selected context is located
+  Handle(TNaming_NamedShape) aContNS;
+  if (!aContLab.FindAttribute(TNaming_NamedShape::GetID(), aContNS))
+    return;
+  std::shared_ptr<Model_Document> aDoc =
+    std::dynamic_pointer_cast<Model_Document>(aContext->document());
+  FeaturePtr aThisFeature = std::dynamic_pointer_cast<ModelAPI_Feature>(owner());
+  FeaturePtr aCurrentModifierFeat = aDoc->feature(aContext);
+  // iterate the context shape modifications in order to find a feature that is upper in history
+  // that this one and is really modifies the referenced result to refer to it
+  ResultPtr aModifierResFound;
+  TNaming_Iterator aPairIter(aContNS);
+  TopoDS_Shape aNewShape = aPairIter.NewShape();
+  bool anIterate = true;
+  // trying to update also the sub-shape selected
+  GeomShapePtr aSubShape = value();
+  if (aSubShape.get() && aSubShape->isEqual(aContext->shape()))
+    aSubShape.reset();
+
+  while(anIterate) {
+    anIterate = false;
+    TNaming_SameShapeIterator aModifIter(aNewShape, aContLab);
+    for(; aModifIter.More(); aModifIter.Next()) {
+      ResultPtr aModifierObj = std::dynamic_pointer_cast<ModelAPI_Result>
+        (aDoc->objects()->object(aModifIter.Label().Father()));
+      if (!aModifierObj.get())
+        break;
+      FeaturePtr aModifierFeat = aDoc->feature(aModifierObj);
+      if (!aModifierFeat.get())
+        break;
+      if (aModifierFeat == aThisFeature || aDoc->objects()->isLater(aModifierFeat, aThisFeature))
+        continue; // the modifier feature is later than this, so, should not be used
+      if (aCurrentModifierFeat == aModifierFeat ||
+        aDoc->objects()->isLater(aCurrentModifierFeat, aModifierFeat))
+        continue; // the current modifier is later than the found, so, useless
+      Handle(TNaming_NamedShape) aNewNS;
+      aModifIter.Label().FindAttribute(TNaming_NamedShape::GetID(), aNewNS);
+      if (aNewNS->Evolution() == TNaming_MODIFY || aNewNS->Evolution() == TNaming_GENERATED) {
+        aModifierResFound = aModifierObj;
+        aCurrentModifierFeat = aModifierFeat;
+        TNaming_Iterator aPairIter(aNewNS);
+        aNewShape = aPairIter.NewShape();
+        anIterate = true;
+        break;
+      } else if (aNewNS->Evolution() == TNaming_DELETE) { // a shape was deleted => result is null
+        ResultPtr anEmptyContext;
+        std::shared_ptr<GeomAPI_Shape> anEmptyShape;
+        setValue(anEmptyContext, anEmptyShape); // nullify the selection
+        return;
+      } else { // not-precessed modification => don't support it
+        continue;
+      }
+    }
+  }
+  if (aModifierResFound.get()) {
+    // update scope to reset to a new one
+    myScope.Clear();
+    myRef.setValue(aModifierResFound);
+    update(); // it must recompute a new sub-shape automatically
+  }
+}
+
+void Model_AttributeSelection::setParent(Model_AttributeSelectionList* theParent)
+{
+  myParent = theParent;
+}