Modifications done to respect PMD rules. Versioning a document is fixed. Validation...

[tools/siman.git] / Workspace / Siman-Common / src / org / splat / service / ProjectElementServiceImpl.java

diff --git a/Workspace/Siman-Common/src/org/splat/service/ProjectElementServiceImpl.java b/Workspace/Siman-Common/src/org/splat/service/ProjectElementServiceImpl.java
index b8a35358a7c28cae24ea90f6fbbed4003ab7bd09..f5ec91e9abdbd1d0891ef60e416a38f512abde61 100644 (file)
--- a/Workspace/Siman-Common/src/org/splat/service/ProjectElementServiceImpl.java
+++ b/Workspace/Siman-Common/src/org/splat/service/ProjectElementServiceImpl.java
@@ -30,7 +30,7 @@ public class ProjectElementServiceImpl implements ProjectElementService {
        /**
         * Injected project settings service.
         */
-       private ProjectSettingsService _projectSettingsService;
+       private ProjectSettingsService _projectSettings;
        /**
         * Injected project element DAO.
         */
@@ -41,11 +41,11 @@ public class ProjectElementServiceImpl implements ProjectElementService {
         * 
         * @see org.splat.service.ProjectElementService#getFirstStep(org.splat.dal.bo.som.ProjectElement)
         */
-       public Step getFirstStep(ProjectElement elem) {
+       public Step getFirstStep(final ProjectElement elem) {
                return getSteps(elem)[0];
        }
 
-       public Step getLastStep(ProjectElement elem) {
+       public Step getLastStep(final ProjectElement elem) {
                Step[] mystep = getSteps(elem); // For getting the folders length, if null
                return mystep[mystep.length - 1];
        }
@@ -55,7 +55,7 @@ public class ProjectElementServiceImpl implements ProjectElementService {
         * 
         * @see org.splat.service.ProjectElementService#getSteps(org.splat.dal.bo.som.ProjectElement)
         */
-       public Step[] getSteps(ProjectElement elem) {
+       public Step[] getSteps(final ProjectElement elem) {
                if (elem.getFolders() == null) {
                        List<ProjectSettingsService.Step> steps = getProjectSettings()
                                        .getStepsOf(elem.getClass());
@@ -76,15 +76,16 @@ public class ProjectElementServiceImpl implements ProjectElementService {
         * @param elem the project element to refresh
         */
        @Transactional
-       public void refresh(ProjectElement elem) {
+       public void refresh(final ProjectElement elem) {
                // -------------------------
                Publication[] curdoc = elem.getDocums().toArray(
                                new Publication[elem.getDocums().size()]);
 
                elem.setFolders(null); // Just in case
                elem.getDocums().clear();
-               for (int i = 0; i < curdoc.length; i++)
+               for (int i = 0; i < curdoc.length; i++) {
                        elem.getDocums().add(curdoc[i]);
+               }
                // No need to rebuild the list of SimulationContext as it does not use hashcodes
                getProjectElementDAO().update(elem);
        }
@@ -95,7 +96,7 @@ public class ProjectElementServiceImpl implements ProjectElementService {
         * @return Project settings service
         */
        private ProjectSettingsService getProjectSettings() {
-               return _projectSettingsService;
+               return _projectSettings;
        }
 
        /**
@@ -104,8 +105,8 @@ public class ProjectElementServiceImpl implements ProjectElementService {
         * @param projectSettingsService
         *            project settings service
         */
-       public void setProjectSettings(ProjectSettingsService projectSettingsService) {
-               _projectSettingsService = projectSettingsService;
+       public void setProjectSettings(final ProjectSettingsService projectSettingsService) {
+               _projectSettings = projectSettingsService;
        }
 
        /**
@@ -120,7 +121,7 @@ public class ProjectElementServiceImpl implements ProjectElementService {
         * Set the projectElementDAO.
         * @param projectElementDAO the projectElementDAO to set
         */
-       public void setProjectElementDAO(ProjectElementDAO projectElementDAO) {
+       public void setProjectElementDAO(final ProjectElementDAO projectElementDAO) {
                _projectElementDAO = projectElementDAO;
        }
 }