Modifications to respect PMD rules.

[tools/siman.git] / Workspace / Siman / src / org / splat / simer / OpenKnowledge.java

diff --git a/Workspace/Siman/src/org/splat/simer/OpenKnowledge.java b/Workspace/Siman/src/org/splat/simer/OpenKnowledge.java
index 63e7fff7e632f2cc4591989adc7a08c6c4429c3d..cca5b9f9531aafe810ebe3b79272af2c6e748866 100644 (file)
--- a/Workspace/Siman/src/org/splat/simer/OpenKnowledge.java
+++ b/Workspace/Siman/src/org/splat/simer/OpenKnowledge.java
@@ -16,16 +16,16 @@ import org.splat.wapp.SimpleMenu;
 /**
  * Open knowledge details for presentation.
  */
-public class OpenKnowledge extends OpenObject {
+public class OpenKnowledge extends AbstractOpenObject {
 
        /**
         * The open knowledge element DTO.
         */
-       private KnowledgeElementDTO myknelm = new KnowledgeElementDTO();
+       private transient KnowledgeElementDTO _myknelm = new KnowledgeElementDTO();
        /**
         * Creation date.
         */
-       private String credate;
+       private transient String _credate;
 
        /**
         * Knowledge element left menu.
@@ -37,7 +37,7 @@ public class OpenKnowledge extends OpenObject {
                 * @param context
                 *            the list of steps
                 */
-               public Menu(List<Step> context) {
+               public Menu(final List<Step> context) {
                        super("steps", "study");
                        int i = 0;
                        int j = 0;
@@ -45,12 +45,14 @@ public class OpenKnowledge extends OpenObject {
                                Step step = k.next();
                                int number = step.getNumber();
                                String icon;
-                               if (step.mayContain(KnowledgeElement.class))
+                               if (step.mayContain(KnowledgeElement.class)) {
                                        j = i + 1; // Steps are numbered from 1 to N
-                               if (!step.isStarted())
-                                       icon = "icon.empty.png";
-                               else
+                               }
+                               if (step.isStarted()) {
                                        icon = "icon.done.png";
+                               } else {
+                                       icon = "icon.empty.png";
+                               }
                                addItem(String.valueOf(number), "folder.step." + number, icon,
                                                "step-knowledge?selection=" + number);
                        }
@@ -69,7 +71,7 @@ public class OpenKnowledge extends OpenObject {
         *            the knowledge element DTO
         * @return the open knowledge presentation
         */
-       public OpenKnowledge open(KnowledgeElementDTO knelm) {
+       public OpenKnowledge open(final KnowledgeElementDTO knelm) {
                ResourceBundle label = ResourceBundle.getBundle("labels",
                                getApplicationSettings().getCurrentLocale());
                ResourceBundle custom = ResourceBundle.getBundle("som",
@@ -80,23 +82,24 @@ public class OpenKnowledge extends OpenObject {
                String sceneTitle = knelm.getScenarioTitle();
                String studyTitle = knelm.getStudyTitle();
 
-               myknelm = knelm;
+               _myknelm = knelm;
 
                // Preparation of the display
-               credate = convert.format(myknelm.getDate());
+               _credate = convert.format(_myknelm.getDate());
                // involving = getAllSteps(knelm.getOwnerScenario());
-               involving = knelm.getInvolving();
-               context = new ArrayList<SimulationContextFacade>();
-               menu = new Menu(getInvolvedSteps());
-               selection = menu.getSelection(); // The default selection is set in the menu definition
-               int index = Integer.valueOf(selection);
-               for (Iterator<Step> i = involving.iterator(); i.hasNext();) {
+               _involving = knelm.getInvolving();
+               _context = new ArrayList<SimulationContextFacade>();
+               _menu = new Menu(getInvolvedSteps());
+               _selection = _menu.getSelection(); // The default selection is set in the menu definition
+               int index = Integer.valueOf(_selection);
+               for (Iterator<Step> i = _involving.iterator(); i.hasNext();) {
                        Step next = i.next();
-                       if (next.getNumber() == index)
-                               ustep = next;
+                       if (next.getNumber() == index) {
+                               _ustep = next;
+                       }
                        for (Iterator<SimulationContext> j = next
                                        .getAllSimulationContexts().iterator(); j.hasNext();) {
-                               context.add(new SimulationContextFacade(j.next(),
+                               _context.add(new SimulationContextFacade(j.next(),
                                                getProjectSettings().getAllSteps()));
                        }
                }
@@ -107,7 +110,7 @@ public class OpenKnowledge extends OpenObject {
                                .append("\",").append("<br>")
                                .append(sceneTitle/* scene.getTitle() */).append(".").append(
                                                "</p>");
-               description = value.toString();
+               _description = value.toString();
                setupContents(); // Initializes documents and knowledge at ustep
                return this;
        }
@@ -117,52 +120,54 @@ public class OpenKnowledge extends OpenObject {
        // ==============================================================================================================================
 
        public String getAuthorName() {
-               return myknelm.getAuthor().toString();
+               return _myknelm.getAuthor().toString();
        }
 
        public String getDate() {
-               return credate;
+               return _credate;
        }
 
        public Long getIndex() {
-               return myknelm.getIndex();
+               return _myknelm.getIndex();
        }
 
+       @Override
        public Menu getMenu() {
-               return (Menu) menu;
+               return (Menu) _menu;
        }
 
        public ProgressState getProgressState() {
-               return myknelm.getProgressState();
+               return _myknelm.getProgressState();
        }
 
        public String getReference() {
-               return myknelm.getReference();
+               return _myknelm.getReference();
        }
 
        public KnowledgeElementDTO getKnowledgeObject() {
-               return myknelm;
+               return _myknelm;
        }
 
        public String getTitle() {
-               return myknelm.getTitle();
+               return _myknelm.getTitle();
        }
 
        public String getType() {
                return ResourceBundle.getBundle("som",
                                getApplicationSettings().getCurrentLocale()).getString(
-                               "type.knowledge." + myknelm.getType().getName());
+                               "type.knowledge." + _myknelm.getType().getName());
        }
 
-       public void setSelection(String step) {
-               selection = step;
-               int index = Integer.valueOf(selection);
-               for (Iterator<Step> i = involving.iterator(); i.hasNext();) {
-                       ustep = i.next();
-                       if (ustep.getNumber() == index)
+       public void setSelection(final String step) {
+               _selection = step;
+               int index = Integer.valueOf(_selection);
+               for (Iterator<Step> i = _involving.iterator(); i.hasNext();) {
+                       _ustep = i.next();
+                       if (_ustep.getNumber() == index) {
                                break;
+                       }
                }
-               menu.selects(selection);
+               _menu.selects(_selection);
                setupContents(); // The contents may have changed even if the selection is the same
        }
 }
\ No newline at end of file