Modifications to respect PMD rules.

[tools/siman.git] / Workspace / Converter / src / Launcher.java

diff --git a/Workspace/Converter/src/Launcher.java b/Workspace/Converter/src/Launcher.java
index 9bb42a2b64a3282b2397c35c60563c614a229cce..bc611d70fcace08eae75ff15593a5a624e181898 100644 (file)
--- a/Workspace/Converter/src/Launcher.java
+++ b/Workspace/Converter/src/Launcher.java
@@ -1,44 +1,47 @@
-import java.io.*;
+import java.io.BufferedWriter;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileWriter;
+import java.io.IOException;
+import java.io.PrintStream;
+import java.io.Writer;
 import java.util.Properties;
 
-import javax.jms.Connection;
-import javax.jms.ConnectionFactory;
-import javax.jms.MessageProducer;
-import javax.jms.Queue;
-import javax.jms.Session;
-import javax.jms.TextMessage;
 import javax.naming.Context;
 import javax.naming.InitialContext;
 
+public class Launcher { //RKV: NOPMD: TODO: Move this class into a package
 
-public class Launcher {
-
-    private String  executable;
-    private String  source;
-    private File    log;
+    private transient String  _executable;
+    private transient String  _source;
+    private transient File    _log;
 
 //  ==============================================================================================================================
 //  Main
 //  ==============================================================================================================================
 
-       public static void main(String[] args) {
+       public static void main(final String[] args) {
 //  --------------------------------------
-         if (args.length < 2) return;
+         if (args.length < 2) {
+               return;
+       }
 
       Launcher session     = new Launcher();
-      session.executable  = args[0];
-      session.source      = args[1];
+      session._executable  = args[0];
+      session._source      = args[1];
 
-      String[]      parse = session.source.split("\\x2E");
+      String[]      parse = session._source.split("\\x2E");
       StringBuffer  path  = new StringBuffer(parse[0]);
-      for (int i=1; i<parse.length-1; i++) path.append(".").append(parse[i]);
+      for (int i=1; i<parse.length-1; i++) {
+               path.append(".").append(parse[i]);
+       }
       try {
-        session.log = new File(path.append(".").append("log").toString());
-        session.log.createNewFile();
+        session._log = new File(path.append(".").append("log").toString());
+        session._log.createNewFile();
         session.doConvert();
       }
       catch (Exception error) {
-       System.out.print(error.getMessage());
+       System.out.print(error.getMessage()); //RKV: NOPMD: TODO: use logger?
       }
        }
 
@@ -48,9 +51,9 @@ public class Launcher {
 
     private void doConvert () throws IOException {
 //  -------------------------
-      Writer  output = new BufferedWriter( new FileWriter(log) );
+      Writer  output = new BufferedWriter( new FileWriter(_log) );
 
-      output.write("Conversion of " + source + "\r\n");
+      output.write("Conversion of " + _source + "\r\n");
       try {
         String            jndir     = System.getProperty("resource.dir") + "jndi.conf";
         File              propfile  = new File(jndir);
@@ -66,7 +69,7 @@ public class Launcher {
 //        MessageProducer   myself    = session.createProducer(queue);
 //        TextMessage       message   = session.createTextMessage();
 
-        output.write("Launching converter " + executable + "\r\n");
+        output.write("Launching converter " + _executable + "\r\n");
         output.write("Context : " + context.toString() + "\r\n");
 
 //      Process           converter = Runtime.getRuntime().exec("\"" + executable + "\" " + source);
@@ -78,7 +81,7 @@ public class Launcher {
       }
       catch (Exception error) {
        output.write("ERROR Converter Launcher, reason:\r\n");
-       error.printStackTrace( new PrintStream(log) );
+       error.printStackTrace( new PrintStream(_log) );
       }
       output.close();
     }